[krita] [Bug 430240] Krita doesn't warn when exporting layers with multiple transparency masks into .psd
https://bugs.kde.org/show_bug.cgi?id=430240 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/c09df6581 ||f5ffc04e684041aacb7afe0763d ||0aac Status|ASSIGNED|RESOLVED --- Comment #12 from Dmitry Kazakov --- Git commit c09df6581f5ffc04e684041aacb7afe0763d0aac by Dmitry Kazakov, on behalf of Srirupa Datta. Committed on 16/04/2021 at 13:19. Pushed by dkazakov into branch 'master'. Warn when exporting layers with multiple transparency masks into .psd Added MultiTransparencyMaskCheck.h that shows a warning message whenever an unsaved, new document is exported to a file format that doesn't support a layer with multiple transparency masks. FIXED IN:5.0.0 M +5-0libs/impex/KisExportCheckRegistry.cpp A +77 -0libs/impex/MultiTransparencyMaskCheck.h [License: LGPL(v2.0+)] https://invent.kde.org/graphics/krita/commit/c09df6581f5ffc04e684041aacb7afe0763d0aac -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 430240] Krita doesn't warn when exporting layers with multiple transparency masks into .psd
https://bugs.kde.org/show_bug.cgi?id=430240 Bug Janitor Service changed: What|Removed |Added Status|REPORTED|ASSIGNED Ever confirmed|0 |1 --- Comment #11 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/801 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 430240] Krita doesn't warn when exporting layers with multiple transparency masks into .psd
https://bugs.kde.org/show_bug.cgi?id=430240 --- Comment #10 from Srirupa Datta --- Okay, sure! I'll let you know once it's done. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 430240] Krita doesn't warn when exporting layers with multiple transparency masks into .psd
https://bugs.kde.org/show_bug.cgi?id=430240 --- Comment #9 from Halla Rempt --- Please make a merge request -- if there are changes needed, it's easier to do that on the MR. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 430240] Krita doesn't warn when exporting layers with multiple transparency masks into .psd
https://bugs.kde.org/show_bug.cgi?id=430240 --- Comment #8 from Srirupa Datta --- Okay, thanks, I guess I should learn a bit more about channels. I did work on the warning as you said. Currently the warning shows: "The image has more than one transparency mask in a layer. For all layers having multiple transparency masks, only the rendered result will be saved." It's shown in case of exporting to psd, and not in case of png, jpg, and similar file formats. Should I create a merge request or would you want me to add something? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 430240] Krita doesn't warn when exporting layers with multiple transparency masks into .psd
https://bugs.kde.org/show_bug.cgi?id=430240 --- Comment #7 from Halla Rempt --- Well, yes and no. In very early versions of Photoshop (5 was the first version I got a manual for), you could add extra channels and they could be activated and function as a transparency mask. That functionality has never been removed, of course. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 430240] Krita doesn't warn when exporting layers with multiple transparency masks into .psd
https://bugs.kde.org/show_bug.cgi?id=430240 --- Comment #6 from Srirupa Datta --- Oh, okay, got it. I don't know much about Photoshop, but I thought that transparency mask in Krita is equivalent to layer mask in Photoshop, and channels in Krita are equivalent to channels in Photoshop. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 430240] Krita doesn't warn when exporting layers with multiple transparency masks into .psd
https://bugs.kde.org/show_bug.cgi?id=430240 --- Comment #5 from Halla Rempt --- For the warning, you don't need to make any dialog. You need to make something similar to MultiLayerCheck that specifically checks for multiple transparency masks and integrate that in KisExportCheckRegistry. Then exporting a layer with multiple transparency masks to any file format that doesn't support those will give a warning automatically, together with all possible other warnings. That's the first thing to do. The second thing would be to change the psd export code to do the merging. We could add an export options dialog to PSD to give people a choice between merging and discarding, but... I am not convinced that we should do this. What we probably should do instead is save all further transparency masks as Photoshop channels, because that's the real equivalent of our transparency masks. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 430240] Krita doesn't warn when exporting layers with multiple transparency masks into .psd
https://bugs.kde.org/show_bug.cgi?id=430240 --- Comment #4 from Srirupa Datta --- I was thinking about making something similar to what happens when I click, for example, the png option in the exporting dialog, and then on clicking Save, another dialog opens(PNG image - Krita), where I get options related to compression and all. So I was hoping to do something similar with psd, like I go to File -> Export -> Choose psd, and on clicking Save, a similar dialog opens(PSD - Krita), where on clicking Okay, the file gets saved. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 430240] Krita doesn't warn when exporting layers with multiple transparency masks into .psd
https://bugs.kde.org/show_bug.cgi?id=430240 --- Comment #3 from Halla Rempt --- Yes, but you shouldn't show this in a separate dialog, but work within the existing file format capabilities framework. See libs/impex. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 430240] Krita doesn't warn when exporting layers with multiple transparency masks into .psd
https://bugs.kde.org/show_bug.cgi?id=430240 Srirupa Datta changed: What|Removed |Added CC||srirupa@gmail.com --- Comment #2 from Srirupa Datta --- Can I work on this? I was thinking that a warning dialog with two options can be shown, either to discard or convert into a single layer(as you suggested). I also couldn't find how I can merge transparency masks like I can do with the paint layers. I was looking through the source code and found that the kis_mask source file doesn't have any merging function. Can this feature be added if it's not there? It might take some time as I'm not that familiar with the source code, but I'm willing to try! -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 430240] Krita doesn't warn when exporting layers with multiple transparency masks into .psd
https://bugs.kde.org/show_bug.cgi?id=430240 Boudewijn Rempt changed: What|Removed |Added CC||b...@valdyas.org --- Comment #1 from Boudewijn Rempt --- Think you can pick this up? It's a "simple" matter of just writing another capability check... -- You are receiving this mail because: You are watching all bug changes.
