[krita] [Bug 438754] Animation & Frame rendering clones limit: render in failure

2021-07-09 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=438754

--- Comment #13 from grum...@grum.fr ---
I confirm that option "frameRenderingTimeout" fixed the problem :) 


Grum999

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 438754] Animation & Frame rendering clones limit: render in failure

2021-07-07 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=438754

--- Comment #12 from Dmitry Kazakov  ---
Git commit d58edd016870ac294a8f8c79c0a10fceee1a by Dmitry Kazakov.
Committed on 07/07/2021 at 11:37.
Pushed by dkazakov into branch 'krita/5.0'.

Add a (hidden) config option to increase frame rendering timeout

If you see random failures while rendering frames for huge images,
just open kritarc file and add the following option:

frameRenderingTimeout=6

Where '6' is the timeout in milliseconds. The default value is
30 seconds and it seems like it is too small for some weird usecases.
CC:kimages...@kde.org

M  +11   -0libs/image/kis_image_config.cpp
M  +3-0libs/image/kis_image_config.h
M  +6-3libs/ui/KisAsyncAnimationRendererBase.cpp

https://invent.kde.org/graphics/krita/commit/d58edd016870ac294a8f8c79c0a10fceee1a

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 438754] Animation & Frame rendering clones limit: render in failure

2021-07-07 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=438754

--- Comment #11 from Dmitry Kazakov  ---
Git commit 2d9a0878a2ea35c0708f91f38ed8a3075735cd4c by Dmitry Kazakov.
Committed on 07/07/2021 at 08:29.
Pushed by dkazakov into branch 'master'.

Add a (hidden) config option to increase frame rendering timeout

If you see random failures while rendering frames for huge images,
just open kritarc file and add the following option:

frameRenderingTimeout=6

Where '6' is the timeout in milliseconds. The default value is
30 seconds and it seems like it is too small for some weird usecases.
CC:kimages...@kde.org

M  +11   -0libs/image/kis_image_config.cpp
M  +3-0libs/image/kis_image_config.h
M  +6-3libs/ui/KisAsyncAnimationRendererBase.cpp

https://invent.kde.org/graphics/krita/commit/2d9a0878a2ea35c0708f91f38ed8a3075735cd4c

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 438754] Animation & Frame rendering clones limit: render in failure

2021-07-05 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=438754

grum...@grum.fr changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #10 from grum...@grum.fr ---
Ooops sorry
Not on the right tab, I reopened the wrong bug ^_^'

I put it back to RESOLVED :) 


Grum999

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 438754] Animation & Frame rendering clones limit: render in failure

2021-07-05 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=438754

grum...@grum.fr changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 438754] Animation & Frame rendering clones limit: render in failure

2021-07-05 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=438754

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/00b8f3312
   ||60f14792c165298857668446737
   ||d918
 Status|CONFIRMED   |RESOLVED

--- Comment #9 from Dmitry Kazakov  ---
Git commit 00b8f331260f14792c165298857668446737d918 by Dmitry Kazakov.
Committed on 05/07/2021 at 10:39.
Pushed by dkazakov into branch 'master'.

Fix animation rendering interrupts caused by autosave

KisRegenerateFrameStrokeStrategy should not be forgettable when
the user wants to render his/her video.

M  +2-1libs/image/kis_image_animation_interface.cpp
M  +1-1libs/image/kis_image_animation_interface.h
M  +2-1libs/image/kis_regenerate_frame_stroke_strategy.cpp
M  +1-1libs/image/kis_regenerate_frame_stroke_strategy.h
M  +3-3libs/image/tests/kis_image_animation_interface_test.cpp
M  +4-4libs/ui/KisAsyncAnimationRendererBase.cpp
M  +13   -2libs/ui/KisAsyncAnimationRendererBase.h
M  +1-1libs/ui/kis_animation_cache_populator.cpp

https://invent.kde.org/graphics/krita/commit/00b8f331260f14792c165298857668446737d918

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 438754] Animation & Frame rendering clones limit: render in failure

2021-07-05 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=438754

--- Comment #8 from Dmitry Kazakov  ---
*** Bug 438760 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 438754] Animation & Frame rendering clones limit: render in failure

2021-06-21 Thread Eoin O'Neill
https://bugs.kde.org/show_bug.cgi?id=438754

Eoin O'Neill  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |eoinoneill1...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 438754] Animation & Frame rendering clones limit: render in failure

2021-06-20 Thread Eoin O'Neill
https://bugs.kde.org/show_bug.cgi?id=438754

--- Comment #7 from Eoin O'Neill  ---
I see, that confirms that it's not the single reused image but has to do with
the cloning process.

Thanks for testing that! I'll begin investigating this again sometime this
upcoming week.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 438754] Animation & Frame rendering clones limit: render in failure

2021-06-20 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=438754

--- Comment #6 from grum...@grum.fr ---
Hi

Finally I was able to test the commit (I had to build Krita on my side as with
the provided appimage it was not possible to open my test files;
https://krita-artists.org/t/krita-crash-on-opening-kra-file/25342?u=grum999)

The change made with commit didn't change anything; I'm still unable to render
most of animation with all CPU.

(I have considered that only this commit was important for testing:
https://invent.kde.org/eoinoneill/krita/-/commit/b9b8de2dfbafa1a27f566ebed23451a8e1b8b222)


Grum999

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 438754] Animation & Frame rendering clones limit: render in failure

2021-06-19 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=438754

--- Comment #5 from grum...@grum.fr ---
(In reply to Eoin O'Neill from comment #3)
> I'm sorry, I must have pasted the wrong link. Here's the real link to the
> AppImage:
> 
> https://www.dropbox.com/s/laarm1lqqld73ta/krita-5.0.0-prealpha-grum-b9b8de2-
> x86_64.appimage?dl=0
I'm not able to reopen any Krita file used for testing (krita crash with "No
attribute color space for layer: " )
And also can't reproduce some file case (impossible to use Layer style with 
this appimage, it crash immediately)

So I'll try to create a document directly with this appimage, but I'm not sure
to be able to reproduce the same situation.



Grum999

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 438754] Animation & Frame rendering clones limit: render in failure

2021-06-18 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=438754

--- Comment #4 from grum...@grum.fr ---
(In reply to Eoin O'Neill from comment #3)
> I'm sorry, I must have pasted the wrong link. Here's the real link to the
> AppImage:
> 
Oh thanks!

I've downloaded it.
Tomorrow it's saturday, I'll have time to test it :) 



On my side, I also encountered the problem with my 4CPU laptop.
> Rendering the “Halftone test” with the 4 CPU has failed after 412 files…
>
>Edit: the 4 CPU laptop randomly failed/success to generate all frames (but 
>most of time it successfully finish render)

But that's sure the problem doesn't occurs as frequently as with more CPU (only
be able to reproduce it once time, but it's so slow on 4CPU that I didn't make
as much test as with my workstation)



Grum999

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 438754] Animation & Frame rendering clones limit: render in failure

2021-06-17 Thread Eoin O'Neill
https://bugs.kde.org/show_bug.cgi?id=438754

--- Comment #3 from Eoin O'Neill  ---
(In reply to Eoin O'Neill from comment #2)
> Hi Grum,
> 
> I've uploaded an AppImage for you to test to my DropBox since the file was
> too large to upload to BugZilla. For the sake of transparency (or if you
> wish to build it yourself), you can see the commit history here:
> https://invent.kde.org/eoinoneill/krita/-/commits/grum 
> 
> Here's the link to the AppImage:
> https://www.dropbox.com/home/KritaFiles?preview=krita-5.0.0-prealpha-grum-
> b9b8de2-x86_64.appimage
> 
> Basically, since I don't have the hardware necessary to reproduce this
> consistently, I want to know whether or not the above AppImage solves some
> of the problems you have currently with rendering animations on your
> machine. If it does, it might help direct me toward a solution to this
> problem.
> 
> I think it's also very likely that 438760 is related to this bug, so maybe
> also test to see if that bug is resolved by this change too. 
> 
> Thanks,
> Eoin.


I'm sorry, I must have pasted the wrong link. Here's the real link to the
AppImage:

https://www.dropbox.com/s/laarm1lqqld73ta/krita-5.0.0-prealpha-grum-b9b8de2-x86_64.appimage?dl=0

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 438754] Animation & Frame rendering clones limit: render in failure

2021-06-17 Thread Eoin O'Neill
https://bugs.kde.org/show_bug.cgi?id=438754

Eoin O'Neill  changed:

   What|Removed |Added

 CC||eoinoneill1...@gmail.com

--- Comment #2 from Eoin O'Neill  ---
Hi Grum,

I've uploaded an AppImage for you to test to my DropBox since the file was too
large to upload to BugZilla. For the sake of transparency (or if you wish to
build it yourself), you can see the commit history here:
https://invent.kde.org/eoinoneill/krita/-/commits/grum 

Here's the link to the AppImage:
https://www.dropbox.com/home/KritaFiles?preview=krita-5.0.0-prealpha-grum-b9b8de2-x86_64.appimage

Basically, since I don't have the hardware necessary to reproduce this
consistently, I want to know whether or not the above AppImage solves some of
the problems you have currently with rendering animations on your machine. If
it does, it might help direct me toward a solution to this problem.

I think it's also very likely that 438760 is related to this bug, so maybe also
test to see if that bug is resolved by this change too. 

Thanks,
Eoin.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 438754] Animation & Frame rendering clones limit: render in failure

2021-06-17 Thread Emmet O'Neill
https://bugs.kde.org/show_bug.cgi?id=438754

Emmet O'Neill  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||emmetoneill@gmail.com
 Status|REPORTED|CONFIRMED
   Keywords||release_blocker

--- Comment #1 from Emmet O'Neill  ---
My poor little 6-core Ryzen 1600 isn't able to adequately triage this bug, but
I'm going to confirm this based on the testing and discussion in the KA thread
that you linked to.

Labeling as release blocker.

Thanks again Grumm.

-- 
You are receiving this mail because:
You are watching all bug changes.