[krita] [Bug 442397] Regression: Dockers with utility titlebar no longer have reasonable size policy.

2021-09-21 Thread Eoin O'Neill
https://bugs.kde.org/show_bug.cgi?id=442397

--- Comment #7 from Eoin O'Neill  ---
That's unfortunate to hear, but understandable.

We could perhaps consider removing the onion skin docker on android (or what we
could call 'embedded systems') in favor of a toggle-able widget that serves the
same purpose that can be hidden/shown using the onion skin button.

Lastly, if it's really the width, I could try to look into making the animation
dockers slightly more flexible in future versions for the limited width of
android screens. What type of resolution / dpi scaling seems common with
android devices? 

Anyway, I think we should open up bug 441761 again and continue discussion
there. Worst case scenario, we could always try to resolve the problem upstream
with QT.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 442397] Regression: Dockers with utility titlebar no longer have reasonable size policy.

2021-09-21 Thread sh_zam
https://bugs.kde.org/show_bug.cgi?id=442397

--- Comment #6 from sh_zam  ---
I have reverted the patch. Sadly, there isn't a way to workaround this which
doesn't involve ugly hard coding. I tried to make the Onion Skins docker
`floating`, if there isn't enough space. But since we don't have a way of
knowing if the neighboring docker will shrink or not, we cannot make this work
for all cases.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 442397] Regression: Dockers with utility titlebar no longer have reasonable size policy.

2021-09-21 Thread sh_zam
https://bugs.kde.org/show_bug.cgi?id=442397

sh_zam  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/3388a06fe
   ||cd6d8e4084cb62c7cb274da5b52
   ||da15
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from sh_zam  ---
Git commit 3388a06fecd6d8e4084cb62c7cb274da5b52da15 by Sharaf Zaman.
Committed on 21/09/2021 at 12:16.
Pushed by szaman into branch 'master'.

Revert "Bugfix: Dockers cannot be attached when mainwindow is small"

This reverts commit a6d750785207aacc5bbe493c9351e6ab50b66339.
Related: bug 441761

M  +0-5libs/ui/widgets/kis_utility_title_bar.cpp
M  +1-2libs/ui/widgets/kis_utility_title_bar.h

https://invent.kde.org/graphics/krita/commit/3388a06fecd6d8e4084cb62c7cb274da5b52da15

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 442397] Regression: Dockers with utility titlebar no longer have reasonable size policy.

2021-09-20 Thread Eoin O'Neill
https://bugs.kde.org/show_bug.cgi?id=442397

--- Comment #4 from Eoin O'Neill  ---
Hey sh_zam,

We would really prefer to do something that doesn't negatively affect the
desktop experience. If a work-around needs to happen, we should consider doing
it using platform specific defines.

My main concern is ensuring that the animation dockers are consistent with
other dockers in the desktop version and don't visually break.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 442397] Regression: Dockers with utility titlebar no longer have reasonable size policy.

2021-09-17 Thread sh_zam
https://bugs.kde.org/show_bug.cgi?id=442397

--- Comment #3 from sh_zam  ---
Hello!

Yes, it does make everything look ugly and unusable. But because the bug exists
in the Qt's dock widget, there isn't a proper solution which won't involve
patching QDockWidget.

The two workarounds, I could come up with (after reverting the said commit):

1. We place the titlebar in a QScrollArea and then if the widget is resized,
user can scroll.

2. We prevent the Onion Skins docker from displaying docked, if we find the
space for it is too little to be shown. This will also fix the problem (besides
locking the docking mechanism) where it awkwardly cuts part of the
timeline/curves docker (Screenshot of the problem:
https://i.imgur.com/OntLvdl.png).

What do you think would be more suitable? I personally think 2 seems better.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 442397] Regression: Dockers with utility titlebar no longer have reasonable size policy.

2021-09-13 Thread Eoin O'Neill
https://bugs.kde.org/show_bug.cgi?id=442397

--- Comment #2 from Eoin O'Neill  ---
Created attachment 141535
  --> https://bugs.kde.org/attachment.cgi?id=141535=edit
Screenshot of problem

Here's a screen-capture of the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 442397] Regression: Dockers with utility titlebar no longer have reasonable size policy.

2021-09-13 Thread Eoin O'Neill
https://bugs.kde.org/show_bug.cgi?id=442397

Eoin O'Neill  changed:

   What|Removed |Added

 CC||eoinoneill1...@gmail.com
   Keywords||release_blocker

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 442397] Regression: Dockers with utility titlebar no longer have reasonable size policy.

2021-09-13 Thread Eoin O'Neill
https://bugs.kde.org/show_bug.cgi?id=442397

Eoin O'Neill  changed:

   What|Removed |Added

   Assignee|eoinoneill1...@gmail.com|sh...@sdf.org
 Ever confirmed|0   |1
   Keywords||regression
 Status|REPORTED|CONFIRMED

--- Comment #1 from Eoin O'Neill  ---
Regression caused by commit a6d750785207aacc5bbe493c9351e6ab50b66339 :

I've attached a picture of what it looks like. We do need the dockers to
respect a minimum size so that the toolbars don't get squashed together. 

While bug 441761 was fixed with the original commit, there must be another way
to resolve this issue without allowing the user to resize the docker to
unusable sizes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 442397] Regression: Dockers with utility titlebar no longer have reasonable size policy.

2021-09-13 Thread Emmet O'Neill
https://bugs.kde.org/show_bug.cgi?id=442397

Emmet O'Neill  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |eoinoneill1...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.