[krita] [Bug 446009] Resource: Masked Bush: Preset initially loads incorrect masked brush tip.
https://bugs.kde.org/show_bug.cgi?id=446009 Dmitry Kazakov changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #7 from Dmitry Kazakov --- Okay, I have checked the second part of the bug and it seems like all the newly created presets have correct 'md5sum' tag set, so everything is correct. We can close this bug. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446009] Resource: Masked Bush: Preset initially loads incorrect masked brush tip.
https://bugs.kde.org/show_bug.cgi?id=446009 --- Comment #6 from Dmitry Kazakov --- Git commit 0b260f71b614e700d6ae9108e31509f81b66fbf2 by Dmitry Kazakov. Committed on 25/11/2021 at 14:32. Pushed by dkazakov into branch 'master'. Fix deduplication of resources on import On importing resource we shouldn't just disable the copies. All the copies should be available in the database as active, until the user explicitly disables them. Though we should de-duplicate them based on their name-filename-md5 signature when listing them in the model. That can be easily done by simple adding "group by" to the query. Such solution both fixes legacy presets (bug 446009), and makes importing resources less embarrassing (bug 445367). Related: bug 445367 (cherry picked from commit aeed954b09cbdb68a6844d2d7b47626f8009c9e4) M +1-28 libs/resources/KisResourceCacheDb.cpp M +3-0libs/resources/KisResourceModel.cpp https://invent.kde.org/graphics/krita/commit/0b260f71b614e700d6ae9108e31509f81b66fbf2 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446009] Resource: Masked Bush: Preset initially loads incorrect masked brush tip.
https://bugs.kde.org/show_bug.cgi?id=446009 Bug 446009 depends on bug 445367, which changed state. Bug 445367 Summary: Adding a bundle with resource duplicated in disabled bundle disables the resource https://bugs.kde.org/show_bug.cgi?id=445367 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446009] Resource: Masked Bush: Preset initially loads incorrect masked brush tip.
https://bugs.kde.org/show_bug.cgi?id=446009 --- Comment #5 from Dmitry Kazakov --- Git commit aeed954b09cbdb68a6844d2d7b47626f8009c9e4 by Dmitry Kazakov. Committed on 25/11/2021 at 14:31. Pushed by dkazakov into branch 'krita/5.0'. Fix deduplication of resources on import On importing resource we shouldn't just disable the copies. All the copies should be available in the database as active, until the user explicitly disables them. Though we should de-duplicate them based on their name-filename-md5 signature when listing them in the model. That can be easily done by simple adding "group by" to the query. Such solution both fixes legacy presets (bug 446009), and makes importing resources less embarrassing (bug 445367). Related: bug 445367 M +1-28 libs/resources/KisResourceCacheDb.cpp M +3-0libs/resources/KisResourceModel.cpp https://invent.kde.org/graphics/krita/commit/aeed954b09cbdb68a6844d2d7b47626f8009c9e4 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446009] Resource: Masked Bush: Preset initially loads incorrect masked brush tip.
https://bugs.kde.org/show_bug.cgi?id=446009 --- Comment #4 from Dmitry Kazakov --- Just to make it clear, even though the mentioned merge request fixes the bug, there is still "part 2" to be checked/fixed. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446009] Resource: Masked Bush: Preset initially loads incorrect masked brush tip.
https://bugs.kde.org/show_bug.cgi?id=446009 --- Comment #3 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1175 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446009] Resource: Masked Bush: Preset initially loads incorrect masked brush tip.
https://bugs.kde.org/show_bug.cgi?id=446009
Dmitry Kazakov changed:
What|Removed |Added
Depends on||445367
CC||dimul...@gmail.com
--- Comment #2 from Dmitry Kazakov ---
Hi, Emmet!
This bug is tightly related to bug 445367
The problem is that "Krita 4" bundle contains two resources with are the same,
but have a different filename. I mean "plain_rake.png" and "chisel_soft.png".
When the bundle is imported, then one of them gets disabled ("plain_rake.png"),
so it cannot be found by the link defined with filename only. So the solution
to this bug should be two-fold:
1) Fix bug 445367 and make sure that the resources are not disabled on import,
unless explicitly requested by the user. I'm not sure how to do that
technically, because we still don't want to show the user fully-duplicated
resources (filename+name+md5) in the GUI
2) Find out why the brushes in the bundle didn't have md5 tag (I have a feeling
like this issue might have been fixed already)
Just to make it clear: fixing only the second part will help us only with the
presets created after the fix. Legacy presets (including Krita4-era) will still
be broken.
Referenced Bugs:
https://bugs.kde.org/show_bug.cgi?id=445367
[Bug 445367] Adding a bundle with resource duplicated in disabled bundle
disables the resource
--
You are receiving this mail because:
You are watching all bug changes.
[krita] [Bug 446009] Resource: Masked Bush: Preset initially loads incorrect masked brush tip.
https://bugs.kde.org/show_bug.cgi?id=446009 Emmet O'Neill changed: What|Removed |Added Summary|Resource: Brush Tips: |Resource: Masked Bush: |Preset initially loads |Preset initially loads |incorrect brush tip.|incorrect masked brush tip. --- Comment #1 from Emmet O'Neill --- Correction: It's not the regular brush tip, it's the brush tip associated with masked brushes. Brush Editor > Masked Brush section > Brush tip. -- You are receiving this mail because: You are watching all bug changes.
