[krita] [Bug 447862] Could not open a PDF file in Krita 5.0.0 in macOS

2022-01-04 Thread vanyossi
https://bugs.kde.org/show_bug.cgi?id=447862

vanyossi  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/2814f3f7a |hics/krita/commit/602e55754
   |555b8359230e157c306dbd53576 |200d02dcd463b0d666a7bebaf4e
   |dddc|c76b
 Resolution|--- |FIXED

--- Comment #8 from vanyossi  ---
Git commit 602e55754200d02dcd463b0d666a7bebaf4ec76b by Ivan Yossi, on behalf of
L. E. Segovia.
Committed on 05/01/2022 at 02:30.
Pushed by ivany into branch 'master'.

Fix patch for fontconfig triggering autoreconf

Both .am and compiled files need to be updated. Let's also make sure
their modification times don't change, either.

M  +40   -11   3rdparty/ext_fontconfig/0001-Fix-FC_DEFAULT_FONTS-on-macOS.patch

https://invent.kde.org/graphics/krita/commit/602e55754200d02dcd463b0d666a7bebaf4ec76b

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447862] Could not open a PDF file in Krita 5.0.0 in macOS

2022-01-04 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=447862

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

--- Comment #7 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/graphics/krita/-/merge_requests/1278

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447862] Could not open a PDF file in Krita 5.0.0 in macOS

2022-01-04 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=447862

amyspark  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #6 from amyspark  ---
The commit didn't fix the build because its modifications need to be
precompiled with autoreconf (as they are applied to a tarball, not the git
repo).

For future reference, we need to document how to handle autotools-based
patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447862] Could not open a PDF file in Krita 5.0.0 in macOS

2022-01-04 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=447862

amyspark  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/2814f3f7a
   ||555b8359230e157c306dbd53576
   ||dddc

--- Comment #5 from amyspark  ---
Git commit 2814f3f7a555b8359230e157c306dbd53576dddc by L. E. Segovia.
Committed on 04/01/2022 at 02:13.
Pushed by rempt into branch 'master'.

Fix macOS fontconfig build

Modifications to autotools-based builds MUST use the `-Z` parameter to
patch, otherwise they will trigger autoreconf.

And, for the sake of acknowledgment,  let's use the patch from GitLab
as well.

R  +20   -23rdparty/ext_fontconfig/0001-Fix-FC_DEFAULT_FONTS-on-macOS.patch
[from: 3rdparty/ext_fontconfig/macOS_sedErrorFix.diff - 060% similarity]
M  +1-13rdparty/ext_fontconfig/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/2814f3f7a555b8359230e157c306dbd53576dddc

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447862] Could not open a PDF file in Krita 5.0.0 in macOS

2022-01-03 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=447862

--- Comment #4 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/graphics/krita/-/merge_requests/1272

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447862] Could not open a PDF file in Krita 5.0.0 in macOS

2022-01-03 Thread vanyossi
https://bugs.kde.org/show_bug.cgi?id=447862

--- Comment #3 from vanyossi  ---
fontconfig seems to need autotools

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447862] Could not open a PDF file in Krita 5.0.0 in macOS

2022-01-03 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=447862

amyspark  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |a...@amyspark.me
URL||https://invent.kde.org/grap
   ||hics/krita/-/commit/d523e7d
   ||e2c6ed9a89bab0d96d6a3b928c6
   ||80b314
   Keywords||regression
 Status|CONFIRMED   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447862] Could not open a PDF file in Krita 5.0.0 in macOS

2022-01-03 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=447862

amyspark  changed:

   What|Removed |Added

 CC||a...@amyspark.me,
   ||ghe...@gmail.com
 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #2 from amyspark  ---
Not a Krita bug, rather CI; our dependencies build for macOS is *still* broken
because of a failed fontconfig build:
https://binary-factory.kde.org/job/Krita_Nightly_MacOS_Dependency_Build/119/consoleText

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447862] Could not open a PDF file in Krita 5.0.0 in macOS

2022-01-03 Thread Ahab Greybeard
https://bugs.kde.org/show_bug.cgi?id=447862

Ahab Greybeard  changed:

   What|Removed |Added

 CC||ahab.greybe...@hotmail.co.u
   ||k

--- Comment #1 from Ahab Greybeard  ---
Created attachment 145080
  --> https://bugs.kde.org/attachment.cgi?id=145080=edit
four page .pdf test file

I can't test macOS but for Linux and Windows 10 I see the following:-

Linux:

4.4.8 takes 5 seconds to open the 'Archoil' .pdf file.
On Closing, there is no warning or offer to Save, etc.

5.0.0 takes about 40 seconds to open the document.
On Closing, there is no warning or offer to Save.

Windows 10:
4.4.8 takes 5 seconds to open it.
On Closing, it gives a warning and an offer to Save, etc.

5.0.0 takes 40 seconds to open it.
On Closing, it does not give any warning etc.

-- 
You are receiving this mail because:
You are watching all bug changes.