[krita] [Bug 453948] GMIC：Exceptions caused by translucent selection
https://bugs.kde.org/show_bug.cgi?id=453948 amyspark changed: What|Removed |Added Resolution|--- |NOT A BUG Status|ASSIGNED|RESOLVED --- Comment #12 from amyspark --- Halla has determined opaque selections are intended to composite their value with the incoming modifications, not outright replacement of the pixels. Closing as NOT A BUG. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 453948] GMIC：Exceptions caused by translucent selection
https://bugs.kde.org/show_bug.cgi?id=453948 amyspark changed: What|Removed |Added Status|REOPENED|ASSIGNED Assignee|a...@amyspark.me |ha...@valdyas.org --- Comment #11 from amyspark --- Reassigning to Halla as she'd be the best to assess if this should be expected behaviour or not. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 453948] GMIC：Exceptions caused by translucent selection
https://bugs.kde.org/show_bug.cgi?id=453948 --- Comment #10 from amyspark --- Git commit a8a35883a4466dda80cd381570a47973b176b3f8 by L. E. Segovia. Committed on 20/06/2022 at 00:49. Pushed by lsegovia into branch 'krita/5.1'. G'MIC: fix composition of full pixel selections (cherry picked from commit 389448dd3976b8628dcc424e3da07801a3e5e241) M +1-0plugins/extensions/qmic/kis_qmic_import_tools.cpp https://invent.kde.org/graphics/krita/commit/a8a35883a4466dda80cd381570a47973b176b3f8 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 453948] GMIC：Exceptions caused by translucent selection
https://bugs.kde.org/show_bug.cgi?id=453948 --- Comment #9 from amyspark --- Git commit 389448dd3976b8628dcc424e3da07801a3e5e241 by L. E. Segovia. Committed on 20/06/2022 at 00:47. Pushed by lsegovia into branch 'master'. G'MIC: fix composition of full pixel selections M +1-0plugins/extensions/qmic/kis_qmic_import_tools.cpp https://invent.kde.org/graphics/krita/commit/389448dd3976b8628dcc424e3da07801a3e5e241 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 453948] GMIC：Exceptions caused by translucent selection
https://bugs.kde.org/show_bug.cgi?id=453948 --- Comment #8 from amyspark --- This bug affects only compositing with selections that have been created via Select Opaque. Not sure what's going on with KisPainter... -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 453948] GMIC：Exceptions caused by translucent selection
https://bugs.kde.org/show_bug.cgi?id=453948 amyspark changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #7 from amyspark --- Reopening due to private report. The KisPainter approach works well for compositing, but doesn't account for the need to *replacing* the pixels altogether. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 453948] GMIC：Exceptions caused by translucent selection
https://bugs.kde.org/show_bug.cgi?id=453948 amyspark changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/6f7b289ad ||73bfca8874c05d1c92d1da338c9 ||409b --- Comment #6 from amyspark --- Git commit 6f7b289ad73bfca8874c05d1c92d1da338c9409b by L. E. Segovia. Committed on 02/06/2022 at 16:19. Pushed by lsegovia into branch 'master'. G'MIC: fix masking of selections M +0-2plugins/extensions/qmic/kis_qmic_import_tools.h https://invent.kde.org/graphics/krita/commit/6f7b289ad73bfca8874c05d1c92d1da338c9409b -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 453948] GMIC：Exceptions caused by translucent selection
https://bugs.kde.org/show_bug.cgi?id=453948 Bug Janitor Service changed: What|Removed |Added Status|REOPENED|ASSIGNED --- Comment #5 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1464 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 453948] GMIC：Exceptions caused by translucent selection
https://bugs.kde.org/show_bug.cgi?id=453948 Dmitry Kazakov changed: What|Removed |Added CC||dimul...@gmail.com --- Comment #4 from Dmitry Kazakov --- Hi, amyspark! Usually we use selections in the following way: 1) Copy selected pixels out of the source device into an empty device using COMPOSITE_OVER (or COMPOSITE_COPY) and a selection. 2) Erase the selection on the source device (with clearSelection()). 3) Transform the pixels on the separate device 4) Copy transformed pixels back into the source device using COMPOSITE_OVER (or COMPOSITE_COPY) blendmode As far as I can tell, KisImageInterface::gmic_qt_get_cropped_images() skips point 2), therefore there are leftovers left on the device. PS: Theoretically, we could use the blending method of the layer styles. It works better in some cases and avoids generation of halos. Though I'm not totally sure it'll work correctly in this particular case, when the cut piece can be transformed. The layer style's blending method is implemented in `KisLayerStyleProjectionPlane::apply`. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 453948] GMIC：Exceptions caused by translucent selection
https://bugs.kde.org/show_bug.cgi?id=453948 thetwo changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- --- Comment #3 from thetwo --- I reopened it because the video described something different from what I said. The focus is not "translucent lines" but "translucent selection". You can also reproduce it through another process: 1. Draw a translucent line 2.select opaque（replace） 3.use GMIC There's another demo in the video (maybe you didn't see it, so I'll send it again)： https://ufile.io/gbf6rnq1 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 453948] GMIC：Exceptions caused by translucent selection
https://bugs.kde.org/show_bug.cgi?id=453948 amyspark changed: What|Removed |Added Resolution|--- |WORKSFORME Status|ASSIGNED|RESOLVED -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 453948] GMIC：Exceptions caused by translucent selection
https://bugs.kde.org/show_bug.cgi?id=453948 --- Comment #2 from amyspark --- Created attachment 149038 --> https://bugs.kde.org/attachment.cgi?id=149038=edit Demo G'MIC filter works, commit 110498d -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 453948] GMIC：Exceptions caused by translucent selection
https://bugs.kde.org/show_bug.cgi?id=453948 amyspark changed: What|Removed |Added CC||a...@amyspark.me Assignee|krita-bugs-n...@kde.org |a...@amyspark.me Status|REPORTED|ASSIGNED Ever confirmed|0 |1 --- Comment #1 from amyspark --- Going to check this with the rest of the bugs. -- You are receiving this mail because: You are watching all bug changes.
