[krita] [Bug 459906] Crash when dragging across patterns in Fill Layer menu

2022-10-23 Thread sh_zam
https://bugs.kde.org/show_bug.cgi?id=459906

sh_zam  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/e93ace6bb |hics/krita/commit/0aeed4342
   |bbf546e0782a6c705e9057a87ff |ddd76141e6255bf3b27a5ec76f6
   |b01f|ba76

--- Comment #4 from sh_zam  ---
Git commit 0aeed4342ddd76141e6255bf3b27a5ec76f6ba76 by Sharaf Zaman.
Committed on 24/10/2022 at 04:51.
Pushed by szaman into branch 'krita/5.1'.

Fix nullptr dereference in pattern generator

If while dragging we click outside of the window bounds, none of the
pattern is selected resulting in:
widget()->patternChooser->currentResource() pointing to a nullptr. But
with includeHidden flag enabled we can still reference the last selected
pattern. So, this seems like a minor error (i.e operating on only "non
hidden" resource).
(cherry picked from commit e93ace6f546e0782a6c705e9057a87ffb01f)

M  +1-1plugins/generators/pattern/kis_wdg_pattern.cpp

https://invent.kde.org/graphics/krita/commit/0aeed4342ddd76141e6255bf3b27a5ec76f6ba76

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 459906] Crash when dragging across patterns in Fill Layer menu

2022-10-12 Thread sh_zam
https://bugs.kde.org/show_bug.cgi?id=459906

sh_zam  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/commit/e93ace6bb
   ||bbf546e0782a6c705e9057a87ff
   ||b01f
 Status|ASSIGNED|RESOLVED

--- Comment #3 from sh_zam  ---
Git commit e93ace6f546e0782a6c705e9057a87ffb01f by Sharaf Zaman.
Committed on 12/10/2022 at 09:19.
Pushed by szaman into branch 'master'.

Fix nullptr dereference in pattern generator

If while dragging we click outside of the window bounds, none of the
pattern is selected resulting in:
widget()->patternChooser->currentResource() pointing to a nullptr. But
with includeHidden flag enabled we can still reference the last selected
pattern. So, this seems like a minor error (i.e operating on only "non
hidden" resource).

M  +1-1plugins/generators/pattern/kis_wdg_pattern.cpp

https://invent.kde.org/graphics/krita/commit/e93ace6f546e0782a6c705e9057a87ffb01f

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 459906] Crash when dragging across patterns in Fill Layer menu

2022-10-12 Thread sh_zam
https://bugs.kde.org/show_bug.cgi?id=459906

sh_zam  changed:

   What|Removed |Added

 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1
 CC||sh...@sdf.org

--- Comment #2 from sh_zam  ---
Confirming, let's see.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 459906] Crash when dragging across patterns in Fill Layer menu

2022-10-01 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=459906

tomtomtomreportin...@gmail.com changed:

   What|Removed |Added

   Keywords||regression

--- Comment #1 from tomtomtomreportin...@gmail.com ---
As this only starts occuring in 5.1.0, marking as a regression.

-- 
You are receiving this mail because:
You are watching all bug changes.