[krita] [Bug 464257] Layer effects not saved if they're the only thing changed.

2023-04-17 Thread Tiar
https://bugs.kde.org/show_bug.cgi?id=464257

--- Comment #7 from Tiar  ---
Master bug of the uuid issue (all issues where the layer style of the
duplicated layer is the same as the layer style of the original layer) is bug
457553.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464257] Layer effects not saved if they're the only thing changed.

2023-03-18 Thread Tiar
https://bugs.kde.org/show_bug.cgi?id=464257

Tiar  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Tiar  ---
Setting it to fixed, then :) Thanks for testing!

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464257] Layer effects not saved if they're the only thing changed.

2023-03-17 Thread Ralek Kolemios
https://bugs.kde.org/show_bug.cgi?id=464257

Ralek Kolemios  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |CONFIRMED

--- Comment #5 from Ralek Kolemios  ---
(In reply to Tiar from comment #3)
> @Ralek could you please check Krita Next and see if this issue is resolved?

I've tested the latest nightly and I can't seem to get it to save layer styles
incorrectly, looks good to me!

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464257] Layer effects not saved if they're the only thing changed.

2023-03-17 Thread Tiar
https://bugs.kde.org/show_bug.cgi?id=464257

Tiar  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |tamtamy.tym...@gmail.com

--- Comment #4 from Tiar  ---
Related commits:
a84179a80bc8e74505455d0589d07b4cf4283b47 - Don't forget 'align with layer' in
gradient layer style 
e8631c562c511d6b33ea05b93e3f7ddca852 - Fix color in Bevel and Emboss being
forgotten
27aed51669b54356b132d7b6fa18bba90bd94d35 - Fix Bevel and Emboss - Texture Depth
not being read from asl 
9c847ba5c8ec912bf3c4d318ed5c654a89400418 - Fix layerstyle creation so they are
kept after reload

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464257] Layer effects not saved if they're the only thing changed.

2023-03-17 Thread Tiar
https://bugs.kde.org/show_bug.cgi?id=464257

Tiar  changed:

   What|Removed |Added

 CC||tamtamy.tym...@gmail.com
 Resolution|--- |WAITINGFORINFO
 Status|CONFIRMED   |NEEDSINFO

--- Comment #3 from Tiar  ---
@Ralek could you please check Krita Next and see if this issue is resolved?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464257] Layer effects not saved if they're the only thing changed.

2023-03-06 Thread Halla Rempt
https://bugs.kde.org/show_bug.cgi?id=464257

Halla Rempt  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||ha...@valdyas.org
 Status|REPORTED|CONFIRMED

--- Comment #2 from Halla Rempt  ---
Okay, let's set to confirmed. Ideally, we'd get Dmitry to look into this, too,
after he's done with his move.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 464257] Layer effects not saved if they're the only thing changed.

2023-01-29 Thread Emile
https://bugs.kde.org/show_bug.cgi?id=464257

Emile  changed:

   What|Removed |Added

 CC||jeannin.em...@gmail.com

--- Comment #1 from Emile  ---
I searched a bit about that problem, and it seems that only one layerstyle
created from the layerstyle dialog can be loaded. It worked fine when I tried
copying the layer style and then updated it.
Some other unclear tickets could also be linked, such as 452056, 451385,
457553, but I wasn't able to confirm it yet.

Speaking about the real reason, it seems that when using the layerstyle dialog,
the same uuid is used for all the layerstyles. I tried adding creating a new
UUID after the copy of the old style and it seems to work.

To put some code here, I changed KisLayerManager::layerStyle, to have 
> KisPSDLayerStyleSP newStyle = 
> oldStyle->clone().dynamicCast();
> // We want to also change the UUID, else it might be considered the same 
> style after save and won't load correctly
> newStyle->setUuid(QUuid::createUuid());

I'll try to fix that but it's my first time so I can't guarantee anything

-- 
You are receiving this mail because:
You are watching all bug changes.