[krita] [Bug 465148] Krita can not open PSD files with blurred vector masks
https://bugs.kde.org/show_bug.cgi?id=465148 amyspark changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/-/commit/48f04b5 |hics/krita/commit/48f04b57c |7c926fd464f80f4823e7d956e53 |926fd464f80f4823e7d956e5330 |303e2e |3e2e --- Comment #6 from amyspark --- Git commit 48f04b57c926fd464f80f4823e7d956e53303e2e by L. E. Segovia. Committed on 22/04/2023 at 15:23. Pushed by lsegovia into branch 'krita/5.1'. psd: fix interpretation of layer mask/adjustment layer data lengths The standard says: > Size of the data: Check the size and flags to determine what is or is not > present. If zero, the following fields are not present Up to 18 bytes can be read safely in this way. After the 2 bytes for padding (if size == 20), the rest of the data is conditional on each flag allowing the data, and the block length allowing the read. (cherry picked from commit 291a841ec2bf72459b2c17b9106c7eafc766037c) M +118 -26 libs/psd/psd_layer_record.cpp https://invent.kde.org/graphics/krita/commit/48f04b57c926fd464f80f4823e7d956e53303e2e -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 465148] Krita can not open PSD files with blurred vector masks
https://bugs.kde.org/show_bug.cgi?id=465148 amyspark changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/48f04b57c |hics/krita/commit/291a841ec |926fd464f80f4823e7d956e5330 |2bf72459b2c17b9106c7eafc766 |3e2e|037c --- Comment #8 from amyspark --- Git commit 291a841ec2bf72459b2c17b9106c7eafc766037c by L. E. Segovia. Committed on 22/04/2023 at 15:23. Pushed by lsegovia into branch 'master'. psd: fix interpretation of layer mask/adjustment layer data lengths The standard says: > Size of the data: Check the size and flags to determine what is or is not > present. If zero, the following fields are not present Up to 18 bytes can be read safely in this way. After the 2 bytes for padding (if size == 20), the rest of the data is conditional on each flag allowing the data, and the block length allowing the read. M +118 -26 libs/psd/psd_layer_record.cpp https://invent.kde.org/graphics/krita/commit/291a841ec2bf72459b2c17b9106c7eafc766037c -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 465148] Krita can not open PSD files with blurred vector masks
https://bugs.kde.org/show_bug.cgi?id=465148 --- Comment #7 from amyspark --- Git commit 48f04b57c926fd464f80f4823e7d956e53303e2e by L. E. Segovia. Committed on 22/04/2023 at 15:23. Pushed by lsegovia into branch 'krita/5.1'. psd: fix interpretation of layer mask/adjustment layer data lengths The standard says: > Size of the data: Check the size and flags to determine what is or is not > present. If zero, the following fields are not present Up to 18 bytes can be read safely in this way. After the 2 bytes for padding (if size == 20), the rest of the data is conditional on each flag allowing the data, and the block length allowing the read. (cherry picked from commit 291a841ec2bf72459b2c17b9106c7eafc766037c) M +118 -26 libs/psd/psd_layer_record.cpp https://invent.kde.org/graphics/krita/commit/48f04b57c926fd464f80f4823e7d956e53303e2e -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 465148] Krita can not open PSD files with blurred vector masks
https://bugs.kde.org/show_bug.cgi?id=465148 amyspark changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/grap ||hics/krita/-/commit/48f04b5 ||7c926fd464f80f4823e7d956e53 ||303e2e --- Comment #5 from amyspark --- Fixed in tomorrow's nightlies. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 465148] Krita can not open PSD files with blurred vector masks
https://bugs.kde.org/show_bug.cgi?id=465148 amyspark changed: What|Removed |Added URL||https://invent.kde.org/grap ||hics/krita/commit/291a841ec ||2bf72459b2c17b9106c7eafc766 ||037c --- Comment #4 from amyspark --- (In reply to Ivan Kuckir from comment #3) > Look into the Adobes docs: > https://www.adobe.com/devnet-apps/photoshop/fileformatashtml/#50577409_22582 Already did, it's a very subtle interpretation of "Layer mask / adjustment layer data" that needs to be changed. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 465148] Krita can not open PSD files with blurred vector masks
https://bugs.kde.org/show_bug.cgi?id=465148 --- Comment #3 from Ivan Kuckir --- Look into the Adobes docs: https://www.adobe.com/devnet-apps/photoshop/fileformatashtml/#50577409_22582 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 465148] Krita can not open PSD files with blurred vector masks
https://bugs.kde.org/show_bug.cgi?id=465148 --- Comment #2 from amyspark --- These one have a layer mask record size of 28, so I need to understand first where the changes are, and the GIMP source code isn't easy to read so far. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 465148] Krita can not open PSD files with blurred vector masks
https://bugs.kde.org/show_bug.cgi?id=465148 amyspark changed: What|Removed |Added CC||a...@amyspark.me Component|* Unknown |File formats Assignee|krita-bugs-n...@kde.org |a...@amyspark.me Ever confirmed|0 |1 Status|REPORTED|ASSIGNED --- Comment #1 from amyspark --- Ack. Assigning. -- You are receiving this mail because: You are watching all bug changes.
