[krita] [Bug 468494] Krita crashes when pasting a screenshot

2023-12-13 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=468494

amyspark  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/commit/f4f069cbe |hics/krita/commit/d833fcb31
   |a3dd961aed23e3abbc67460821b |161fbaedd738381613960daf9ac
   |2da9|5fb7

--- Comment #15 from amyspark  ---
Git commit d833fcb31161fbaedd738381613960daf9ac5fb7 by L. E. Segovia.
Committed on 21/04/2023 at 00:40.
Pushed by lsegovia into branch 'krita/5.1'.

KisClipboard: remove assert on clipboard being cleared

6399b0203e7c7e8fa6fc40e4fdbe4a72cae2f304 already covers it enough, so
it's safe to bail out now.
Related: bug 462006, bug 465128
(cherry picked from commit f4f069cbea3dd961aed23e3abbc67460821b2da9)

M  +5-1libs/ui/kis_clipboard.cc

https://invent.kde.org/graphics/krita/commit/d833fcb31161fbaedd738381613960daf9ac5fb7

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 468494] Krita crashes when pasting a screenshot

2023-12-13 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=468494

amyspark  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/d833fcb |hics/krita/commit/f4f069cbe
   |31161fbaedd738381613960daf9 |a3dd961aed23e3abbc67460821b
   |ac5fb7  |2da9

--- Comment #13 from amyspark  ---
Git commit f4f069cbea3dd961aed23e3abbc67460821b2da9 by L. E. Segovia.
Committed on 21/04/2023 at 00:40.
Pushed by lsegovia into branch 'master'.

KisClipboard: remove assert on clipboard being cleared

6399b0203e7c7e8fa6fc40e4fdbe4a72cae2f304 already covers it enough, so
it's safe to bail out now.
Related: bug 462006, bug 465128

M  +5-1libs/ui/kis_clipboard.cc

https://invent.kde.org/graphics/krita/commit/f4f069cbea3dd961aed23e3abbc67460821b2da9

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 468494] Krita crashes when pasting a screenshot

2023-04-21 Thread jimbo
https://bugs.kde.org/show_bug.cgi?id=468494

--- Comment #12 from jimbo  ---
you guys are great! Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 468494] Krita crashes when pasting a screenshot

2023-04-20 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=468494

amyspark  changed:

   What|Removed |Added

URL||https://invent.kde.org/grap
   ||hics/krita/-/commit/f4f069c
   ||bea3dd961aed23e3abbc6746082
   ||1b2da9
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/d833fcb
   ||31161fbaedd738381613960daf9
   ||ac5fb7
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #11 from amyspark  ---
This should be fixed with tonight's nightly builds. Please visit
https://krita.org/en/download/krita-desktop/ to get a copy.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 468494] Krita crashes when pasting a screenshot

2023-04-19 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=468494

amyspark  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|ASSIGNED
   Assignee|krita-bugs-n...@kde.org |a...@amyspark.me

--- Comment #10 from amyspark  ---
I'll see what we can do, then. It'll take me a couple days because I need to
sort out my developer environment.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 468494] Krita crashes when pasting a screenshot

2023-04-19 Thread jimbo
https://bugs.kde.org/show_bug.cgi?id=468494

--- Comment #9 from jimbo  ---
Oh, I forgot to mention that I'm still on 20.04, so that's probably the reason
why. I can't upgrade neon as it causes issues on my machine, I'm putting off
doing a fresh install until later this year.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 468494] Krita crashes when pasting a screenshot

2023-04-19 Thread jimbo
https://bugs.kde.org/show_bug.cgi?id=468494

--- Comment #8 from jimbo  ---
So, I tried getting the flatpak stacktrace but it returns an error when I try
to install the sdk. "No remote refs found similar to
‘org.freedesktop.Sdk/x86_64/22.08’". Any idea what I'm doing wrong there? I
used the AppImage and it also crashes when pasting the screenshot.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 468494] Krita crashes when pasting a screenshot

2023-04-16 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=468494

Bug Janitor Service  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |REPORTED

--- Comment #7 from Bug Janitor Service  ---
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 468494] Krita crashes when pasting a screenshot

2023-04-16 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=468494

--- Comment #6 from amyspark  ---
(In reply to jimbo from comment #5)
> Regardless, Krita shouldn't just crash if there is 'nothing' pasted into it.
> There definitely should be some way to handle it, at least the user should
> be prompted about an error and given the option to save.

Qt provides no atomic way to check-and-load an image from the clipboard: either
we deserialize the QImage and then check if it's null (paying the cost of the
underlying codec upfront, every time there is a clipboard change), or we check
the clipboard for hasImage, then we retrieve it on document creation.

The latter is what's happening here. Between the hasImage check and the point
of retrieval, something in your side is clearing up the clipboard. The
assertion validates that there's an image in the clipboard when the document is
created, so once that fails, we crash because it's an inconsistent state.

> How do I go about doing that? I have Krita installed via a Flatpak in 
> Discover.

I believe https://www.figuiere.net/technotes/notes/tn001/ can help;
alternatively, since it's easy in your case to reproduce, could you try the
5.1.5 AppImage and repeating the steps you performed?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 468494] Krita crashes when pasting a screenshot

2023-04-16 Thread jimbo
https://bugs.kde.org/show_bug.cgi?id=468494

--- Comment #5 from jimbo  ---
How do I go about doing that? I have Krita installed via a Flatpak in Discover.
I'm fairly certain that your explanation is correct. I'm using an older version
of Spectacle (22.08.01) that may be the issue. 

Regardless, Krita shouldn't just crash if there is 'nothing' pasted into it.
There definitely should be some way to handle it, at least the user should be
prompted about an error and given the option to save.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 468494] Krita crashes when pasting a screenshot

2023-04-14 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=468494

amyspark  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #4 from amyspark  ---
(waiting for reply)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 468494] Krita crashes when pasting a screenshot

2023-04-14 Thread amyspark
https://bugs.kde.org/show_bug.cgi?id=468494

amyspark  changed:

   What|Removed |Added

 CC||a...@amyspark.me

--- Comment #3 from amyspark  ---
Hi!

The crash is caused because you (or an app) is clearing the clipboard between
initiating the document creation and retrieving the image.

Can you send us a stacktrace of the crash so I can confirm the issue?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 468494] Krita crashes when pasting a screenshot

2023-04-14 Thread jimbo
https://bugs.kde.org/show_bug.cgi?id=468494

--- Comment #2 from jimbo  ---
I've done a bit of testing on my end. 

I have Spectacle set as my screenshot manager, and I have 'Capture Entire
Desktop' bound to 'PrintScreen'. I've always had issues with Spectacle not
sending the screenshot to the clipboard properly (sometimes it sends nothing
and needs more than one hit of the hotkey to capture the screen). 

The problem seems to go away if I launch Spectacle and then use the hotkey.
Either way there seems to be an issue when 'nothing' gets pasted into Krita and
it crashes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 468494] Krita crashes when pasting a screenshot

2023-04-14 Thread jimbo
https://bugs.kde.org/show_bug.cgi?id=468494

--- Comment #1 from jimbo  ---
The crash is fairly consistent on my machine, it crashes after taking the
second screenshot.

-- 
You are receiving this mail because:
You are watching all bug changes.