[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=363136

Bug Janitor Service  changed:

   What|Removed |Added

   Priority|NOR |VHI

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Gabriele]

https://bugs.kde.org/show_bug.cgi?id=363136

Gabriele  changed:

   What|Removed |Added

 CC|gabb...@virgilio.it |

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Alexander Lohnau]

https://bugs.kde.org/show_bug.cgi?id=363136

Alexander Lohnau  changed:

   What|Removed |Added

 CC||alexander.loh...@gmx.de
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=363136

Christoph Feck  changed:

   What|Removed |Added

 CC||trindade.r...@gmail.com

--- Comment #104 from Christoph Feck  ---
*** Bug 405316 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||sten.hei...@gmx.de

--- Comment #103 from Kai Uwe Broulik  ---
*** Bug 397115 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

David Edmundson  changed:

   What|Removed |Added

 CC||pa...@benso1968.com

--- Comment #102 from David Edmundson  ---
*** Bug 396838 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||pawel6...@gmail.com

--- Comment #101 from Kai Uwe Broulik  ---
*** Bug 396786 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||gabb...@virgilio.it

--- Comment #100 from Kai Uwe Broulik  ---
*** Bug 396752 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363136

bugs_kde_org.2.woi...@spamgourmet.com changed:

   What|Removed |Added

 CC|bugs_kde_org.2.woidda@spamg |
   |ourmet.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363136

--- Comment #99 from sbo...@blueyonder.co.uk ---
Appears fixed in openSUSE Tumbleweed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

--- Comment #98 from David Edmundson  ---
Clearly not fixed (nor hindered) by my extra mutex.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

--- Comment #97 from David Edmundson  ---
*** Bug 396718 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

David Edmundson  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|UNCONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

David Edmundson  changed:

   What|Removed |Added

 CC||fyl...@hotmail.com
 CC||selth.blackwi...@gmail.com

--- Comment #95 from David Edmundson  ---
*** Bug 396466 has been marked as a duplicate of this bug. ***

--- Comment #96 from David Edmundson  ---
*** Bug 396156 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

David Edmundson  changed:

   What|Removed |Added

 CC||fyl...@hotmail.com

--- Comment #95 from David Edmundson  ---
*** Bug 396466 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363136

lud...@loebinger.de changed:

   What|Removed |Added

 CC|lud...@loebinger.de |

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||bugs_kde_org.2.woidda@spamg
   ||ourmet.com

--- Comment #94 from Kai Uwe Broulik  ---
*** Bug 396400 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||c...@wizofe.uk

--- Comment #93 from Kai Uwe Broulik  ---
*** Bug 395992 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=363136

Christoph Feck  changed:

   What|Removed |Added

 CC||aals...@gmail.com

--- Comment #92 from Christoph Feck  ---
*** Bug 395307 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Philipp Wagner]

https://bugs.kde.org/show_bug.cgi?id=363136

Philipp Wagner  changed:

   What|Removed |Added

 CC|m...@philipp-wagner.com |

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

--- Comment #91 from Kai Uwe Broulik  ---
*** Bug 395799 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

David Edmundson  changed:

   What|Removed |Added

 CC||ali...@she-devel.com

--- Comment #90 from David Edmundson  ---
*** Bug 395827 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

David Edmundson  changed:

   What|Removed |Added

 CC||christopher.horwood@gmail.c
   ||om

--- Comment #89 from David Edmundson  ---
*** Bug 395799 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

David Edmundson  changed:

   What|Removed |Added

 CC||carlos.e.valencia.u@gmail.c
   ||om

--- Comment #88 from David Edmundson  ---
*** Bug 395325 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=363136

Christoph Feck  changed:

   What|Removed |Added

 CC||aatman.d.btech...@ahduni.ed
   ||u.in

--- Comment #87 from Christoph Feck  ---
*** Bug 393605 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363136

jan.ap...@gmail.com changed:

   What|Removed |Added

 CC|jan.ap...@gmail.com |

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

--- Comment #86 from Kai Uwe Broulik  ---
*** Bug 394785 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||davidlev...@yahoo.com

--- Comment #85 from Kai Uwe Broulik  ---
*** Bug 393927 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||bugzilla-...@ddt-consult.ne
   ||t

--- Comment #84 from Kai Uwe Broulik  ---
*** Bug 395026 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||oliver.pa...@mailbox.org

--- Comment #83 from Kai Uwe Broulik  ---
*** Bug 394783 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Jameson Ernst]

https://bugs.kde.org/show_bug.cgi?id=363136

Jameson Ernst  changed:

   What|Removed |Added

 CC|jame...@jpernst.com |

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

David Edmundson  changed:

   What|Removed |Added

 CC||4m4pocmx12oskpziwsvg@mailin
   ||ator.com

--- Comment #82 from David Edmundson  ---
*** Bug 394380 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

--- Comment #81 from Kai Uwe Broulik  ---
*** Bug 394353 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

David Edmundson  changed:

   What|Removed |Added

 CC||johnvie...@gmail.com

--- Comment #80 from David Edmundson  ---
*** Bug 394301 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

David Edmundson  changed:

   What|Removed |Added

 CC||zheltonozhs...@gmail.com

--- Comment #79 from David Edmundson  ---
*** Bug 393626 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

David Edmundson  changed:

   What|Removed |Added

 CC||tinysa...@gmail.com

--- Comment #78 from David Edmundson  ---
*** Bug 393941 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363136

i...@bartvdijk.com changed:

   What|Removed |Added

 CC|i...@bartvdijk.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||zak.le.gra...@gmail.com

--- Comment #77 from Kai Uwe Broulik  ---
*** Bug 393986 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Luca Weiss]

https://bugs.kde.org/show_bug.cgi?id=363136

--- Comment #76 from Luca Weiss  ---
@David Edmundson: Since applying that patch I didn't experience any crashes
anymore, so it seems to work. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

--- Comment #75 from David Edmundson  ---
Git commit 947b03d674e8f962f1a2d832524d3a8fdeda8ae1 by David Edmundson.
Committed on 04/05/2018 at 12:05.
Pushed by davidedmundson into branch 'master'.

Guard BookmarksRunner thread use

Summary:
Krunner::match is performed in potentially multiple overlapping threads
as a user presses each character. Qt SQL is not thread safe according to
the docs or according to the numerous reports.

It's a bit of a blind patch, ideally we should only use the database in
the thread that opened it.

This patch at least this means queries will be queued which I think will
be enough.

Test Plan: Restarted krunner. Still saw my firefox bookmarks

Reviewers: #plasma, mart

Reviewed By: #plasma, mart

Subscribers: rempt, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D12683

M  +5-0runners/bookmarks/fetchsqlite.cpp
M  +2-0runners/bookmarks/fetchsqlite.h

https://commits.kde.org/plasma-workspace/947b03d674e8f962f1a2d832524d3a8fdeda8ae1

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

--- Comment #74 from Kai Uwe Broulik  ---
*** Bug 393297 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=363136

Elvis Angelaccio  changed:

   What|Removed |Added

 CC|elvis.angelac...@kde.org|

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

--- Comment #73 from David Edmundson  ---
Can anyone who experience this a lot please test:
https://phabricator.kde.org/D12683

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

David Edmundson  changed:

   What|Removed |Added

 CC||jan.ap...@gmail.com
 CC||fgou...@codeweavers.com

--- Comment #71 from David Edmundson  ---
*** Bug 393582 has been marked as a duplicate of this bug. ***

--- Comment #72 from David Edmundson  ---
*** Bug 393419 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

David Edmundson  changed:

   What|Removed |Added

 CC||jan.ap...@gmail.com

--- Comment #71 from David Edmundson  ---
*** Bug 393582 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||paolo.gre...@tiscali.it

--- Comment #70 from Kai Uwe Broulik  ---
*** Bug 393575 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||luis...@gmail.com

--- Comment #69 from Kai Uwe Broulik  ---
*** Bug 393504 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||frozen@web.de

--- Comment #68 from Kai Uwe Broulik  ---
*** Bug 393446 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||123gop...@mail.ru

--- Comment #67 from Kai Uwe Broulik  ---
*** Bug 393285 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||supp...@intrepid.co.za

--- Comment #66 from Kai Uwe Broulik  ---
*** Bug 393278 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||a...@polverini.org

--- Comment #65 from Kai Uwe Broulik  ---
*** Bug 368343 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||b...@valdyas.org

--- Comment #64 from Kai Uwe Broulik  ---
*** Bug 391037 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||bsmith7...@live.com

--- Comment #63 from Kai Uwe Broulik  ---
*** Bug 391602 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

Antonio Rojas  changed:

   What|Removed |Added

 CC|aro...@archlinux.org|

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||pups.poppo+...@gmail.com

--- Comment #62 from Kai Uwe Broulik  ---
*** Bug 390920 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Trevin Fitz]

https://bugs.kde.org/show_bug.cgi?id=363136

Trevin Fitz  changed:

   What|Removed |Added

 CC|qneverl...@gmail.com|

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||vojtech.zei...@opensuse.org

--- Comment #61 from Kai Uwe Broulik  ---
*** Bug 392293 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

David Edmundson  changed:

   What|Removed |Added

 CC||joelishn...@gmail.com

--- Comment #60 from David Edmundson  ---
*** Bug 391977 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=363136

--- Comment #59 from Christoph Feck  ---
Bug 391037 might be related.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Luca Weiss]

https://bugs.kde.org/show_bug.cgi?id=363136

--- Comment #58 from Luca Weiss  ---
@Antonio: Yes, the stacktrace in bug 391740 is in a different location that
what I have fixed in my commit included in 5.12.2. I'll take a look at it and
try to reproduce it on my machine.
But ultimately, the crashes are caused by Qt unfortunately.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

Antonio Rojas  changed:

   What|Removed |Added

 CC||aro...@archlinux.org

--- Comment #57 from Antonio Rojas  ---
The latest duplicates of this are in 5.12.3, should this be reopened?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||sbo...@blueyonder.co.uk

--- Comment #56 from Kai Uwe Broulik  ---
*** Bug 391740 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

David Edmundson  changed:

   What|Removed |Added

 CC||alextal...@yandex.ru

--- Comment #55 from David Edmundson  ---
*** Bug 391689 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||gis...@gmail.com

--- Comment #54 from Kai Uwe Broulik  ---
*** Bug 391599 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

Antonio Rojas  changed:

   What|Removed |Added

 CC|aro...@archlinux.org|

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=363136

Christoph Feck  changed:

   What|Removed |Added

 CC||johanna_mueller...@yahoo.de

--- Comment #53 from Christoph Feck  ---
*** Bug 390675 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=363136

--- Comment #52 from Christoph Feck  ---
Because a recent Qt 5.10 regression was incorrectly marked as a duplicate of
this crash. See also comment #8. Let's hope the originally reported issue is
fixed as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Martin]

https://bugs.kde.org/show_bug.cgi?id=363136

--- Comment #51 from Martin  ---
I was wondering why this bug did not turn up in the search for similar bugs for
me (and, potentially, others as well since it has so many duplicates). Do you
have an idea why that is?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||martin.ruess...@mailbox.org

--- Comment #50 from Kai Uwe Broulik  ---
*** Bug 390854 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||i...@zachlge.org

--- Comment #49 from Kai Uwe Broulik  ---
*** Bug 390843 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

Antonio Rojas  changed:

   What|Removed |Added

 CC||tchamber...@gmail.com

--- Comment #48 from Antonio Rojas  ---
*** Bug 390833 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

Antonio Rojas  changed:

   What|Removed |Added

 CC||idw.wis...@gmail.com

--- Comment #47 from Antonio Rojas  ---
*** Bug 390813 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

Antonio Rojas  changed:

   What|Removed |Added

 CC||lud...@loebinger.de

--- Comment #46 from Antonio Rojas  ---
*** Bug 390808 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

Antonio Rojas  changed:

   What|Removed |Added

 CC||mustafa10...@gmail.com

--- Comment #45 from Antonio Rojas  ---
*** Bug 390778 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

David Edmundson  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/pla
   ||sma-workspace/93f0f5ee2c275
   ||c3328f37675b644c1ce35f75e70
 Status|UNCONFIRMED |RESOLVED

--- Comment #44 from David Edmundson  ---
Git commit 93f0f5ee2c275c3328f37675b644c1ce35f75e70 by David Edmundson, on
behalf of Luca Weiss.
Committed on 20/02/2018 at 12:18.
Pushed by davidedmundson into branch 'Plasma/5.12'.

Fix favicons in firefox bookmarks runner

Summary:
The favicons are located in the file favicons.sqlite file since FF 37 and the
old table was removed in FF 41 resulting in crashes because the table wasn't
found.

* Update SQL to match the tables in FF 58
* query.bindValue() needs a double colon in the string, see
https://doc.qt.io/qt-5/qsqlquery.html#prepare
* Fix intendation (tab->spaces) in one line

Test Plan:
Firefox bookmark favicons now work and don't crash Krunner and Kickoff
{F5715653}

{F5715654}

Reviewers: #plasma, broulik, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: ngraham, elvisangelaccio, davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D10610

M  +14   -2runners/bookmarks/browsers/firefox.cpp
M  +3-0runners/bookmarks/browsers/firefox.h
M  +6-5runners/bookmarks/faviconfromblob.cpp

https://commits.kde.org/plasma-workspace/93f0f5ee2c275c3328f37675b644c1ce35f75e70

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363136

stanisl...@null.net changed:

   What|Removed |Added

 CC|stanisl...@null.net |

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

Antonio Rojas  changed:

   What|Removed |Added

 CC||kdebugs.spam@schaefer-isl.d
   ||e

--- Comment #43 from Antonio Rojas  ---
*** Bug 390769 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

Antonio Rojas  changed:

   What|Removed |Added

 CC||daed...@protonmail.com

--- Comment #42 from Antonio Rojas  ---
*** Bug 390770 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=363136

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||i...@bartvdijk.com

--- Comment #41 from Kai Uwe Broulik  ---
*** Bug 390764 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=363136

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

Antonio Rojas  changed:

   What|Removed |Added

 CC||stanisl...@null.net

--- Comment #40 from Antonio Rojas  ---
*** Bug 390751 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

Antonio Rojas  changed:

   What|Removed |Added

 CC||demonocaqu...@gmail.com

--- Comment #39 from Antonio Rojas  ---
*** Bug 390731 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

--- Comment #38 from Antonio Rojas  ---
*** Bug 390722 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

--- Comment #36 from Antonio Rojas  ---
*** Bug 390720 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

Antonio Rojas  changed:

   What|Removed |Added

 CC||nom...@outlook.com

--- Comment #37 from Antonio Rojas  ---
*** Bug 390721 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

Antonio Rojas  changed:

   What|Removed |Added

 CC||mani.za...@gmail.com

--- Comment #35 from Antonio Rojas  ---
*** Bug 390719 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=363136

aldo.mat...@gmail.com changed:

   What|Removed |Added

 CC||balthasar.b...@gmx.de

--- Comment #34 from aldo.mat...@gmail.com ---
*** Bug 390653 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

David Edmundson  changed:

   What|Removed |Added

 CC||frodo_...@gmx.de

--- Comment #33 from David Edmundson  ---
*** Bug 390673 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=363136

David Edmundson  changed:

   What|Removed |Added

 CC||quelque_...@yahoo.fr

--- Comment #32 from David Edmundson  ---
*** Bug 390694 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

Antonio Rojas  changed:

   What|Removed |Added

 CC||bessonn...@gmail.com

--- Comment #31 from Antonio Rojas  ---
*** Bug 390687 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

Antonio Rojas  changed:

   What|Removed |Added

 CC||devuran...@gmx.net

--- Comment #30 from Antonio Rojas  ---
*** Bug 390684 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=363136

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||elvis.angelac...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[chris]

https://bugs.kde.org/show_bug.cgi?id=363136

chris  changed:

   What|Removed |Added

 CC|kdebug_vo...@vllmr.eu   |

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

Antonio Rojas  changed:

   What|Removed |Added

 CC||elliot.far...@gmail.com

--- Comment #29 from Antonio Rojas  ---
*** Bug 390661 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

Antonio Rojas  changed:

   What|Removed |Added

 CC||magicru...@gmail.com

--- Comment #28 from Antonio Rojas  ---
*** Bug 390655 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

Antonio Rojas  changed:

   What|Removed |Added

 CC||jame...@jpernst.com

--- Comment #27 from Antonio Rojas  ---
*** Bug 390635 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Matteo Beniamino]

https://bugs.kde.org/show_bug.cgi?id=363136

Matteo Beniamino  changed:

   What|Removed |Added

 CC||beniam...@tautologica.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Luca Weiss]

https://bugs.kde.org/show_bug.cgi?id=363136

--- Comment #26 from Luca Weiss  ---
I have submitted a patch that fixes the bookmark favicons
https://phabricator.kde.org/D10610

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Luca Weiss]

https://bugs.kde.org/show_bug.cgi?id=363136

--- Comment #25 from Luca Weiss  ---
(I copied this comment from 390609 except that the backtrace also contains Qt
debug symbols and thanks Antonio for pointing me to the correct bug - I
searched but couldn't find this one)

I have debugged this issue a bit and found, that the
runners/bookmarks/faviconfromblob.cpp file in plasma-workspace tries to access
the table moz_favicons in the sqlite database (line 80) which doesn't exist
though.
Checking the firefox source code, I found mentions that since Firefox 37 the
table was not used anymore and since Firefox 41 the table was dropped. I have
no idea why this wasn't an issue before but it might be because of a newer Qt
version that broke something?


$ sqlite3 .cache/krunnerbookmarkrunnerfirefoxdbfile.sqlite  
SQLite version 3.22.0 2018-01-22 18:45:57
Enter ".help" for usage hints.
sqlite> .tables
moz_anno_attributesmoz_historyvisits  moz_keywords 
moz_annos  moz_hosts  moz_places   
moz_bookmarks  moz_inputhistory 
moz_bookmarks_deleted  moz_items_annos


(gdb) bt
#0  0x741c5ad0 in QVariant::QVariant(QVariant const&)
(this=0x7fffb6b567e0, p=...) at kernel/qvariant.cpp:1527
#1  0x7fffb7b672bc in QVector::append(QVariant const&)
(this=this@entry=0x7fffb6b56890, t=...)
at
/tmp/qt5-base/trunk/src/qtbase-everywhere-src-5.10.1/include/QtCore/../../src/corelib/tools/qvector.h:653
#2  0x7fffb7b64ad6 in QVector::operator<<(QVariant const&)
(t=..., this=0x7fffb6b56890)
at
/tmp/qt5-base/trunk/src/qtbase-everywhere-src-5.10.1/include/QtCore/../../src/corelib/tools/qvector.h:281
#3  0x7fffb7b64ad6 in QSQLiteResult::exec() (this=0x7fffac0087d0) at
qsql_sqlite.cpp:491
#4  0x7fffed155db8 in QSqlQuery::exec() (this=this@entry=0x7fffb6b569d0) at
kernel/qsqlquery.cpp:1002
#5  0x7fffb7d7b064 in FetchSqlite::query(QString const&, QMap) (this=this@entry=0x57ab5560, sql=..., bindObjects=...)
at
/tmp/plasma-workspace/trunk/src/plasma-workspace-5.12.1/runners/bookmarks/fetchsqlite.cpp:80
#6  0x7fffb7d7b56a in FetchSqlite::query(BuildQuery*, QMap) (this=this@entry=0x57ab5560, buildQuery=0x57a7e0b0,
bindObjects=...)
at
/tmp/plasma-workspace/trunk/src/plasma-workspace-5.12.1/runners/bookmarks/fetchsqlite.cpp:67
#7  0x7fffb7d76c12 in FaviconFromBlob::iconFor(QString const&)
(this=0x57af5c80, url=...) at
/tmp/plasma-workspace/trunk/src/plasma-workspace-5.12.1/runners/bookmarks/faviconfromblob.cpp:133
#8  0x7fffb7d74455 in BookmarkMatch::asQueryMatch(Plasma::AbstractRunner*)
(this=this@entry=0x7fffb6b56c70, runner=runner@entry=0x578e80a0)
at
/tmp/plasma-workspace/trunk/src/plasma-workspace-5.12.1/runners/bookmarks/bookmarkmatch.cpp:63
#9  0x7fffb7d7e8e4 in BookmarksRunner::match(Plasma::RunnerContext&)
(this=0x578e80a0, context=...) at
/tmp/plasma-workspace/trunk/src/plasma-workspace-5.12.1/runners/bookmarks/bookmarksrunner.cpp:85
#10 0x7fffd0e877f0 in
Plasma::AbstractRunner::performMatch(Plasma::RunnerContext&)
(this=0x578e80a0, localContext=...) at
/tmp/krunner/trunk/src/krunner-5.43.0/src/abstractrunner.cpp:130
#11 0x7fffd0c66618 in
ThreadWeaver::Executor::run(QSharedPointer const&,
ThreadWeaver::Thread*) () at /usr/lib/libKF5ThreadWeaver.so.5
#12 0x7fffd0c65610 in
ThreadWeaver::Job::execute(QSharedPointer const&,
ThreadWeaver::Thread*) () at /usr/lib/libKF5ThreadWeaver.so.5
#13 0x7fffd0c64d45 in ThreadWeaver::Thread::run() () at
/usr/lib/libKF5ThreadWeaver.so.5
#14 0x73f92bbd in QThreadPrivate::start(void*) (arg=0x7fffb0004980) at
thread/qthread_unix.cpp:376
#15 0x717ea08c in start_thread () at /usr/lib/libpthread.so.0
#16 0x73898e7f in clone () at /usr/lib/libc.so.6

-- 
You are receiving this mail because:
You are watching all bug changes.

[krunner] [Bug 363136] Bookmarks runner crashes in QSqlite

[Antonio Rojas]

https://bugs.kde.org/show_bug.cgi?id=363136

Antonio Rojas  changed:

   What|Removed |Added

 CC||l...@z3ntu.xyz

--- Comment #23 from Antonio Rojas  ---
*** Bug 390609 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.