[krusader] [Bug 386554] Non-standard icons not shown in many icon themes

[Nikita Melnichenko]

https://bugs.kde.org/show_bug.cgi?id=386554

--- Comment #5 from Nikita Melnichenko  ---
Git commit 94ea5b69af14620abd4a44a13240ca9b2749641b by Nikita Melnichenko.
Committed on 22/04/2018 at 22:00.
Pushed by melnichenko into branch 'master'.

Refactored and unified icon rendering, implemented per-icon fallback logic

Merge branch 'fix-missing-icons'

The merged branch contains implementation of per-icon fallback logic:
1. Search icon in the active icon theme — if found, use it.
2. Search it in the icon theme that is specified in Krusader config — if found,
use it.
3. Search it in Breeze or Oxygen (in case any of these installed) — if found,
use it.
4. Otherwise use a default "icon-missing" icon bundled with Krusader.

FIXED: [ 372964 ] At least one Oxygen icon in Krusader is not correctly seen
(using Kubuntu 16.04)
Related: bug 372964, bug 372966, bug 376699, bug 381676, bug 388691, bug 391899

FIXED: [ 372966 ] Some icons are not seen using a plain Ubuntu (not Kubuntu)
16.04

Differential Revision: https://phabricator.kde.org/D10352

M  +11   -10   krusader/kractions.cpp
M  +2-8krusader/krusader.cpp

https://commits.kde.org/krusader/94ea5b69af14620abd4a44a13240ca9b2749641b

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 386554] Non-standard icons not shown in many icon themes

[Heiko Tietze]

https://bugs.kde.org/show_bug.cgi?id=386554

--- Comment #4 from Heiko Tietze  ---
(In reply to Alex Bikadorov from comment #3)
> [For further discussion please use Bug 372966 so we don't repeat everything
> again and again.]

While I disagree with your decision I have to accept it. 

Options to hide the standard and the bookbar/folder toolbars would be another
solution. Only disadvantage in that case is the missing progress bar, which I
actually would prefer to have back in an extra dialog. 

X-mas is knocking on the door... :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 386554] Non-standard icons not shown in many icon themes

[Alex Bikadorov]

https://bugs.kde.org/show_bug.cgi?id=386554

Alex Bikadorov  changed:

   What|Removed |Added

 CC||alex.bikado...@kdemail.net
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Alex Bikadorov  ---

This was already discussed several times (that's why I added the explanation to
the bug FAQs on the website) and I don't see anything new here. Krusader uses
icons which are only included in Breeze mainly because the icon standard (*) is
very limited. Most KDE applications have the same issue and the real solution
would be to add the same icon names to other themes e.g. Adwaita. But this has
nothing really to do with Krusader.

@Andreas
Krusader uses QIcon::fromTheme() and that's the correct way. (Also, the
deprecated KIcon class. But it is only a wrapper around QIcon.)
This is still a problem of not having the icons in Adwaita. E.g. the icon for
BookMan II is named "bookmarks" which is a different icon in Breeze than
"user-bookmarks" included in the icon standard. Because we want "bookmarks"
here and not "user-bookmarks" and QIcon::fromTheme() does not fallback to it I
don't see what we can do here.

(*)
https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html

[For further discussion please use Bug 372966 so we don't repeat everything
again and again.]

*** This bug has been marked as a duplicate of bug 372966 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 386554] Non-standard icons not shown in many icon themes

[andreas_k]

https://bugs.kde.org/show_bug.cgi?id=386554

andreas_k  changed:

   What|Removed |Added

 CC||andrea...@abwesend.de

--- Comment #2 from andreas_k  ---
thanks for open the bug report. From the screenshot it look like Heiko select
adwaita (which has really not that much icons available) and when there is no
adwaita icon available, krusader use the icon's that will be shipped in there
source code (oxygen).

it would be really a pleasure if krusader can use more standard icons. e.g. the
folder icons are available in ALL (also adwaita) icon theme, same for bookmark,
...

I think krusader didn't use the qicon function (I think it's the reight
function) everywhere. If someone can give me feedback how I have to search
after the used icons I can start fixing the issues. Ordinary I know which icons
are available in most icon themes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 386554] Non-standard icons not shown in many icon themes

[Heiko Tietze]

https://bugs.kde.org/show_bug.cgi?id=386554

Heiko Tietze  changed:

   What|Removed |Added

 CC||kain...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 386554] Non-standard icons not shown in many icon themes

[Paul]

https://bugs.kde.org/show_bug.cgi?id=386554

Paul  changed:

   What|Removed |Added

 CC||pip@gmx.com

--- Comment #1 from Paul  ---
It would seem we are *expected* to only use the breeze icon set, rather
unfortunate for those who choose otherwise.

Quote from: https://krusader.org/report-bugs/index.html

"Krusader uses icons which are only contained in KDE's default icon set Breeze.
Make sure you have it installed and that it is used by KDE applications.
Unfortunately you cannot use a different icon set because it will most likely
not contain all icons needed in contrast to the very large set in Breeze."

-- 
You are receiving this mail because:
You are watching all bug changes.