[krusader] [Bug 390991] bookmark buttons on a toolbar disappear after closing Bookmark Editor

2018-04-24 Thread Nikita Melnichenko
https://bugs.kde.org/show_bug.cgi?id=390991

Nikita Melnichenko  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/kru
   ||sader/d7bb3a596a51bbd62049b
   ||4e0dd7d78dc634bb2f9
 Resolution|--- |FIXED

--- Comment #3 from Nikita Melnichenko  ---
Git commit d7bb3a596a51bbd62049b4e0dd7d78dc634bb2f9 by Nikita Melnichenko.
Committed on 25/04/2018 at 03:39.
Pushed by melnichenko into branch 'master'.

BookMan: Fixed various issues related to bookmark reloading from file

Changed importFromFile function which is called after Bookmark Manager
sends the signal that bookmarks are modified and should be reloaded.
Now we don't delete bookmarks unless they are fake bookmarks (folders or
separators). By keeping the original actions and updating them on reload
we keep bindings with different systems like toolbars and shortcuts.

FIXED: [ 390991 ] bookmark buttons on a toolbar disappear after closing
Bookmark Editor
Related: bug 267719

FIXED: [ 267719 ] bookmarks shortcuts lost after opening bookmark manager

Differential Revision: https://phabricator.kde.org/D12369

M  +14   -13   krusader/BookMan/krbookmark.cpp
M  +6-1krusader/BookMan/krbookmark.h
M  +19   -15   krusader/BookMan/krbookmarkhandler.cpp
M  +1-1krusader/BookMan/krbookmarkhandler.h

https://commits.kde.org/krusader/d7bb3a596a51bbd62049b4e0dd7d78dc634bb2f9

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 390991] bookmark buttons on a toolbar disappear after closing Bookmark Editor

2018-03-15 Thread Nikita Melnichenko
https://bugs.kde.org/show_bug.cgi?id=390991

Nikita Melnichenko  changed:

   What|Removed |Added

   Assignee|m...@fork.pl  |nikita+...@melnichenko.name

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 390991] bookmark buttons on a toolbar disappear after closing Bookmark Editor

2018-02-25 Thread Nikita Melnichenko
https://bugs.kde.org/show_bug.cgi?id=390991

--- Comment #2 from Nikita Melnichenko  ---
Thanks for confirming and for the hint. I'll try to look into this soon. BTW,
bug #267719 seems to be related to the problem - likely it's the same root
cause.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krusader] [Bug 390991] bookmark buttons on a toolbar disappear after closing Bookmark Editor

2018-02-25 Thread Davide Gianforte
https://bugs.kde.org/show_bug.cgi?id=390991

Davide Gianforte  changed:

   What|Removed |Added

 CC||dav...@gengisdave.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #1 from Davide Gianforte  ---
Confirmed; as a hint, the issue starts from KrBookmarkHandler::bookmarksChanged

-- 
You are receiving this mail because:
You are watching all bug changes.