[kscreenlocker] [Bug 449857] Lockscreen window sometimes does not get focus by default on X11

2022-03-17 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=449857

--- Comment #52 from maciej.p.pawlow...@gmail.com ---
I can confirm that commenting out "enabled: visible" from
/usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/lockscreen/LockScreenUi.qml
solves the issue for me.

I'm running:
Operating System: Kubuntu 20.04
KDE Plasma Version: 5.18.8
KDE Frameworks Version: 5.68.0
Qt Version: 5.12.8
Kernel Version: 5.4.0-104-generic
OS Type: 64-bit
Processors: 8 × Intel® Core™ i7-8565U CPU @ 1.80GHz
Memory: 15,3 GiB of RAM

-- 
You are receiving this mail because:
You are watching all bug changes.

[kscreenlocker] [Bug 449857] Lockscreen window sometimes does not get focus by default on X11

2022-03-17 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=449857

--- Comment #51 from Fabian Vogt  ---
(In reply to Wedge009 from comment #50)
> I apologise if this was already discussed in these bug reports but the fix
> was applied to master with MR 561:
> https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/561
> 
> Commentary suggests some reason this could not be applied to 5.18 branch.

Yeah, that requires porting the textfield to QQC2 first, so it had to be
reverted in 5.18 (c4a3a4e5b974fb309a6da61252b2b830d2d90683).
That commit fixed 697b103f5fad5b40b207eabcbce162d6672f5d91, so that should've
been reverted as well as the fix couldn't be used.

However, all of this is specific to 5.18.7, while this bug report is initially
about 5.24.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kscreenlocker] [Bug 449857] Lockscreen window sometimes does not get focus by default on X11

2022-03-16 Thread Wedge009
https://bugs.kde.org/show_bug.cgi?id=449857

--- Comment #50 from Wedge009  ---
I apologise if this was already discussed in these bug reports but the fix was
applied to master with MR 561:
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/561

Commentary suggests some reason this could not be applied to 5.18 branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kscreenlocker] [Bug 449857] Lockscreen window sometimes does not get focus by default on X11

2022-03-16 Thread Wedge009
https://bugs.kde.org/show_bug.cgi?id=449857

--- Comment #49 from Wedge009  ---
It looks like only the 'enabled: visible' line is relevant here. I reinstated
'visible: opacity > 0' and I still get the desired historical behaviour of
keyboard inputs feeding straight into the password input field. The reason I
find this noteworthy is because this matches the current state of
LockScreenUi.qml in master:
https://invent.kde.org/plasma/plasma-workspace/-/blob/master/lookandfeel/contents/lockscreen/LockScreenUi.qml

The same is true for 5.24 branch:
https://invent.kde.org/plasma/plasma-workspace/-/blob/Plasma/5.24/lookandfeel/contents/lockscreen/LockScreenUi.qml
If developers aren't observing the broken behaviour, maybe this is why?

Plasma 5.18 branch still retains the 'enabled: visible' line:
https://invent.kde.org/plasma/plasma-workspace/-/blob/Plasma/5.18/lookandfeel/contents/lockscreen/LockScreenUi.qml#L234
I understand 5.18 is no longer being maintained.

BTW, I'm not sure what either of these lines in the QML do, I'm just reporting
my observations as a user.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kscreenlocker] [Bug 449857] Lockscreen window sometimes does not get focus by default on X11

2022-03-16 Thread Wedge009
https://bugs.kde.org/show_bug.cgi?id=449857

--- Comment #48 from Wedge009  ---
Interesting. I confirm that removing those lines also resolves the issue for
me, at least what is reported in bug #439604. I am also using Kubuntu 20.04, so
am using Plasma 5.18 not 5.24.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kscreenlocker] [Bug 449857] Lockscreen window sometimes does not get focus by default on X11

2022-03-16 Thread Nathan
https://bugs.kde.org/show_bug.cgi?id=449857

--- Comment #47 from Nathan  ---
Comparing the older files on my desktop with the newer ones on my laptop that
display the bug, I believe I have found the source of the problem. Between the
two, looking at the changes to /usr/share/plasma/look-and-feel/, the only
changes other than metadata.{desktop,json} localization changes were in
/usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/lockscreen/LockScreenUi.qml,
which added the lines below. Reverting to the old file from my desktop fixed
the bug  (i.e. removing the lines setting visible and enabled), and I can now
enter text on the lock screen without having to hit tab a few times and/or
moving the mouse.


---
/usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/lockscreen/LockScreenUi.qml-old
+++
/usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/lockscreen/LockScreenUi.qml-new
@@ -227,6 +227,12 @@
height: lockScreenRoot.height + units.gridUnit * 3
focus: true //StackView is an implicit focus scope, so we need
to give this focus so the item inside will have it

+// this isn't implicit, otherwise items still get processed
for the scenegraph
+visible: opacity > 0
+// changing enabled will toggle if an item can have
activeFocus, which otherwise
+//keeps the text cursor blinking even when invisble
+enabled: visible
+
initialItem: MainBlock {
id: mainBlock
lockScreenUiVisible: lockScreenRoot.uiVisible


My laptop (as it's not the most recent version of Plasma, so it could be
different now):
Linux/KDE Plasma: Kubuntu 20.04
KDE Plasma Version: 5.18.8
KDE Frameworks Version: 5.68.0
Qt Version: 5.12.8

-- 
You are receiving this mail because:
You are watching all bug changes.

[kscreenlocker] [Bug 449857] Lockscreen window sometimes does not get focus by default on X11

2022-02-23 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=449857

David Edmundson  changed:

   What|Removed |Added

  Flags|Wayland-, X11+  |
  Component|general |greeter
 CC||k...@davidedmundson.co.uk
Product|kwin|kscreenlocker

--- Comment #46 from David Edmundson  ---
Please do not move bugs to kwin unless kwin is at fault.

-- 
You are receiving this mail because:
You are watching all bug changes.