[ksmserver] [Bug 392725] Login sound is never played

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=392725

Nate Graham  changed:

   What|Removed |Added

 CC||cosm...@gmail.com

--- Comment #14 from Nate Graham  ---
*** Bug 380243 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 392725] Login sound is never played

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=392725

Wolfgang Bauer  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/pla
   ||sma-workspace/6082047651107
   ||24f420c978499411e46db1d086e
 Status|REOPENED|RESOLVED
   Version Fixed In||5.12.5
 Resolution|--- |FIXED

--- Comment #13 from Wolfgang Bauer  ---
Git commit 608204765110724f420c978499411e46db1d086e by Wolfgang Bauer.
Committed on 30/04/2018 at 11:42.
Pushed by wbauer into branch 'Plasma/5.12'.

[ksmserver] Use QUrl::fromUserInput to construct sound url

Since Phonon 4.9, this code fails to play a login sound if the sound
file is specified as absolute file path (without "file://"). The reason
is that QUrl() treats the parameter as Url (not as file path), and this
only accidentally worked with earlier Phonon versions but not any more.
This patch uses QUrl::fromUserInput() instead to create a QUrl from the
string in the settings file, which fixes the problem.

This is the same change as
https://phabricator.kde.org/R289:9db06adc8114163f401417064b07772139bc36bc
in knotifications.
A more detailed explanation of the problem can be found in
https://bugs.kde.org/show_bug.cgi?id=337276#c12 .
FIXED-IN: 5.12.5
Differential Revision: https://phabricator.kde.org/D12606

M  +15   -7ksmserver/startup.cpp

https://commits.kde.org/plasma-workspace/608204765110724f420c978499411e46db1d086e

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 392725] Login sound is never played

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=392725

--- Comment #12 from Wolfgang Bauer  ---
Actually this is the very same problem as bug#337276 in knotifications (from
where this code originally comes from), and caused by a change in Phonon 4.9.0.

It has been fixed there by this commit:
https://cgit.kde.org/knotifications.git/commit/src/notifybyaudio.cpp?id=9db06adc8114163f401417064b07772139bc36bc

The same change should fix it in ksmserver too.

https://phabricator.kde.org/D12606

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 392725] Login sound is never played

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=392725

--- Comment #11 from k...@trummer.xyz ---
Yes, I set a different file than the default one, the classic
'KDE_Startup_1.ogg' to be exact.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 392725] Login sound is never played

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=392725

--- Comment #10 from Wolfgang Bauer  ---
An additional note about the reproducibility:
The login sound is played fine if you leave the sound file at the default (i.e.
only enable it).
But it does not work if you select a different (local) file.

That likely explains why the other two people here were not able to reproduce
the problem I think... ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 392725] Login sound is never played

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=392725

--- Comment #9 from Wolfgang Bauer  ---
(In reply to Nate Graham from comment #8)
> Sounds like you know what you're doing, Wolfgang! Would you like to submit a
> patch to http://phabricator.kde.org/?

Sure, I intended to do that anyway.
I hope I can find the time in the next days.

And no, I don't need a hand, thanks.
I already contributed quite a few times... ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 392725] Login sound is never played

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=392725

--- Comment #8 from Nate Graham  ---
Sounds like you know what you're doing, Wolfgang! Would you like to submit a
patch to http://phabricator.kde.org/?

Here's the documentation: https://community.kde.org/Infrastructure/Phabricator

Let me know if you need a hand at all.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 392725] Login sound is never played

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=392725

Wolfgang Bauer  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Status|RESOLVED|REOPENED
 CC||wba...@tmo.at

--- Comment #7 from Wolfgang Bauer  ---
I don't think this is distribution specific.

IMHO, this code in ksmserver/startup.cpp seems to generate an invalid QUrl, if
the path in the settings doesn't contain a scheme (which it doesn't if you
select a local file in the settings module):
QUrl soundURL = QUrl(soundFilename); // this CTOR accepts both absolute
paths (/usr/share/sounds/blabla.ogg and blabla.ogg) w/o screwing the scheme
if (soundURL.isRelative() && !soundURL.toString().startsWith('/')) { //
QUrl considers url.scheme.isEmpty() == url.isRelative()
soundURL =
QUrl::fromLocalFile(QStandardPaths::locate(QStandardPaths::GenericDataLocation,
QStringLiteral("sounds/") + soundFilename));

(the QUrl constructor expects an absolute or relative *URL*, and doesn't
support local paths, it should probably use QUrl::fromUserInput() instead of
QUrl()...)

It works if you manually edit the config file (~/.config/plasma_notifyrc) and
prepend a "file://" to the file path.
I.e. something like:
[Event/startkde]
Action=Sound
Sound=file:///home/test/Desktop/login.ogg

For some reason it seems to work with Phonon's vlc backend without this, but
not with gstreamer.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 392725] Login sound is never played

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=392725

Nate Graham  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #6 from Nate Graham  ---
Works for me too in Kubuntu 17.04. Report this to openSUSE if you're still
having issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 392725] Login sound is never played

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=392725

--- Comment #5 from Dr. Chapatin  ---
No. I enabled the sounds manually.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 392725] Login sound is never played

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=392725

--- Comment #4 from Nate Graham  ---
Sounds like maybe this is distro-specific then? Does Neon turn on the sound by
default?

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 392725] Login sound is never played

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=392725

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

--- Comment #3 from Dr. Chapatin  ---
Cannot confirm on neon dev unstable. Login and logout sounds play as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 392725] Login sound is never played

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=392725

--- Comment #2 from David Edmundson  ---
@Nate, there's no login sound set by default

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 392725] Login sound is never played

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=392725

David Edmundson  changed:

   What|Removed |Added

Product|plasmashell |ksmserver
   Assignee|k...@privat.broulik.de   |l.lu...@kde.org
  Component|Notifications   |general
 CC||k...@davidedmundson.co.uk
   Target Milestone|1.0 |---

-- 
You are receiving this mail because:
You are watching all bug changes.