[ktorrent] [Bug 484598] KTorrent - Stuck after clicking [X] button
https://bugs.kde.org/show_bug.cgi?id=484598 Nicolas Fella changed: What|Removed |Added CC||kravanj...@protonmail.com --- Comment #4 from Nicolas Fella --- *** Bug 485102 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[ktorrent] [Bug 484598] KTorrent - Stuck after clicking [X] button
https://bugs.kde.org/show_bug.cgi?id=484598 Nicolas Fella changed: What|Removed |Added CC||linus.kard...@gmail.com --- Comment #3 from Nicolas Fella --- *** Bug 485013 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[ktorrent] [Bug 484598] KTorrent - Stuck after clicking [X] button
https://bugs.kde.org/show_bug.cgi?id=484598 Nicolas Fella changed: What|Removed |Added CC||nicolas.fe...@gmx.de Version Fixed In||24.02.2 -- You are receiving this mail because: You are watching all bug changes.
[ktorrent] [Bug 484598] KTorrent - Stuck after clicking [X] button
https://bugs.kde.org/show_bug.cgi?id=484598 Jack Hill changed: What|Removed |Added Latest Commit|https://invent.kde.org/netw |https://invent.kde.org/netw |ork/ktorrent/-/commit/5d216 |ork/ktorrent/-/commit/d6c45 |c0b8c9b71c74ae5af755b0a0082 |20e82fdc2c14ce0677c1c2a80cc |f54af83f|6e52e154 --- Comment #2 from Jack Hill --- Git commit d6c4520e82fdc2c14ce0677c1c2a80cc6e52e154 by Jack Hill. Committed on 02/04/2024 at 20:13. Pushed by jackh into branch 'release/24.02'. Undo system tray bug workaround In KF5 KStatusNotifierIcon would show/hide the main QWindow whilst in KTorrent we would show/hide the main QWidget. A bug in Qt6 meant that hiding/showing the QWindow did not neccessarily hide the QWidget. So if a user closed the window to the tray, the QWidget was considered hidden but the QWindow was not. Then when clicking on the tray icon, the QWindow visiblity was being toggled but the QWidget visibility was always hidden. To work around this we changed KTorrent to hide the QWindow instead of the QWidget. Now KStatusNotifierIcon has been updated to hide the main QWidget instead of the QWindow, so we must undo the changes made here. The upstream bug should fixed in Qt 6.7 anyway. Reverts e35b4881605f045ebe8bca2da357c2a3ae2f1e02 Reverts efe4aa0dcc23e57e68ecd809068f1a49d7705a07 (cherry picked from commit 5d216c0b8c9b71c74ae5af755b0a0082f54af83f) M +5-10 ktorrent/gui.cpp https://invent.kde.org/network/ktorrent/-/commit/d6c4520e82fdc2c14ce0677c1c2a80cc6e52e154 -- You are receiving this mail because: You are watching all bug changes.
[ktorrent] [Bug 484598] KTorrent - Stuck after clicking [X] button
https://bugs.kde.org/show_bug.cgi?id=484598 Jack Hill changed: What|Removed |Added Status|REPORTED|RESOLVED Latest Commit||https://invent.kde.org/netw ||ork/ktorrent/-/commit/5d216 ||c0b8c9b71c74ae5af755b0a0082 ||f54af83f Resolution|--- |FIXED --- Comment #1 from Jack Hill --- Git commit 5d216c0b8c9b71c74ae5af755b0a0082f54af83f by Jack Hill. Committed on 02/04/2024 at 16:01. Pushed by jackh into branch 'master'. Undo system tray bug workaround In KF5 KStatusNotifierIcon would show/hide the main QWindow whilst in KTorrent we would show/hide the main QWidget. A bug in Qt6 meant that hiding/showing the QWindow did not neccessarily hide the QWidget. So if a user closed the window to the tray, the QWidget was considered hidden but the QWindow was not. Then when clicking on the tray icon, the QWindow visiblity was being toggled but the QWidget visibility was always hidden. To work around this we changed KTorrent to hide the QWindow instead of the QWidget. Now KStatusNotifierIcon has been updated to hide the main QWidget instead of the QWindow, so we must undo the changes made here. The upstream bug should fixed in Qt 6.7 anyway. Reverts e35b4881605f045ebe8bca2da357c2a3ae2f1e02 Reverts efe4aa0dcc23e57e68ecd809068f1a49d7705a07 M +5-10 ktorrent/gui.cpp M +1-2ktorrent/main.cpp https://invent.kde.org/network/ktorrent/-/commit/5d216c0b8c9b71c74ae5af755b0a0082f54af83f -- You are receiving this mail because: You are watching all bug changes.
