[kup] [Bug 465491] Interval schedules: save backup asap after missed schedule time

2023-02-22 Thread Simon Persson
https://bugs.kde.org/show_bug.cgi?id=465491

Simon Persson  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/syst
   ||em/kup/commit/e09c9b1e9fcdc
   ||34d157c383694dee5e00cf091e3
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #6 from Simon Persson  ---
Git commit e09c9b1e9fcdc34d157c383694dee5e00cf091e3 by Simon Persson.
Committed on 22/02/2023 at 21:25.
Pushed by persson into branch 'master'.

Change sleep duration for interval plan executor

The problem was that time spent with computer in suspend mode was not
advancing the process timer. So backup saving every 24 h would happen 27
hours after last save if three hours was spent suspended.
Fix by checking if it's time to save every five minutes.

M  +4-2daemon/planexecutor.cpp

https://invent.kde.org/system/kup/commit/e09c9b1e9fcdc34d157c383694dee5e00cf091e3

-- 
You are receiving this mail because:
You are watching all bug changes.

[kup] [Bug 465491] Interval schedules: save backup asap after missed schedule time

2023-02-19 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=465491

--- Comment #5 from k...@nuru.de ---
Apologies, I still believe I fully haven't understood what is actually going
on. I put the interval back on 1 day, and unlike when I had the 5-min-setting,
it did not execute the backup when the 24 h were exceeded despite the PC being
powered on at the time (although it had been suspended in the interim). So
something still isn't quite right I guess?

That said, kup realizes that something is amiss - the icon turned yellow when
the 24 h were exceeded.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kup] [Bug 465491] Interval schedules: save backup asap after missed schedule time

2023-02-18 Thread Simon Persson
https://bugs.kde.org/show_bug.cgi?id=465491

Simon Persson  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1
Summary|Kup on daily interval   |Interval schedules: save
   |schedule - no backup after  |backup asap after missed
   |suspend |schedule time

--- Comment #4 from Simon Persson  ---
OK, excellent. Then it actually behaves as designed then. I agree that saving a
new backup as soon as possible after a missed schedule would be good to have,
and users would be right to expect it.
For anyone who has time and interest to help fix this problem: The current
scheduler goes to sleep with a duration which is the remaining time until next
"backup save time". The solution here could be to instead just sleep 5 minutes
and then upon wake up, check if it's time to save a new backup. If not, go back
to sleep for another five minutes.

-- 
You are receiving this mail because:
You are watching all bug changes.