[kwin] [Bug 342716] translucency effect causes zombie when closing a window (likely due to multiple and uncancelled "set" calls)

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=342716

Martin Gräßlin  changed:

   What|Removed |Added

   Version Fixed In||5.8.3
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/kwin
   ||/94c5704af74db5e0f8e86f0c57
   ||2e4e11453e7002
 Status|CONFIRMED   |RESOLVED

--- Comment #26 from Martin Gräßlin  ---
Git commit 94c5704af74db5e0f8e86f0c572e4e11453e7002 by Martin Gräßlin.
Committed on 28/10/2016 at 14:24.
Pushed by graesslin into branch 'Plasma/5.8'.

[effects/translucency] Cancel existing animations before starting new

Summary:
It can happen that startAnimation is invoked multiple times for a
window. In case it was invoked a second time the previous animation was
not cancelled. This resulted in the set-animation to never end. When
closing a window, it would stay around as a translucent, non-interactive
window zombie.

This change ensures that existing animations get cancelled.
FIXED-IN: 5.8.3

Test Plan: Tested through autotest and manually.

Reviewers: #kwin, #plasma

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D3190

M  +0-3autotests/integration/effects/translucency_test.cpp
M  +3-0effects/translucency/package/contents/code/main.js

http://commits.kde.org/kwin/94c5704af74db5e0f8e86f0c572e4e11453e7002

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 342716] translucency effect causes zombie when closing a window (likely due to multiple and uncancelled "set" calls)

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=342716

Martin Gräßlin  changed:

   What|Removed |Added

URL||https://phabricator.kde.org
   ||/D3190
  Flags||ReviewRequest+

--- Comment #25 from Martin Gräßlin  ---
Possible patch at https://phabricator.kde.org/D3190

For those who want to use it directly. The change is only in the javascript
file. You can modify the installed file on your system and perform the same
change. Restarting kwin afterwards should be sufficient to get the fix in.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 342716] translucency effect causes zombie when closing a window (likely due to multiple and uncancelled "set" calls)

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=342716

--- Comment #24 from Martin Gräßlin  ---
Git commit eb88762e0793b7f4f3facbaccb6a783370d6ee0e by Martin Gräßlin.
Committed on 28/10/2016 at 12:37.
Pushed by graesslin into branch 'Plasma/5.8'.

[autotests] Add test case for translucency effect of dialog window

This test case simulates a condition of the translucency effect
modifying windows of certain types (e.g. dialogs).

In case the effect got activated for a window it does not end after the
window gets closed and creates a non-interactive zombie window.

M  +74   -7autotests/integration/effects/translucency_test.cpp

http://commits.kde.org/kwin/eb88762e0793b7f4f3facbaccb6a783370d6ee0e

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 342716] translucency effect causes zombie when closing a window (likely due to multiple and uncancelled "set" calls)

[Martin Gräßlin]

https://bugs.kde.org/show_bug.cgi?id=342716

Martin Gräßlin  changed:

   What|Removed |Added

 CC||graham.all...@gmail.com

--- Comment #23 from Martin Gräßlin  ---
*** Bug 369340 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 342716] translucency effect causes zombie when closing a window (likely due to multiple and uncancelled "set" calls)

[Tomas Kopecny via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=342716

Tomas Kopecny  changed:

   What|Removed |Added

 CC||georg...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 342716] translucency effect causes zombie when closing a window (likely due to multiple and uncancelled "set" calls)

[Michael Butash via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=342716

--- Comment #22 from Michael Butash  ---
Created attachment 100362
  --> https://bugs.kde.org/attachment.cgi?id=100362=edit
qdbus kwin supportInformaton

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 342716] translucency effect causes zombie when closing a window (likely due to multiple and uncancelled "set" calls)

[Michael Butash via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=342716

Michael Butash  changed:

   What|Removed |Added

 CC||mich...@butash.net

--- Comment #21 from Michael Butash  ---
I began noticing this after upgrading to unstable neon this weekend from ubuntu
16.04 stock, where I'm getting ghost windows when removing them.  I am also
seeing translucency not restoring to non-translucent on active windows at
times.  Both cases, I usually hot-key restart compositing, and it behaves again
for a few hours.  I use this as well with dimming, going to try without dimming
to see if some combination of both.

Posting support info as well if it helps.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 342716] translucency effect causes zombie when closing a window (likely due to multiple and uncancelled "set" calls)

[Alassane via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=342716

Alassane  changed:

   What|Removed |Added

 CC||azou8...@gmail.com

--- Comment #20 from Alassane  ---
I have the same issue with both an intel card and and AMD card

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 342716] translucency effect causes zombie when closing a window (likely due to multiple and uncancelled "set" calls)

[Stuart K . Smith via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=342716

Stuart K. Smith  changed:

   What|Removed |Added

 CC||stuartksm...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 342716] translucency effect causes zombie when closing a window (likely due to multiple and uncancelled "set" calls)

[Bob Wya via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=342716

Bob Wya  changed:

   What|Removed |Added

 CC||bob.mt@gmail.com

--- Comment #19 from Bob Wya  ---
Created attachment 99616
  --> https://bugs.kde.org/attachment.cgi?id=99616=edit
KWin Support Information

I can reproduce this bug on both Arch with Plasma 5.6.5 and Gentoo with Plasma
5.6.95 (see Gentoo Kwin Support information attached).

Simply enabling translucency for Dialogue windows (only) is enough to trigger
the issue.
Undirect fullscreen windows - makes no difference.
Global Animation Speed changes - makes no difference.
Disabling and Enabling compositing removes the "ghost" windows. Otherwise the
"ghost" windows just hang around (on all desktops). They cannot be interacted
with and get overlaid by other Windows - as these are given focus.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 342716] translucency effect causes zombie when closing a window (likely due to multiple and uncancelled "set" calls)

[Thomas Lübking via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=342716

Thomas Lübking  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
Version|unspecified |git master
Summary|translucency effect causes  |translucency effect causes
   |zombie or missing repaint   |zombie when closing a
   |when closing a window   |window (likely due to
   ||multiple and uncancelled
   ||"set" calls)

--- Comment #18 from Thomas Lübking  ---
looking at the translucency animation effect, "startAnimation" resp.
"checkWindow" should most likely "cancel" all present animations, otherwise a
VD change will likely cause a multiinvocation what leaves the old "set" calls
dangeling (thus the window referecend)

-- 
You are receiving this mail because:
You are watching all bug changes.