[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=344433

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk
 Resolution|--- |UNMAINTAINED
 Status|REOPENED|RESOLVED

--- Comment #39 from David Edmundson  ---
Performance issues this old are likely fixed or are better suited to a new
ticket if issues remain.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Andrey Kozlovskiy]

https://bugs.kde.org/show_bug.cgi?id=344433

Andrey Kozlovskiy  changed:

   What|Removed |Added

 CC||andronon...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Claudius Ellsel]

https://bugs.kde.org/show_bug.cgi?id=344433

Claudius Ellsel  changed:

   What|Removed |Added

 CC||claudius.ell...@live.de

--- Comment #38 from Claudius Ellsel  ---
I have been noticing occasionally screen tearing when scrolling in Firefox with
different KDE setups and versions on I think both NVIDIA and Intel graphics.
Just confirmed it with Intel and KDE 5.19 on Wayland.

After doing some searching, I landed on this issue. I only don't really know
whether this is also causing the problems I see or whether that is a different
issue. Thought I will ask here first before creating a new issue for it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #37 from Christoph Feck  ---
See also https://subdiff.org/blog/2020/the-k-win-ft-project/

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #36 from tempel.jul...@gmail.com ---
May I ask if it is possible to land this rework for 5.19?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #35 from tempel.jul...@gmail.com ---
The PoC patch still works for current kwin git-master:
https://bugs.kde.org/show_bug.cgi?id=415262
With that applied, intel_swap_event really seems to work nicely in KWin
compositing, as far is I can tell.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #34 from tempel.jul...@gmail.com ---
would it still be possible to include a fix for the freezes with
KWIN_USE_INTEL_SWAP_EVENT=1, as proposed by Michael Marley?
That would probably be quite helpful already.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Roman Gilg]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #33 from Roman Gilg  ---
Sorry for not having the patches in 5.18. The patchset is not dead. In my
opinion it was fine, but there are organizational issues with KWin development
I want to have solved before I commit myself to any more large changes like
this that also always induce the risk of breaking things.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Michael Marley]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #32 from Michael Marley  ---
Yeah, that's quite disappointing.  I was looking forward to this patchset quite
a bit.

I have found, though, that many of the same benefits of the patchset can be
acquired simply by setting "export KWIN_USE_INTEL_SWAP_EVENT=1" before starting
kwin.

Roman, even if the rest of the patchset is completely dead, is there any chance
of getting the patch for fixing the problem where the screen blacks out when
toggling compositing with swap events enabled?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=344433

tempel.jul...@gmail.com changed:

   What|Removed |Added

Version|5.3.2   |5.17.90

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=344433

tempel.jul...@gmail.com changed:

   What|Removed |Added

   Platform|Kubuntu Packages|Archlinux Packages

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #31 from tempel.jul...@gmail.com ---
Ok, I found the revert commits and your comment about it:
https://mail.kde.org/pipermail/kwin/2020-January/002999.html

Well, now KWin compositing is back to totally unusable. :(

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=344433

tempel.jul...@gmail.com changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #30 from tempel.jul...@gmail.com ---
Roman, I'm now with Plasma 5.17.90-1 from Arch KDE unstable repo, and unlike
with my previous git-master builds, the issue is not fixed. It's like with
5.17.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Michael Marley]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #29 from Michael Marley  ---
Yep, that's still with 5.17.  I was just reporting back to make sure you knew
not to worry about my problem, since it seems specific to that one computer I
have.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Roman Gilg]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #28 from Roman Gilg  ---
(In reply to Michael Marley from comment #27)
> So I have done some more testing and I have found that the
> frame-rate-halving issue I reported with KWIN_USE_INTEL_SWAP_EVENT earlier
> affects only that one system and none of my others.  On the others, the
> result is actually rather amazing, dramatically reducing input lag and
> stuttering and eliminating micro-stuttering.  For that one problematic
> system, I have also had other frame rate and stuttering-related issues, so I
> think there must be something specific to that system.  Sorry for the noise,
> and again, thanks for the work!

Thank you, but if I understood you correctly you were testing it with 5.17 on
these systems, right? Or did you test it with KWin from master branch?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Michael Marley]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #27 from Michael Marley  ---
So I have done some more testing and I have found that the frame-rate-halving
issue I reported with KWIN_USE_INTEL_SWAP_EVENT earlier affects only that one
system and none of my others.  On the others, the result is actually rather
amazing, dramatically reducing input lag and stuttering and eliminating
micro-stuttering.  For that one problematic system, I have also had other frame
rate and stuttering-related issues, so I think there must be something specific
to that system.  Sorry for the noise, and again, thanks for the work!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #26 from tempel.jul...@gmail.com ---
Here we go:
https://bugs.kde.org/show_bug.cgi?id=415262

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Roman Gilg]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #25 from Roman Gilg  ---
(In reply to tempel.julian from comment #24)
> Could instantly make it freeze by starting a fullscreen game, turning
> compositing off via hotkey and then re-enable it.

Thanks for testing! Please open a new bug report for that and mention what
hardware you are testing it with. I will try to reproduce it asap. There were a
multitude of changes to the compositing pipeline so it might be unrelated to
intel swap event.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #24 from tempel.jul...@gmail.com ---
Could instantly make it freeze by starting a fullscreen game, turning
compositing off via hotkey and then re-enable it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #23 from tempel.jul...@gmail.com ---
I went through dependency hell and compiled recent kwin git-master on Arch.
Indeed, the stutter issue seems to be completely gone, just like it previously
was when using the intel swap event feature.

There is one issue though, which is similar to the freezing issues of previous
intel swap event setting: When I change animation speed or window shadow
properties in system settings, KWin compositing freezes to death and turns
black. Sometimes the desktop can still be accessed by turning off compositing
via shift + alt + F12, but sometimes one is completely locked out.

I remember that previously intel swap event could freeze when turning
compositing on or off, this hasn't yet occurred. Would need more testing to be
certain though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Michael Marley]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #22 from Michael Marley  ---
OK, I will see if I can find time to test it with the Kubuntu automated nightly
PPAs or something of that sort.  Thanks again!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Roman Gilg]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #21 from Roman Gilg  ---
(In reply to Michael Marley from comment #20)
> That sounds awesome, thanks for the work!  I do have one question though.  I
> noticed in there one of the changes you made was to make
> KWIN_USE_INTEL_SWAP_EVENT default to 1.  I have actually tried this with
> 5.17.x and it usually makes my framerate fall to 30 or 40 FPS instead of 60.
> Has the rest of your work fixed that, or will I have to force it back off?

The compositing pipeline has been fully overhauled so you can't guess from 5.17
behavior to how it will work in 5.18.

Of course if you can try it on master and report back if it's fine there or you
have a similar problem, that would be very helpful.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Michael Marley]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #20 from Michael Marley  ---
That sounds awesome, thanks for the work!  I do have one question though.  I
noticed in there one of the changes you made was to make
KWIN_USE_INTEL_SWAP_EVENT default to 1.  I have actually tried this with 5.17.x
and it usually makes my framerate fall to 30 or 40 FPS instead of 60.  Has the
rest of your work fixed that, or will I have to force it back off?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Roman Gilg]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #19 from Roman Gilg  ---
Yea, you need other projects to be built from master as well. It's easy for
example on KDE Neon Dev Unstable edition and Manjaro with kwin-git package.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #18 from tempel.jul...@gmail.com ---
I would give it a try, but building master fails:

kwin/effects/startupfeedback/startupfeedback.cpp: In Elementfunktion »virtual
void KWin::StartupFeedbackEffect::reconfigure(KWin::Effect::ReconfigureFlags)«:
kwin/effects/startupfeedback/startupfeedback.cpp:125:39: Fehler: »class
KConfigWatcher« hat kein Element namens »config«
  125 | KConfigGroup c = m_configWatcher->config()->group("FeedbackStyle");
  |   ^~
kwin/effects/startupfeedback/startupfeedback.cpp:128:26: Fehler: »class
KConfigWatcher« hat kein Element namens »config«
  128 | c = m_configWatcher->config()->group("BusyCursorSettings");
  |  ^~
make[2]: *** [effects/CMakeFiles/kwin4_effect_builtins.dir/build.make:1202:
effects/CMakeFiles/kwin4_effect_builtins.dir/startupfeedback/startupfeedback.cpp.o]
Fehler 1
make[2]: *** Es wird auf noch nicht beendete Prozesse gewartet
make[1]: *** [CMakeFiles/Makefile2:4372:
effects/CMakeFiles/kwin4_effect_builtins.dir/all] Fehler 2
make: *** [Makefile:130: all] Fehler 2
==> FEHLER: Ein Fehler geschah in build().
Breche ab...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Roman Gilg]

https://bugs.kde.org/show_bug.cgi?id=344433

Roman Gilg  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 CC||subd...@gmail.com
 Resolution|--- |FIXED

--- Comment #17 from Roman Gilg  ---
This issue should be solved in 5.18 with patches in:
https://phabricator.kde.org/T11071.

There will be no more KWin "triple buffering" available, instead everything
hopefully just works right away without any configuration necessary. If it
doesn't reopen.

You can also build KWin from master to test the current state. (there is one
patch missing yet though for optimizing the Nvidia case).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=344433

Nate Graham  changed:

   What|Removed |Added

 CC||tempel.jul...@gmail.com

--- Comment #16 from Nate Graham  ---
*** Bug 397850 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Darkspirit]

https://bugs.kde.org/show_bug.cgi?id=344433

Darkspirit  changed:

   What|Removed |Added

 CC||j...@ikenmeyer.eu

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[S . Christian Collins]

https://bugs.kde.org/show_bug.cgi?id=344433

S. Christian Collins  changed:

   What|Removed |Added

 CC||s_chriscoll...@hotmail.com

--- Comment #15 from S. Christian Collins  ---
Created attachment 116314
  --> https://bugs.kde.org/attachment.cgi?id=116314=edit
video for testing 60fps playback

Attached is a great video for testing 60fps playback. It is very easy to see
when frames are dropped with compositing enabled vs. disabled. Original video
here: https://www.youtube.com/watch?v=Cyxixzi2dgQ

I prefer to test using the webm file in VLC, as I find VLC's playback to be
more consistent than YouTube.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Steffen Coenen]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #14 from Steffen Coenen  ---
I was able to reproduce the problem on an Intel Haswell iGPU. However, there
was much less stutter than on my NVIDIA card. On the Haswell iGPU, the stutter
was almost unnoticeable. Still, I was able to reproduce stutter with triple
buffering enabled that did not occur without it, so it might be better to
disable triple buffering especially on the hardware that has serious stutter if
feasible.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=344433

--- Comment #13 from Martin Flöser  ---
*** Bug 386333 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Andrey Borisochkin]

https://bugs.kde.org/show_bug.cgi?id=344433

Andrey Borisochkin  changed:

   What|Removed |Added

 CC||borisoch...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Steffen Coenen]

https://bugs.kde.org/show_bug.cgi?id=344433

Steffen Coenen  changed:

   What|Removed |Added

 CC||tarding...@googlemail.com

--- Comment #12 from Steffen Coenen  ---
I think I experience the same bug. I can fix it by setting MaxFPS and
RefreshRate to 70 in kwinrc as described in another bug report but this leads
to windows lagging behind the mouse cursor when moving them.

Another bug report that might be the same bug.
https://bugs.kde.org/show_bug.cgi?id=351700

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 344433] SceneOpenGL::paint() occasionally lasts > 16ms (triple buffering enabled)

[Daniel Eckl via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=344433

Daniel Eckl  changed:

   What|Removed |Added

 CC||daniel.e...@gmx.de

-- 
You are receiving this mail because:
You are watching all bug changes.