[kwin] [Bug 375355] Meta/Modifier only shortcuts don't work when CapsLock is on

2017-01-25 Thread Martin Gräßlin 
https://bugs.kde.org/show_bug.cgi?id=375355

Martin Gräßlin  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kwi
   ||n/5a87fa3f92cfc29944b8dc66c
   ||2320e3062b532ee
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
   Version Fixed In||5.8.6

--- Comment #7 from Martin Gräßlin  ---
Git commit 5a87fa3f92cfc29944b8dc66c2320e3062b532ee by Martin Gräßlin.
Committed on 25/01/2017 at 12:39.
Pushed by graesslin into branch 'Plasma/5.8'.

Support modifier-only-shortcuts when capslock is on

Summary:
So far we didn't trigger modifier-only-shortcuts when capslock was
enabled. In fact we even ensured that the shortcuts did not trigger.
This seems not to be what our users expect. Meta should still trigger
if capslock is on.

This change modifies the logic to determine which modifier is currently
pressed by using the modifiersRelevantForGlobalShortcuts. The difference
to the "normal" modifiers is that this excludes capslock from modifiers
and excludes consumed modifiers. The latter is not really relevant as
modifier-only-shortcuts do not trigger if multiple keys are pressed,
which is required to have a modifier consumed.
FIXED-IN: 5.8.6

Test Plan: Only with adjusted autotest

Reviewers: #kwin, #plasma

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D4241

M  +14   -8autotests/integration/modifier_only_shortcut_test.cpp
M  +3-3keyboard_input.cpp

https://commits.kde.org/kwin/5a87fa3f92cfc29944b8dc66c2320e3062b532ee

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375355] Meta/Modifier only shortcuts don't work when CapsLock is on

2017-01-22 Thread Martin Gräßlin 
https://bugs.kde.org/show_bug.cgi?id=375355

Martin Gräßlin  changed:

   What|Removed |Added

  Flags||ReviewRequest+
URL||https://phabricator.kde.org
   ||/D4241

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375355] Meta/Modifier only shortcuts don't work when CapsLock is on

2017-01-22 Thread Martin Gräßlin 
https://bugs.kde.org/show_bug.cgi?id=375355

--- Comment #6 from Martin Gräßlin  ---
Git commit 0acfebd96bace0fefd7c4291617f1d07f96ca03e by Martin Gräßlin.
Committed on 22/01/2017 at 08:42.
Pushed by graesslin into branch 'Plasma/5.8'.

[autotests] Add test case for modifier only trigger when capslock enabled

This extends the testCapsLock to ensure that modifier only shortcut
trigger when capslock is enabled. So far the test only ensured that
capslock doesn't trigger the shift modifier only shortcut.

As the test shows currently when capslock is on, the meta key doesn't
trigger any more.

M  +17   -1autotests/integration/modifier_only_shortcut_test.cpp

https://commits.kde.org/kwin/0acfebd96bace0fefd7c4291617f1d07f96ca03e

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375355] Meta/Modifier only shortcuts don't work when CapsLock is on

2017-01-21 Thread Martin Gräßlin 
https://bugs.kde.org/show_bug.cgi?id=375355

--- Comment #5 from Martin Gräßlin  ---
Git commit 5dc942ac5e3611ae7db8f2902bb092b66920edeb by Martin Gräßlin.
Committed on 21/01/2017 at 19:13.
Pushed by graesslin into branch 'Plasma/5.9'.

[autotests] Add test case for modifier only trigger when capslock enabled

This extends the testCapsLock to ensure that modifier only shortcut
trigger when capslock is enabled. So far the test only ensured that
capslock doesn't trigger the shift modifier only shortcut.

As the test shows currently when capslock is on, the meta key doesn't
trigger any more.

This test case goes into Plasma/5.9 branch and not in Plasma/5.8 as a
fix will most likely need the new xkbcommon 0.7 code paths which we do
not have in Plasma/5.8.

M  +16   -1autotests/integration/modifier_only_shortcut_test.cpp

https://commits.kde.org/kwin/5dc942ac5e3611ae7db8f2902bb092b66920edeb

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375355] Meta/Modifier only shortcuts don't work when CapsLock is on

2017-01-21 Thread Martin Gräßlin 
https://bugs.kde.org/show_bug.cgi?id=375355

Martin Gräßlin  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
  Flags||Wayland+, X11+

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375355] Meta/Modifier only shortcuts don't work when CapsLock is on

2017-01-21 Thread Martin Gräßlin 
https://bugs.kde.org/show_bug.cgi?id=375355

--- Comment #4 from Martin Gräßlin  ---
I just realized that our unit test verifies a different behavior. That is:
don't trigger shift shortcut on caps lock.

Now trusting meta on caps lock sounds sensible in general. Though I won't
promise that we can fix it for 5.8.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375355] Meta/Modifier only shortcuts don't work when CapsLock is on

2017-01-21 Thread Chris Holland 
https://bugs.kde.org/show_bug.cgi?id=375355

--- Comment #3 from Chris Holland  ---
System Settings is set to "Generic 101-Key PC". This is probably the default
because I skipped through that screen in the KDE Neon OS installer.

My actual keyboard is a cheap $20 thing from staples.

https://i.imgur.com/CKYkZSx.jpg
https://i.imgur.com/d0NGtEL.jpg
https://i.imgur.com/JBuYKza.jpg

xev of pressing CapsLock (on) then Super_L, then CapsLock (off) then Super_L
https://paste.kde.org/pqa1am4mi
Nothing interesting there.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375355] Meta/Modifier only shortcuts don't work when CapsLock is on

2017-01-21 Thread Christoph Feck 
https://bugs.kde.org/show_bug.cgi?id=375355

Christoph Feck  changed:

   What|Removed |Added

 CC||derek...@gmail.com

--- Comment #2 from Christoph Feck  ---
*** Bug 375356 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 375355] Meta/Modifier only shortcuts don't work when CapsLock is on

2017-01-20 Thread Martin Gräßlin 
https://bugs.kde.org/show_bug.cgi?id=375355

--- Comment #1 from Martin Gräßlin  ---
We do have support for caps lock in modifier only shortcuts. Even with an unit
test.

So the question is rather why it doesn't work for you. Which keyboard layout
are you using?

-- 
You are receiving this mail because:
You are watching all bug changes.