[kwin] [Bug 382283] Restart of KWin fails due to OpenGL safepoint thread running

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=382283

--- Comment #13 from tesfab...@gmail.com ---
Thanks a lot!
I've applied the patch and tried a little bit and it is still running without a
crash.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 382283] Restart of KWin fails due to OpenGL safepoint thread running

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=382283

Martin Flöser  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kwi
   ||n/06a558e3de658f300b295beac
   ||7c4adc4f08227f5
 Resolution|--- |FIXED
   Version Fixed In||5.10.4
 Status|UNCONFIRMED |RESOLVED

--- Comment #12 from Martin Flöser  ---
Git commit 06a558e3de658f300b295beac7c4adc4f08227f5 by Martin Flöser.
Committed on 16/07/2017 at 16:04.
Pushed by graesslin into branch 'Plasma/5.10'.

[platforms/x11] Quit the OpenGL Freeze protection thread on shutdown

Summary:
Weird NVIDIA behavior fixup part 2. Now that we do no longer freeze when
NVIDIA decides to create an OpenGL error on startup
(aefb5f4dd9d41aa7377d56ece203089c73aefe07), we experience a new issue.
KWin is terminating (no idea why, [1]) and at the same time the OpenGL freeze
protection thread is still running. So far we did not terminate the
thread on shutdown and thus we hit an abort in Qt.

This change ensures that we properly terminate the thread on shutdown.

[1] My current theory is that games terminate KWin, common pattern of
bug reports is "steam".
FIXED-IN: 5.10.4

Test Plan:
Tortured KWin by making sure I go through the code path,
saw the abort without the patch, no more abort with the patch

Reviewers: #kwin, #plasma

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D6735

M  +8-1plugins/platforms/x11/standalone/x11_platform.cpp

https://commits.kde.org/kwin/06a558e3de658f300b295beac7c4adc4f08227f5

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 382283] Restart of KWin fails due to OpenGL safepoint thread running

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=382283

Martin Flöser  changed:

   What|Removed |Added

  Flags||ReviewRequest+
URL||https://phabricator.kde.org
   ||/D6735

--- Comment #11 from Martin Flöser  ---
Patch for the abort at: https://phabricator.kde.org/D6735

If you have in addition any idea why KWin gets terminated, please let me know.
If possible check .xsession-errors whether we have a message there.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 382283] Restart of KWin fails due to OpenGL safepoint thread running

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=382283

--- Comment #10 from Martin Flöser  ---
I do not really understand why KWin is being shut down. We used to have code
which restarted into XRender, but that seems to be gone. So I don't understand
why KWin gets closed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 382283] Restart of KWin fails due to OpenGL safepoint thread running

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=382283

Martin Flöser  changed:

   What|Removed |Added

 CC||commander.alch...@gmail.com

--- Comment #9 from Martin Flöser  ---
*** Bug 382385 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 382283] Restart of KWin fails due to OpenGL safepoint thread running

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=382283

Martin Flöser  changed:

   What|Removed |Added

 Status|NEEDSINFO   |UNCONFIRMED
  Flags||Wayland-, X11+
  Component|general |platform-x11-standalone
Summary|KWin X11 crashes sometimes  |Restart of KWin fails due
   ||to OpenGL safepoint thread
   ||running
 Resolution|BACKTRACE   |---

--- Comment #8 from Martin Flöser  ---
I'm starting to get an idea. The compositor breaks in the NVIDIA driver and we
try to restart the complete window manager. This fails due to a thread running
in the X11 platform

-- 
You are receiving this mail because:
You are watching all bug changes.