[kwin] [Bug 384769] Kwin: Mouse pointer inaccurate when closing/resizing windows due to scaling factor

2017-10-10 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=384769

--- Comment #8 from Martin Flöser  ---
*** Bug 384767 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 384769] Kwin: Mouse pointer inaccurate when closing/resizing windows due to scaling factor

2017-09-18 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=384769

David Edmundson  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kwi
   ||n/4238218b762996b41480f8d1c
   ||9a1c88930e08a11
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #7 from David Edmundson  ---
Git commit 4238218b762996b41480f8d1c9a1c88930e08a11 by David Edmundson.
Committed on 18/09/2017 at 15:40.
Pushed by davidedmundson into branch 'Plasma/5.11'.

Don't scale cursor hotspot differently to cursor

Summary:
In the DRM plugin the cursor is currently is drawn at the native size
given.
Therefore we don't want to scale the icon offset as that leads to it
being drawn every so slightly off-sync.
Fixed-in: 5.11.0

Test Plan:
Kate now selects lines based on the middle of the cursor, not the top left.
I'd previously gotten so used to it, I hadn't realised it was actually a bug 
:/

Reviewers: #plasma, graesslin

Reviewed By: #plasma, graesslin

Subscribers: plasma-devel, kwin, #kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D7868

M  +1-2plugins/platforms/drm/drm_backend.cpp
M  +1-1plugins/platforms/drm/drm_output.cpp

https://commits.kde.org/kwin/4238218b762996b41480f8d1c9a1c88930e08a11

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 384769] Kwin: Mouse pointer inaccurate when closing/resizing windows due to scaling factor

2017-09-18 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=384769

David Edmundson  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #6 from David Edmundson  ---
I've made a safe patch for 5.11, that fixes the immediate bug.

But I need to revisit this, probably in master.

You're right I can extract the source scale, but doing something useful with
that is trickier. 

We have the problem that the dumb buffers are currently shared between the
outputs, those outputs might be scaled differently - and we need those buffers
in the correct target size.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 384769] Kwin: Mouse pointer inaccurate when closing/resizing windows due to scaling factor

2017-09-17 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=384769

--- Comment #5 from Martin Flöser  ---
@David: as the cursor is just a wl_surface: maybe we do get the information of
whether it should be scaled as well. If the applications send us a scale on the
cursor we could incorporate that in the DRM platform.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 384769] Kwin: Mouse pointer inaccurate when closing/resizing windows due to scaling factor

2017-09-17 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=384769

--- Comment #4 from David Edmundson  ---
So the bug is in the DRM hardware cursor rendering, we're not scaling it, but
we are implicitly scaling the hotpost. 

Leading to everything being ever so slighlty off, particularly when you change
cursors. 

The obvious fix is that I should scale the cursor, but then I hit this damn
issue again of the user needing different settings depending on whether they're
on Wayland or not.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 384769] Kwin: Mouse pointer inaccurate when closing/resizing windows due to scaling factor

2017-09-16 Thread Rainer Finke
https://bugs.kde.org/show_bug.cgi?id=384769

--- Comment #3 from Rainer Finke  ---
Sorry, I need to correct one of my sentences!

... Actually the mouse pointer jumps some milimeters like when the border areas
are not technically the same as what you see on the screen, it doesn't look or
feel accurate at all. ...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 384769] Kwin: Mouse pointer inaccurate when closing/resizing windows due to scaling factor

2017-09-16 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=384769

Martin Flöser  changed:

   What|Removed |Added

  Component|compositing |input

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 384769] Kwin: Mouse pointer inaccurate when closing/resizing windows due to scaling factor

2017-09-16 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=384769

Martin Flöser  changed:

   What|Removed |Added

  Flags||Wayland+
 CC||k...@davidedmundson.co.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 384769] Kwin: Mouse pointer inaccurate when closing/resizing windows due to scaling factor

2017-09-16 Thread Rainer Finke
https://bugs.kde.org/show_bug.cgi?id=384769

--- Comment #2 from Rainer Finke  ---
In systemsettings there is a scaling factor of 1x and 2x on Wayland. 2x is
applied on my 4k screen automatically. So you first have to apply this, if you
don't have scaling enabled yet. 
Then take a window that is not fullscreen. Either move the mouse pointer to an
area where you are able to resize the window or where you are able to close the
window with the x in the right corner. You don't have to actually resize or
close, it is just about the mouse pointer behaviour itself.
Expected result: normal mouse pointer behavior without any strange movements
(jumps). Actually the mouse pointer jumps some milimeters like when the border
areas are technically the same as what you see on the scren, it doesn't look or
feel accurate at all. Without scaling it is fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 384769] Kwin: Mouse pointer inaccurate when closing/resizing windows due to scaling factor

2017-09-16 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=384769

--- Comment #1 from Martin Flöser  ---
Sorry, but I don't understand what you mean by this. Especially not with
closing/resizing windows. Could you please describe in more details what you
are doing. Best would be something like:

Steps to reproduce:
1. Do this
2. Do that
3. then that

Expected behavior:
what I expect to happen

Actual behavior:
What really happens.

-- 
You are receiving this mail because:
You are watching all bug changes.