[kwin] [Bug 387273] rotating a widescreen resolution should rotate the half-screen tiling snap

2017-11-28 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=387273

Harald Sitter  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |ASSIGNED
   Assignee|kwin-bugs-n...@kde.org  |sit...@kde.org

--- Comment #5 from Harald Sitter  ---
The pertinent logic actually seems to live in
`AbstractClient::checkQuickTilingMaximizationZones`.

I do have some code which implements the alternate logic but it is fairly
spaghetti. I'll have to think about it a bit more.

I also found the existing code rather meh to read because of the manual border
checking, so I was thinking about QRecting the entire thing until I realized
that the current method operates on the maximized size of the client (i.e.
excluding the panel) which made qrect rather unusable unless one extends them
well beyond the maximized area coordinates so as to cover potential panels on
each side.

All fairly meh.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 387273] rotating a widescreen resolution should rotate the half-screen tiling snap

2017-11-24 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=387273

--- Comment #4 from Martin Flöser  ---
If you are interested, you could try to implement yourself. We have a complete
test coverage for quick tiling in autotest/integration/test_quick_tiling.cpp
and implementation should be in geometry.cpp

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 387273] rotating a widescreen resolution should rotate the half-screen tiling snap

2017-11-24 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=387273

--- Comment #3 from Harald Sitter  ---
I was assuming you'd at least know the (rotated) screen resolution. The way I
see it you would need to `if maxX>=maxY then splitHorizontal else
splitVertical` and the split would always yield smart space usage. The fact
that the screen is rotated doesn't really matter in the end, you only need to
know the "aspect orientation", for lack of a better word, and that can easily
be checked through the resolution.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 387273] rotating a widescreen resolution should rotate the half-screen tiling snap

2017-11-24 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=387273

Martin Flöser  changed:

   What|Removed |Added

   Severity|normal  |wishlist
  Component|general |core

--- Comment #2 from Martin Flöser  ---
I don't think we have sufficient information for that.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 387273] rotating a widescreen resolution should rotate the half-screen tiling snap

2017-11-24 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=387273

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 387273] rotating a widescreen resolution should rotate the half-screen tiling snap

2017-11-24 Thread Harald Sitter
https://bugs.kde.org/show_bug.cgi?id=387273

--- Comment #1 from Harald Sitter  ---
Created attachment 109043
  --> https://bugs.kde.org/attachment.cgi?id=109043=edit
picture

-- 
You are receiving this mail because:
You are watching all bug changes.