[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 soredake changed: What|Removed |Added CC|katyaberezy...@gmail.com| -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 Zamundaaa changed: What|Removed |Added CC||evren...@hotmail.com --- Comment #35 from Zamundaaa --- *** Bug 488657 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 codemo...@gmail.com changed: What|Removed |Added CC||codemo...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 --- Comment #34 from Jin Liu --- (In reply to David Edmundson from comment #33) > We'll continue this in Qt Beside the fractional scaling cases, this problem is still likely to happen with 3x scaling and a screen/desktop area size not multiple of 3. Is this by design? -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 David Edmundson changed: What|Removed |Added Resolution|--- |UPSTREAM Status|CONFIRMED |RESOLVED --- Comment #33 from David Edmundson --- We'll continue this in Qt -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 Nate Graham changed: What|Removed |Added See Also|https://bugs.kde.org/show_b | |ug.cgi?id=463828| -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 Nate Graham changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=463495 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 Nate Graham changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=463828 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 ltop...@mailbox.org changed: What|Removed |Added CC||ltop...@mailbox.org -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 rezad changed: What|Removed |Added CC|rezad1...@protonmail.ch | -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 Nate Graham changed: What|Removed |Added Assignee|k...@davidedmundson.co.uk|kwin-bugs-n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 --- Comment #32 from David Edmundson --- > Seems like magic... FontDPI is mostly independent -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 --- Comment #31 from Jin Liu --- (In reply to David Edmundson from comment #29) > Upstream: https://bugreports.qt.io/browse/QTBUG-105128 > GTK doesn't have fractional scaling so can I assume that's correct? Yes, mine has GDK_SCALE=2 and GDK_DPI_SCALE=0.5, presumably also set by KDE? However, with GTK in 2x and QT in 2.5x, the buttons and text seem to be the same size in both toolkits. Seems like magic... -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 --- Comment #30 from Jin Liu --- (In reply to David Edmundson from comment #28) > >BTW, I don't know whether that "resize increment" of 3 or 2 in window hint > >is set by Qt/GTK or kwin > > Resize increments go up with the scale factor from the Qt side. > > As you say it makes sense for integers to make sure it's always a valid > value but for fractional scaling it's just making it worse than if it had > stuck with 1. Indeed. However, there's still problem for integer scaling. For example, on my laptop with a 3200x2000 screen, when set to 3x zoom, KDE apps still have "Fullscreen" window menu disabled. And when lauched maximized, the window won't cover the top-right pixel. What's worse, this behavior is inconsistent in kwin: when restored then maximized again, that window now covers the the top-right pixel. This is the reason why clicking on the top right corner sometimes closes the window behind. This is unlikely to happen with 2x zoom, since most screen sizes are multiple of 2. But few are multiple of 3 (1920x1080 being the exception). Is it possible that kwin_x11 simply ignores the resize increments hint? Since both GTK and QT apps seem work quite well in kwin_wayland, which seems having no idea of resize increments, so perhaps these toolkits don't really need this hint. (Maybe some terminal emulators do, but xterm works ok) Or at least, could kwin_x11 ignore the resize increments hint for maximized windows? -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 Nate Graham changed: What|Removed |Added URL||https://bugreports.qt.io/br ||owse/QTBUG-105128 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 --- Comment #29 from David Edmundson --- Upstream: https://bugreports.qt.io/browse/QTBUG-105128 GTK doesn't have fractional scaling so can I assume that's correct? -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 --- Comment #28 from David Edmundson --- >BTW, I don't know whether that "resize increment" of 3 or 2 in window hint is >set by Qt/GTK or kwin Resize increments go up with the scale factor from the Qt side. As you say it makes sense for integers to make sure it's always a valid value but for fractional scaling it's just making it worse than if it had stuck with 1. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 --- Comment #27 from Jin Liu --- BTW, I don't know whether that "resize increment" of 3 or 2 in window hint is set by Qt/GTK or kwin. But neither 3 or 2 doesn't make much sense with 2.5x zoom. If the intent of "resize increment" is to make the client area match the toolkit's layout grid, then for 2.5x zoom it should be 5 really... -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 Nate Graham changed: What|Removed |Added Priority|NOR |HI --- Comment #26 from Nate Graham --- Thanks for the thorough investigation! Raising priority given the number of duplicates. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956
--- Comment #25 from Jin Liu ---
I did some debugging on https://bugs.kde.org/show_bug.cgi?id=445741, which
might be relevant here. But I don't know much about kwin, so it's only wild
guesses:
In X11, kwin seems to force window size to be rounded to the "resize increment"
in WM_SIZE_HINTS, in various places.
The code is in X11Window::constrainClientSize:
https://invent.kde.org/plasma/kwin/-/blob/68f6734d5cf758004c3328777dbf66fe9113b4d6/src/x11window.cpp#L3551
>int width_inc = m_geometryHints.resizeIncrements().width();
>int height_inc = m_geometryHints.resizeIncrements().height();
>int basew_inc = m_geometryHints.baseSize().width();
>int baseh_inc = m_geometryHints.baseSize().height();
>if (!m_geometryHints.hasBaseSize()) {
>basew_inc = m_geometryHints.minSize().width();
>baseh_inc = m_geometryHints.minSize().height();
>}
>w = int((w - basew_inc) / width_inc) * width_inc + basew_inc;
>h = int((h - baseh_inc) / height_inc) * height_inc + baseh_inc;
In my laptop, the screen size is 3200x2000, KDE's global scaling set to 250%.
Then all KDE apps have "resize increment"=3 in WM_SIZE_HINTS, where all Gnome
apps seem to have "resize increment"=2, and other apps (e.g. vscode) don't have
it at all.
This causes the "fullscreen" window menu in all KDE apps grayed out, because of
this check in X11Window::isFullScreenable:
https://invent.kde.org/plasma/kwin/-/blob/68f6734d5cf758004c3328777dbf66fe9113b4d6/src/x11window.cpp#L1284
>if (rules()->checkStrictGeometry(true)) {
>// check geometry constraints (rule to obey is set)
>const QRect fullScreenArea = workspace()->clientArea(FullScreenArea,
> this);
>const QSize constrainedClientSize =
> constrainClientSize(fullScreenArea.size());
>if (rules()->checkSize(constrainedClientSize) !=
> fullScreenArea.size()) {
>return false; // the app wouldn't fit exactly fullscreen geometry
> due to its strict geometry requirements
>}
>}
Since my screen resolution is not multiple of 3, KDE apps are not allowed to
fullscreen.
And for this bug, in my laptop, all KDE apps, when launched maximized, the
window won't cover the top-right pixel. Clicking on that pixel closes the
window behind. However, if I restore that window then maximize again, it works
OK.
My guess is X11Window::manage also calls X11Window::constrainClientSize:
https://invent.kde.org/plasma/kwin/-/blob/68f6734d5cf758004c3328777dbf66fe9113b4d6/src/x11window.cpp#L694
So if the desktop area (fullscreen excluding panel) is not multiple of 3, KDE
apps won't exactly cover the whole desktop area when launched maximized.
In my case, both problems can be worked around by creating a window rule: "for
all windows, force disable Strict Geometry", which bypasses
constrainClientSize.
This also explains why Wayland doesn't have these problems, because it uses the
generic Window::constrainClientSize, which doesn't do rounding at all.
Hope this helps.
--
You are receiving this mail because:
You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 Nate Graham changed: What|Removed |Added CC||ad.liu@gmail.com --- Comment #24 from Nate Graham --- *** Bug 445741 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 kde@grau.net changed: What|Removed |Added CC|kde@grau.net| -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 Nate Graham changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=445741 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 Nate Graham changed: What|Removed |Added CC||k...@paulmcauley.com --- Comment #23 from Nate Graham --- *** Bug 435674 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 soredake changed: What|Removed |Added CC||ndrzj1...@relay.firefox.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 Nate Graham changed: What|Removed |Added CC||opendr...@gmail.com --- Comment #22 from Nate Graham --- *** Bug 452687 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 Nate Graham changed: What|Removed |Added CC||rezad1...@protonmail.ch --- Comment #21 from Nate Graham --- *** Bug 452354 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 Błażej Szczygieł changed: What|Removed |Added CC||spa...@wp.pl --- Comment #20 from Błażej Szczygieł --- Created attachment 147078 --> https://bugs.kde.org/attachment.cgi?id=147078=edit screenshot representing the bug I have the same problem on Breeze theme only, X11, Plasma 5.24.2, 200% scaling and 168 DPI fonts (or 175% scaling). -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 Nate Graham changed: What|Removed |Added CC||m...@fireburn.co.uk --- Comment #19 from Nate Graham --- *** Bug 423936 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 Nate Graham changed: What|Removed |Added CC||rapiteanu.cata...@gmail.com --- Comment #18 from Nate Graham --- *** Bug 449015 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 postix changed: What|Removed |Added CC||pos...@posteo.eu -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 --- Comment #17 from Eugene --- While the issue is present with the Breeze and Plastik themes, the Oxygen window decorations step around it somehow, I've tested with multiple apps and it just works. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 Nate Graham changed: What|Removed |Added CC||bertyf...@gmail.com --- Comment #16 from Nate Graham --- *** Bug 445964 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 Nate Graham changed: What|Removed |Added CC||b...@twosixfour.net --- Comment #15 from Nate Graham --- *** Bug 439428 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 Nate Graham changed: What|Removed |Added CC||frederick...@tsundere.moe --- Comment #14 from Nate Graham --- *** Bug 413392 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 Nate Graham changed: What|Removed |Added CC||el...@seznam.cz --- Comment #13 from Nate Graham --- *** Bug 428895 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 391956] Maximized windows too small when scaling is applied on X11
https://bugs.kde.org/show_bug.cgi?id=391956 Nate Graham changed: What|Removed |Added Summary|Maximized windows too small |Maximized windows too small |when scaling is applied |when scaling is applied on ||X11 --- Comment #12 from Nate Graham --- Oh, this. Confirmed on X11, not an issue on Wayland. I'll dupe the other reports we have about it to this bug report. -- You are receiving this mail because: You are watching all bug changes.
