[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-11-03 Thread codywohlers
https://bugs.kde.org/show_bug.cgi?id=394772

codywohlers  changed:

   What|Removed |Added

 CC||k...@codywohlers.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-07-28 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=394772

--- Comment #35 from Nate Graham  ---
Thanks Vlad!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-07-28 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=394772

Vlad Zahorodnii  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/kwin/-/commit/ec5a0249e2 |ma/kwin/commit/617adda2911e
   |6acdf12677df535df3d3faa6a18 |08cef70e110b3125e7d3f60498d
   |b49 |1

--- Comment #34 from Vlad Zahorodnii  ---
Git commit 617adda2911e08cef70e110b3125e7d3f60498d1 by Vlad Zahorodnii.
Committed on 28/07/2020 at 07:21.
Pushed by vladz into branch 'Plasma/5.18'.

[x11] Hold a passive grab on buttons only when needed

Due to a bug in the XI2 protocol, clients have to reset scroll valuators
on XI_Enter because the scroll valuators might have changed while the
pointer was elsewhere. The XI_Enter event is usually sent when an input
device enters the window, but it can also be generated by a passive grab.

If an XI_Enter event has been generated by a passive grab, the client
should not reset scroll valuators. Unfortunately, there is no any
reliable way for the client to determine if an XI_Enter event has been
sent in response to a deactivated passive grab. A correct fix for the
scroll issues in GTK apps would involve changes in the XI2 protocol.

As a work around, we can hold a passive grab only if the current mouse
wheel action is either "Activate and scroll" or "Activate, raise, and
scroll."
FIXED-IN: 5.19.3

(cherry picked from commit ec5a0249e26acdf12677df535df3d3faa6a18b49)

M  +68   -45   events.cpp
M  +3-0options.h
M  +1-0x11client.cpp
M  +2-2x11client.h

https://invent.kde.org/plasma/kwin/commit/617adda2911e08cef70e110b3125e7d3f60498d1

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-07-28 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=394772

--- Comment #33 from Vlad Zahorodnii  ---
(In reply to QwertyChouskie from comment #32)
> Any chance to also backport this fix to the 5.18 series?  As 5.18 is what is
> in the current Ubuntu LTS, having the fix there would benefit many users.

Oops, yeah, we need to backport the workaround to 5.18 as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-07-27 Thread QwertyChouskie
https://bugs.kde.org/show_bug.cgi?id=394772

QwertyChouskie  changed:

   What|Removed |Added

 CC||asdfghrbljz...@outlook.com

--- Comment #32 from QwertyChouskie  ---
Any chance to also backport this fix to the 5.18 series?  As 5.18 is what is in
the current Ubuntu LTS, having the fix there would benefit many users.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-06-27 Thread Jonathan Marten
https://bugs.kde.org/show_bug.cgi?id=394772

Jonathan Marten  changed:

   What|Removed |Added

 CC||j...@keelhaul.me.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-06-24 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=394772

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/plas
   ||ma/kwin/-/commit/ec5a0249e2
   ||6acdf12677df535df3d3faa6a18
   ||b49
 Status|ASSIGNED|RESOLVED
   Version Fixed In||5.19.3

--- Comment #31 from Nate Graham  ---
Just fixed! Thanks, Vlad!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-06-23 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=394772

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #30 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/kwin/-/merge_requests/78

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-06-23 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=394772

--- Comment #29 from Vlad Zahorodnii  ---
Relevant merge request:
https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/2140

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-06-23 Thread Vlad Zahorodnii
https://bugs.kde.org/show_bug.cgi?id=394772

--- Comment #28 from Vlad Zahorodnii  ---
(In reply to David Edmundson from comment #22)
> 1) It only happens when kwin is running, not fluxbox or picom
Window managers such as fluxbox and openbox don't grab Button4 and Button5.

(In reply to Martin Flöser from comment #24)
> This piece of code is still using the xcore input grabs. My hope would be
> that changing to xinput2 grabs this would fix it. I had thought about that
This bug will present even after porting kwin to xi2.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-05-30 Thread Brandon Watkins
https://bugs.kde.org/show_bug.cgi?id=394772

Brandon Watkins  changed:

   What|Removed |Added

 CC||bwa...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-05-25 Thread Karl Tomlinson
https://bugs.kde.org/show_bug.cgi?id=394772

Karl Tomlinson  changed:

   What|Removed |Added

 CC||bugs@karlt.net

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-05-23 Thread Alex Fliker
https://bugs.kde.org/show_bug.cgi?id=394772

--- Comment #27 from Alex Fliker  ---
This issue drives me NUTS! It started after upgrading to 5.18. LibreOffice /
Sublime / RawTherapee are the most notable apps for me which are affected.
Firefox is not affected at all...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-05-23 Thread Alex Fliker
https://bugs.kde.org/show_bug.cgi?id=394772

Alex Fliker  changed:

   What|Removed |Added

 CC||flike...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-05-22 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=394772

--- Comment #26 from Martin Flöser  ---
For unfocused windows a mouse grab is always installed. So that is probably the
same issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-05-22 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=394772

--- Comment #25 from Nate Graham  ---
FWIW unchecking that setting does fix the issue where scrolling in GTK3 windows
(using a mouse wheel or touchpad) breaks when a notification arrives, but does
not fix the case where scrolling in unfocused GTK3 windows using a mouse wheel
has no effect/is broken. Scrolling with a touchpad in an inactive window still
works.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-05-22 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=394772

--- Comment #24 from Martin Flöser  ---
KWin holds a passive mouse grab. This is established in events.cpp in method
X11Client::updateMouseGrab (https://cgit.kde.org/kwin.git/tree/events.cpp#n861
). I assume this is the relevant piece of code especially as it checks for the
clickRaise option.

This piece of code is still using the xcore input grabs. My hope would be that
changing to xinput2 grabs this would fix it. I had thought about that in the
past when Krita complained about alt+click breaking things. If we changed the
grabs to only operate on the pointer devices the scroll wheel should no longer
be affected neither wacom devices.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-05-22 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=394772

Nate Graham  changed:

   What|Removed |Added

 Status|REOPENED|CONFIRMED

--- Comment #23 from Nate Graham  ---
Can confirm that unchecking that setting fixes the issue. How
bizarre/heartening!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-05-22 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=394772

David Edmundson  changed:

   What|Removed |Added

 Resolution|UPSTREAM|---
 Status|RESOLVED|REOPENED

--- Comment #22 from David Edmundson  ---
That duplicate report is about missing the first wheel event when it's
replayed. 

This is about continued wheel events, and it shouldn't be being replayed.

I put a lot of debug into GTK and have some notes:


1) It only happens when kwin is running, not fluxbox or picom

2) I built GTK, for every scroll click it's getting a leave event and an enter
event - even though it shouldn't be losing focus at all.

GTK resets cached scroll events on focus change which is why it has no impact.

3) Even more super super weird. *unchecking* "click raises active window" fixes
this.  

That last one gives us something to check for.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-05-22 Thread Andrey
https://bugs.kde.org/show_bug.cgi?id=394772

Andrey  changed:

   What|Removed |Added

 CC||butir...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-04-15 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=394772

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|CONFIRMED   |RESOLVED

--- Comment #21 from Nate Graham  ---
Yeah, nothing we can do here, sorry. :( GTK just needs to be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-04-15 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=394772

--- Comment #20 from Nate Graham  ---
*** Bug 420110 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-04-04 Thread Cruz Enrique
https://bugs.kde.org/show_bug.cgi?id=394772

Cruz Enrique  changed:

   What|Removed |Added

 CC||cruzki...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 394772] Some GTK apps temporarily lose scroll focus while desktop notification are shown

2020-04-02 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=394772

Nate Graham  changed:

   What|Removed |Added

   Assignee|k...@privat.broulik.de   |kwin-bugs-n...@kde.org
URL||https://gitlab.gnome.org/GN
   ||OME/gtk/issues/558
  Component|Notifications   |input
   Target Milestone|1.0 |---
 CC||n...@kde.org
Product|plasmashell |kwin

--- Comment #19 from Nate Graham  ---
Yes, this is a known issue in GTK itself on X11:
https://gitlab.gnome.org/GNOME/gtk/issues/558

It doesn't just affect Plasma; it seems to hit GNOME shell too. Sadly the GTK
developers gave up on fixing it on X11.

If there's no way we can work around it on the KWin side, then I guess this has
to be RESOLVED UPSTREAM. :( Moving to KWin to find out.

-- 
You are receiving this mail because:
You are watching all bug changes.