[kwin] [Bug 396272] wayland: kwin crashes after energy saving turns monitors off and i try to wake them on with a mouse
https://bugs.kde.org/show_bug.cgi?id=396272 David Edmundson changed: What|Removed |Added Latest Commit|https://commits.kde.org/kwi |https://commits.kde.org/kwi |n/a362a67989f1cea4606f9a564 |n/9f2f6d96577dd4aba878e5325 |d9a51144a51c719 |9e20bde72d752d1 --- Comment #7 from David Edmundson --- Git commit 9f2f6d96577dd4aba878e53259e20bde72d752d1 by David Edmundson. Committed on 18/07/2018 at 15:05. Pushed by davidedmundson into branch 'master'. Don't remove outputs during page flip Summary: To do so leaves a dangling pointer on our pageFlipHandler Test Plan: Wobbled a window whilst plugging a monitor in and out Reviewers: #kwin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D14210 M +1-1plugins/platforms/drm/drm_backend.cpp M +17 -0plugins/platforms/drm/drm_output.cpp M +6-1plugins/platforms/drm/drm_output.h https://commits.kde.org/kwin/9f2f6d96577dd4aba878e53259e20bde72d752d1 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 396272] wayland: kwin crashes after energy saving turns monitors off and i try to wake them on with a mouse
https://bugs.kde.org/show_bug.cgi?id=396272 David Edmundson changed: What|Removed |Added Latest Commit||https://commits.kde.org/kwi ||n/a362a67989f1cea4606f9a564 ||d9a51144a51c719 Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #6 from David Edmundson --- Git commit a362a67989f1cea4606f9a564d9a51144a51c719 by David Edmundson. Committed on 19/07/2018 at 08:41. Pushed by davidedmundson into branch 'Plasma/5.13'. Don't remove outputs during page flip Summary: To do so leaves a dangling pointer on our pageFlipHandler Test Plan: Wobbled a window whilst plugging a monitor in and out Reviewers: #kwin, graesslin Reviewed By: #kwin, graesslin Subscribers: anthonyfieroni, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D14210 M +1-1plugins/platforms/drm/drm_backend.cpp M +17 -0plugins/platforms/drm/drm_output.cpp M +6-1plugins/platforms/drm/drm_output.h https://commits.kde.org/kwin/a362a67989f1cea4606f9a564d9a51144a51c719 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 396272] wayland: kwin crashes after energy saving turns monitors off and i try to wake them on with a mouse
https://bugs.kde.org/show_bug.cgi?id=396272 --- Comment #5 from David Edmundson --- >385743 it is not, sorry. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 396272] wayland: kwin crashes after energy saving turns monitors off and i try to wake them on with a mouse
https://bugs.kde.org/show_bug.cgi?id=396272 --- Comment #4 from Miroslav Spehar --- is this connected? https://bugs.kde.org/show_bug.cgi?id=385743 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 396272] wayland: kwin crashes after energy saving turns monitors off and i try to wake them on with a mouse
https://bugs.kde.org/show_bug.cgi?id=396272 Roman Gilg changed: What|Removed |Added CC||subd...@gmail.com --- Comment #3 from Roman Gilg --- One could also hand over a pointer to a struct referencing DrmBackend* backend and DrmOutput* output. Then check if output is still in backend->outputs(). -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 396272] wayland: kwin crashes after energy saving turns monitors off and i try to wake them on with a mouse
https://bugs.kde.org/show_bug.cgi?id=396272 --- Comment #2 from Martin Flöser --- Holding the Output till the pageFlip returned sounds like the more robust solution to me. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 396272] wayland: kwin crashes after energy saving turns monitors off and i try to wake them on with a mouse
https://bugs.kde.org/show_bug.cgi?id=396272 David Edmundson changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 CC||k...@davidedmundson.co.uk --- Comment #1 from David Edmundson --- Not convinced the other two are related. Backtrace makes total sense, drmPageFlip/drmHandleEvent is effectively async and our user_data pointer we supply (the DrmOuptut) can get deleted. We can try to make sure we never delete the output when we have a pending flip. Alternatively I once did a clever trick in kwayland of putting a QPointer on the heap and using that as our user data. Kinda safer, kinda just avoiding the problem. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 396272] wayland: kwin crashes after energy saving turns monitors off and i try to wake them on with a mouse
https://bugs.kde.org/show_bug.cgi?id=396272 Martin Flöser changed: What|Removed |Added Component|wayland-generic |platform-drm -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 396272] wayland: kwin crashes after energy saving turns monitors off and i try to wake them on with a mouse
https://bugs.kde.org/show_bug.cgi?id=396272 Miroslav Spehar changed: What|Removed |Added Flags||Wayland+ -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 396272] wayland: kwin crashes after energy saving turns monitors off and i try to wake them on with a mouse
https://bugs.kde.org/show_bug.cgi?id=396272 Fabian Vogt changed: What|Removed |Added CC||fab...@ritter-vogt.de -- You are receiving this mail because: You are watching all bug changes.
