[kwin] [Bug 398973] The window decorations configuration pop-up needs a Defaults icon
https://bugs.kde.org/show_bug.cgi?id=398973 --- Comment #14 from Patrick Silva --- I can confirm that this bug is fixed on Plasma 5.18 beta + Qt 5.14. :) Thank you all. Operating System: Arch Linux KDE Plasma Version: 5.17.90 KDE Frameworks Version: 5.66.0 Qt Version: 5.14.0 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 398973] The window decorations configuration pop-up needs a Defaults icon
https://bugs.kde.org/show_bug.cgi?id=398973 Björn Feber changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/fra ||meworkintegration/50593c561 ||8998535cc9f482aa25565c5aeb3 ||68ce Resolution|--- |FIXED --- Comment #13 from Björn Feber --- Git commit 50593c5618998535cc9f482aa25565c5aeb368ce by Björn Feber. Committed on 08/10/2019 at 14:19. Pushed by bfeber into branch 'master'. Add standard icons to support to all entries in QDialogButtonBox Summary: Implement the new enumarations introduced in Qt 5.14: https://codereview.qt-project.org/c/qt/qtbase/+/254494/ Test Plan: Can't really test since Qt 5.14 is not released yet, but QDialogButtonBox buttons should now all have icons. Reviewers: #frameworks, #vdg, davidedmundson, ngraham Reviewed By: #vdg, davidedmundson, ngraham Subscribers: ndavis, dhaumann, davidedmundson, #vdg, kde-frameworks-devel, #frameworks Tags: #frameworks Differential Revision: https://phabricator.kde.org/D24415 M +17 -1src/kstyle/kstyle.cpp https://commits.kde.org/frameworkintegration/50593c5618998535cc9f482aa25565c5aeb368ce -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 398973] The window decorations configuration pop-up needs a Defaults icon
https://bugs.kde.org/show_bug.cgi?id=398973 --- Comment #12 from Björn Feber --- (In reply to Björn Feber from comment #11) > I can make a patch that sets it for Qt 5.14 or higher though if you want. Here it is: https://phabricator.kde.org/D24415 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 398973] The window decorations configuration pop-up needs a Defaults icon
https://bugs.kde.org/show_bug.cgi?id=398973 --- Comment #11 from Björn Feber --- (In reply to Björn Feber from comment #10) > Looks like the enum is only in Qt 5.14: > https://github.com/qt/qtbase/blob/9a9bdebb92eda34939c8a7442f06d24ded82b799/ > src/widgets/styles/qstyle.cpp#L2116 I can make a patch that sets it for Qt 5.14 or higher though if you want. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 398973] The window decorations configuration pop-up needs a Defaults icon
https://bugs.kde.org/show_bug.cgi?id=398973 --- Comment #10 from Björn Feber --- Looks like the enum is only in Qt 5.14: https://github.com/qt/qtbase/blob/9a9bdebb92eda34939c8a7442f06d24ded82b799/src/widgets/styles/qstyle.cpp#L2116 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 398973] The window decorations configuration pop-up needs a Defaults icon
https://bugs.kde.org/show_bug.cgi?id=398973 --- Comment #9 from David Edmundson --- >Is your patch included in Qt 5.13 beta2 David? Yes, but we need the matching breeze side to set the icon. That's not merged as it's hard to merge a frameworks patch against non-released code in case it changes later. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 398973] The window decorations configuration pop-up needs a Defaults icon
https://bugs.kde.org/show_bug.cgi?id=398973 --- Comment #8 from Björn Feber --- Made a patch: https://phabricator.kde.org/D20709 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 398973] The window decorations configuration pop-up needs a Defaults icon
https://bugs.kde.org/show_bug.cgi?id=398973 --- Comment #7 from Patrick Silva --- Is your patch included in Qt 5.13 beta2 David? This bug persists here. Operating System: Arch Linux KDE Plasma Version: 5.15.4 KDE Frameworks Version: 5.57.0 Qt Version: 5.13.0 beta2 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 398973] The window decorations configuration pop-up needs a Defaults icon
https://bugs.kde.org/show_bug.cgi?id=398973 Björn Feber changed: What|Removed |Added CC||febe...@gmail.com --- Comment #6 from Björn Feber --- Should we still do the workaround or just close this? -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 398973] The window decorations configuration pop-up needs a Defaults icon
https://bugs.kde.org/show_bug.cgi?id=398973 --- Comment #5 from David Edmundson --- I forgot to push my patch: https://codereview.qt-project.org/254494 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 398973] The window decorations configuration pop-up needs a Defaults icon
https://bugs.kde.org/show_bug.cgi?id=398973 --- Comment #4 from David Edmundson --- *** Bug 404813 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 398973] The window decorations configuration pop-up needs a Defaults icon
https://bugs.kde.org/show_bug.cgi?id=398973 Patrick Silva changed: What|Removed |Added CC||bugsefor...@gmx.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 398973] The window decorations configuration pop-up needs a Defaults icon
https://bugs.kde.org/show_bug.cgi?id=398973 David Edmundson changed: What|Removed |Added Keywords||junior-jobs --- Comment #3 from David Edmundson --- I'll fix properly in Qt. In the meantime, it can be a nice junior job for someone's first patch. kcmwin/kwindecoration/declarative-plugin/previewbridge.cpp ~line 213 get the restore defaults button, set an icon explicitly. Ideally using KStandardGuiItem to get the icon name. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 398973] The window decorations configuration pop-up needs a Defaults icon
https://bugs.kde.org/show_bug.cgi?id=398973 David Edmundson changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0 |1 CC||k...@davidedmundson.co.uk --- Comment #2 from David Edmundson --- Confirmed. It uses QDialogButtonBox correctly, yet the icon for defaults isn't being applied there. Even inside QtDesigner. QDialogButtonBox doesn't set icons for: case QDialogButtonBox::YesToAll: case QDialogButtonBox::NoToAll: case QDialogButtonBox::SaveAll: case QDialogButtonBox::Abort: case QDialogButtonBox::Retry: case QDialogButtonBox::Ignore: case QDialogButtonBox::RestoreDefaults: Doing so means changing QDialogButtonBox then QStyle to add an SP_DialogDefaults enum and then changing kstyle :/ (or I do a shoddy lazy kwin oneliner) -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 398973] The window decorations configuration pop-up needs a Defaults icon
https://bugs.kde.org/show_bug.cgi?id=398973 --- Comment #1 from Andrew Crouthamel --- Another note. The defaults icon currently used in the main window is not the same one used elsewhere. May be best to standardize on the other one. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 398973] The window decorations configuration pop-up needs a Defaults icon
https://bugs.kde.org/show_bug.cgi?id=398973 Nate Graham changed: What|Removed |Added Product|systemsettings |kwin Component|general |general CC||n...@kde.org Assignee|plasma-b...@kde.org |kwin-bugs-n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
