[kwin] [Bug 399822] Option to exclude fullscreen windows from 'dim inactive' desktop effect

2018-10-15 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=399822

Vlad Zagorodniy  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kwi
   ||n/597445e2a677ce0dccfb5c4b5
   ||83cf7ecb2326472
 Status|REPORTED|RESOLVED
   Version Fixed In||5.15.0

--- Comment #2 from Vlad Zagorodniy  ---
Git commit 597445e2a677ce0dccfb5c4b583cf7ecb2326472 by Vlad Zagorodniy.
Committed on 15/10/2018 at 07:39.
Pushed by vladz into branch 'master'.

[effects/diminactive] Add option to exclude fullscreen windows from dimming

Summary:
Such an option would be useful for people that are used to watch videos
in the fullscreen mode.

By default, we still dim fullscreen windows because watching videos in
fullscreen mode is not the only one use-case. One could have a text
editor in fullscreen mode on one screen and Konsole on another screen.
In that case, it would be desired to dim the text editor if the latter
is active. Also, because we don't have stats of how the fullscreen mode
is used by KDE Plasma users.
FIXED-IN: 5.15.0

Test Plan:
* Unchecked the "Fullscreen windows" checkbox;
* Opened Konsole;
* Opened Firefox in the fullscreen mode;
* Pressed Alt+Tab;
* (Firefox stayed bright)

Reviewers: #kwin, #plasma, davidedmundson

Reviewed By: #kwin, #plasma, davidedmundson

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D16216

M  +5-0effects/diminactive/diminactive.cpp
M  +8-0effects/diminactive/diminactive.h
M  +3-0effects/diminactive/diminactive.kcfg
M  +7-0effects/diminactive/diminactive_config.ui

https://commits.kde.org/kwin/597445e2a677ce0dccfb5c4b583cf7ecb2326472

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 399822] Option to exclude fullscreen windows from 'dim inactive' desktop effect

2018-10-14 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=399822

--- Comment #1 from adamska...@gmail.com ---
The best workaround I've found for this in the mean time is to click the 'keep
above' window button before fullscreening the window. Then the window will be
excluded as long as you don't have the 'keep above windows' option ticked in
the 'dim inactive' settings. However this still isn't ideal.

-- 
You are receiving this mail because:
You are watching all bug changes.