[kwin] [Bug 400248] kwin vanishes from shortcut config when changing number of workspaces

2018-10-31 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=400248

--- Comment #7 from Martin Flöser  ---
(In reply to David Edmundson from comment #6)
> There's a rule about new strings in backports.
> 
> This has a new i18n'd string "KWin". 
> I probably could ask for an exception, but the bug seemed quite minor.

We could backport without i18n: KWin is hardly a translatable string.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 400248] kwin vanishes from shortcut config when changing number of workspaces

2018-10-31 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=400248

--- Comment #6 from David Edmundson  ---
There's a rule about new strings in backports.

This has a new i18n'd string "KWin". 
I probably could ask for an exception, but the bug seemed quite minor.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 400248] kwin vanishes from shortcut config when changing number of workspaces

2018-10-31 Thread Ludwig Nussel
https://bugs.kde.org/show_bug.cgi?id=400248

--- Comment #5 from Ludwig Nussel  ---
Thanks for fixing this.
For the record I'd like to note that openSUSE Leap users will not benefit from
the fix in 5.15. It would have to be backported to 5.12 LTS. Not sure what the
criteria for backporting fixes is and this one might not justify it.
Nevertheless I'm mentioning LTS here as I don't know how much the LTS version
is on your radar.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 400248] kwin vanishes from shortcut config when changing number of workspaces

2018-10-30 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=400248

Nate Graham  changed:

   What|Removed |Added

 CC||mue...@gmail.com

--- Comment #4 from Nate Graham  ---
*** Bug 395599 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 400248] kwin vanishes from shortcut config when changing number of workspaces

2018-10-30 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=400248

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.15.0
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 400248] kwin vanishes from shortcut config when changing number of workspaces

2018-10-30 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=400248

David Edmundson  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kwi
   ||n/ce32b031f5a09cb0530a72e76
   ||02490cb05637ac0
 Status|CONFIRMED   |RESOLVED

--- Comment #3 from David Edmundson  ---
Git commit ce32b031f5a09cb0530a72e7602490cb05637ac0 by David Edmundson.
Committed on 30/10/2018 at 21:16.
Pushed by davidedmundson into branch 'master'.

[kcmkwin/kwindesktop] Fix global shortcut's display name for kwin changing

Summary:
KGlobalAcceld stores actions grouped by ID and a single display name.
When an action with a given id changes, the display names change for all
actions in that
group.

The KCM sets the ID to "kwin" but does not explicitly set a display
name. This means it is automatically deduced which will be kcmshell or
systemsettings.

The end result is all kwin shortcuts get renamed in system setting's
global shortcuts UI until kwin is restarted.

This patch explicitly sets the dispay name.
Fixed-in: 5.15.0

Test Plan:
Changed virtual desktops
Checked global shortcut settings still listed kwin as kwin

Reviewers: #kwin, graesslin

Reviewed By: #kwin, graesslin

Subscribers: graesslin, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D16418

M  +2-0kcmkwin/kwindesktop/main.cpp
M  +1-0kcmkwin/kwintabbox/main.cpp

https://commits.kde.org/kwin/ce32b031f5a09cb0530a72e7602490cb05637ac0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 400248] kwin vanishes from shortcut config when changing number of workspaces

2018-10-24 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=400248

--- Comment #2 from David Edmundson  ---
Urgh, I see it.

KCM recreates a shortcut for next desktop. 

KGlobalaccel uses the aboutinfo - which is systemsettings.

Changing the "friendly name" of one shortcut, makes kglobalacceld rename
everything with the same ID.

Everything still works, friendly name gets reset back when kwin next does
shortcuts.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 400248] kwin vanishes from shortcut config when changing number of workspaces

2018-10-24 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=400248

David Edmundson  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1
 CC||k...@davidedmundson.co.uk

--- Comment #1 from David Edmundson  ---
Whoa, so it does.
Mine get replaced by ksmserver entries which is even weirder.

Confirmed.

-- 
You are receiving this mail because:
You are watching all bug changes.