[kwin] [Bug 405934] "Fall apart" effect does not work with standalone KCMs

2019-03-28 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=405934

--- Comment #10 from Vlad Zagorodniy  ---
> No, I don't think it's a race anymore.

I added a qDebug statement in FallApartEffect::slotWindowClosed. No
windowClosed signal is emitted for the kcm.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405934] "Fall apart" effect does not work with standalone KCMs

2019-03-28 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=405934

--- Comment #9 from Martin Flöser  ---
No, I don't think it's a race anymore. Fall apart only works on normal windows,
but the kcm is a dialog. This would be a bug in kcmshell. It doesn't make sense
to be a dialog without a transient parent.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405934] "Fall apart" effect does not work with standalone KCMs

2019-03-28 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=405934

--- Comment #8 from Vlad Zagorodniy  ---
> Can we reopen this issue?

There is a race condition, i.e. what Martin said in comment 1.

The only thing that comes to mind is make loadEffect calls synchronous but I
don't really like it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405934] "Fall apart" effect does not work with standalone KCMs

2019-03-28 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=405934

--- Comment #7 from Patrick Silva  ---
xwininfo: Window id: 0x3800017 "Look and Feel — System Settings Module"

  Absolute upper-left X:  661
  Absolute upper-left Y:  192
  Relative upper-left X:  0
  Relative upper-left Y:  0
  Width: 578
  Height: 575
  Depth: 24
  Visual: 0xda
  Visual Class: TrueColor
  Border width: 0
  Class: InputOutput
  Colormap: 0x3800016 (not installed)
  Bit Gravity State: NorthWestGravity
  Window Gravity State: NorthWestGravity
  Backing Store State: NotUseful
  Save Under State: no
  Map State: IsViewable
  Override Redirect State: no
  Corners:  +661+192  -681+192  -681-313  +661-313
  -geometry 578x575+661+192

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405934] "Fall apart" effect does not work with standalone KCMs

2019-03-28 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=405934

--- Comment #6 from Patrick Silva  ---
_NET_WM_USER_TIME(CARDINAL) = 355307
_NET_WM_ICON_GEOMETRY(CARDINAL) = 579, 1040, 190, 38
_KDE_NET_WM_ACTIVITIES(STRING) = "----"
_NET_WM_ALLOWED_ACTIONS(ATOM) = _NET_WM_ACTION_MOVE, _NET_WM_ACTION_RESIZE,
_NET_WM_ACTION_MINIMIZE, _NET_WM_ACTION_SHADE, _NET_WM_ACTION_MAXIMIZE_VERT,
_NET_WM_ACTION_MAXIMIZE_HORZ, _NET_WM_ACTION_FULLSCREEN,
_NET_WM_ACTION_CHANGE_DESKTOP, _NET_WM_ACTION_CLOSE
_KDE_NET_WM_FRAME_STRUT(CARDINAL) = 4, 4, 29, 4
_NET_FRAME_EXTENTS(CARDINAL) = 4, 4, 29, 4
_NET_WM_DESKTOP(CARDINAL) = 0
WM_STATE(WM_STATE):
window state: Normal
icon window: 0x0
_NET_WM_STATE(ATOM) = 
WM_TRANSIENT_FOR(WINDOW): window id # 0x3800019
_NET_WM_ICON(CARDINAL) =Icon (16 x 16):

















Icon (22 x 22):

   ░░░
 ▒ ▒ ▒
   ▒░▒
░░















░░


Icon (32 x 32):



 ▒░ ▒  ▒
 ░░ ▒  ▒























 ░░░




Icon (48 x 48):




  ░░░░▒▒
 ░▒▒░   ▒▒▒░  ░▒
 ░▒▒░   ▒▒▒░  ░▒
  ░░░░▒▒


































    






Icon (64 x 64):






   ▒▒   ▒▒░  ░▒▒
    ▒▒▒▒
    ▒▒▒▒
   ▒▒   ▒▒░  ░▒▒














































    
    







Icon (128 x 128):








   

   

   

   

  ░▒▒░ 
▒▒▒▒
 ▒▒
▒  ▒
░▒▒░   

   

   

░▒▒░   
   ░
 ▒▒
▒  ▒
  ░▒▒░ 
▒▒   ░▒▒
  

[kwin] [Bug 405934] "Fall apart" effect does not work with standalone KCMs

2019-03-27 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=405934

--- Comment #5 from Martin Flöser  ---
Please provide xprop and xwininfo of a kcm.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405934] "Fall apart" effect does not work with standalone KCMs

2019-03-27 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=405934

--- Comment #4 from Patrick Silva  ---
It work with no kcm.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405934] "Fall apart" effect does not work with standalone KCMs

2019-03-27 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=405934

--- Comment #3 from Martin Flöser  ---
Does it work with no kcm, or only for the steps you provided?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405934] "Fall apart" effect does not work with standalone KCMs

2019-03-27 Thread Patrick Silva
https://bugs.kde.org/show_bug.cgi?id=405934

--- Comment #2 from Patrick Silva  ---
The effect is not working with KCMs only on X11.
On Wayland the effect is triggered when I click "Ok" button of "Desktop
effects" kcm
and it always works with KCMs.
Can we reopen this issue?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405934] "Fall apart" effect does not work with standalone KCMs

2019-03-27 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=405934

Martin Flöser  changed:

   What|Removed |Added

 Resolution|--- |NOT A BUG
 Status|REPORTED|RESOLVED

--- Comment #1 from Martin Flöser  ---
Just ticking the check does not enable. Only if you click ok the effect gets
enabled. In the case of the kcm this is at the same time as closing the window.
So the effect is not yet ready when the window closes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 405934] "Fall apart" effect does not work with standalone KCMs

2019-03-27 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=405934

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.