[kwin] [Bug 423067] Improve keyboard shortcuts for window arrangement

2020-06-19 Thread Claudius Ellsel
https://bugs.kde.org/show_bug.cgi?id=423067

--- Comment #9 from Claudius Ellsel  ---
(In reply to Nate Graham from comment #6)
> Would you like to give that a shot, Claudius? You can see how I implemented
> it originally here:
> https://invent.kde.org/plasma/kwin/-/commit/
> 87578bfc15c281279eec8261c3c7969c2b2163b4
> 
> The actual code changes to placement.cpp are not very complex and wouldn't
> be too hard to extend. The hardest part would be figuring out how to
> minimize and maximize.
> 
> Wanna give it a try?

I had a short look at your implementation before and I guess when investing
some more time I could adapt your solution to also work with the outstanding
shortcuts.

Unfortunately I currently don't have that much time anymore, especially as this
might need compilation of the whole Plasma desktop for testing. Maybe when I
have more time again, but if somebody else wants to implement it that would
also be nice.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 423067] Improve keyboard shortcuts for window arrangement

2020-06-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=423067

--- Comment #8 from Nate Graham  ---
Isn't that already the case for the existing Meta+PgDn shortcut?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 423067] Improve keyboard shortcuts for window arrangement

2020-06-19 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=423067

David Edmundson  changed:

   What|Removed |Added

 CC||k...@davidedmundson.co.uk

--- Comment #7 from David Edmundson  ---
The difference between that and the other quick tiling is in the quick tiling
meta+left+top can be easily undone by pressing a direction again. Minimise
cannot.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 423067] Improve keyboard shortcuts for window arrangement

2020-06-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=423067

--- Comment #6 from Nate Graham  ---
Would you like to give that a shot, Claudius? You can see how I implemented it
originally here:
https://invent.kde.org/plasma/kwin/-/commit/87578bfc15c281279eec8261c3c7969c2b2163b4

The actual code changes to placement.cpp are not very complex and wouldn't be
too hard to extend. The hardest part would be figuring out how to minimize and
maximize.

Wanna give it a try?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 423067] Improve keyboard shortcuts for window arrangement

2020-06-19 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=423067

Nate Graham  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #5 from Nate Graham  ---
Seems doable to add up+up and down+down to the existing timer infrastructure.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 423067] Improve keyboard shortcuts for window arrangement

2020-06-19 Thread Claudius Ellsel
https://bugs.kde.org/show_bug.cgi?id=423067

--- Comment #4 from Claudius Ellsel  ---
I guess those are the only outstanding things. Corner placement has a good
solution now. I was only thinking about making Meta + Up maximize right away
(Windows and GNOME handle it that way), but came to the conclusion that the
current way of moving to top first is probably more consistent (plus there is
the Meta + Page Up shortcut)

For intuitiveness, Meta + Up + Up and Meta + Down + Down would be nice (I'd
still leave the Page Up / Down combinations).

If possible I guess it would also make sense to not have this time based, but
to always maximize a window with Meta + Up that has been tiled to the top with
Meta + Up before. Might be harder to implement, though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 423067] Improve keyboard shortcuts for window arrangement

2020-06-18 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=423067

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

--- Comment #3 from Nate Graham  ---
So now that that KWin change has been merged, is there anything left to do
here? Maybe make Meta+up+up perform a maximize (and presumably Meta+down+down
minimize?)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 423067] Improve keyboard shortcuts for window arrangement

2020-06-17 Thread Claudius Ellsel
https://bugs.kde.org/show_bug.cgi?id=423067

--- Comment #2 from Claudius Ellsel  ---
I just saw https://invent.kde.org/plasma/kwin/-/merge_requests/50

This is improving the situation for moving Windows into corners. I think it is
also better than the implementation of that on Windows.

Regarding minimizing: This is how it works on Windows. I never use it, though,
since I don't like the Window getting unmaximized first before minimizing.
Regarding that you can't get it back again with META + Up: Same for the current
shortcut with META + Page Down. META + Up does not bring the Window back.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 423067] Improve keyboard shortcuts for window arrangement

2020-06-17 Thread Roman Gilg
https://bugs.kde.org/show_bug.cgi?id=423067

Roman Gilg  changed:

   What|Removed |Added

 CC||subd...@gmail.com

--- Comment #1 from Roman Gilg  ---
I like Meta+Up twice to maximize but would rather go with Meta+Up+Left upper
left corner and Meta+Left always left tile.

What would you do with minimize? Meta+Down twice for minimizing is difficult
because you can't press again Meta+Up to get it unminimized.

-- 
You are receiving this mail because:
You are watching all bug changes.