[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 Zamundaaa changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #10 from Zamundaaa --- As ICC profiles are now properly supported, I'm closing this now. You can follow https://invent.kde.org/plasma/kwin/-/issues/11 for support of various protocols etc around color management instead of this -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 Sam James changed: What|Removed |Added CC||s...@gentoo.org -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 --- Comment #9 from Zamundaaa --- Git commit 8d25550c2208b19c3cb2de46364a9bbc9678487e by Xaver Hugl. Committed on 25/10/2023 at 15:34. Pushed by zamundaaa into branch 'master'. backends/drm: support applying icc profiles with color management While applications are still restricted to sRGB, this allows working on sRGB content on displays with a wide color gamut as the whole profile gets applied, instead of just the VCGT. M +1-0autotests/drm/CMakeLists.txt M +2-0src/backends/drm/CMakeLists.txt M +2-1src/backends/drm/drm_egl_cursor_layer.cpp M +3-2src/backends/drm/drm_egl_layer.cpp M +31 -12 src/backends/drm/drm_egl_layer_surface.cpp M +15 -7src/backends/drm/drm_egl_layer_surface.h M +3-5src/backends/drm/drm_output.cpp M +29 -19 src/backends/drm/drm_pipeline.cpp M +5-4src/backends/drm/drm_pipeline.h A +56 -0src/backends/drm/icc.frag A +6-0src/backends/drm/icc.qrc A +59 -0src/backends/drm/icc_core.frag A +207 -0src/backends/drm/icc_shader.cpp [License: GPL(v2.0+)] A +60 -0src/backends/drm/icc_shader.h [License: GPL(v2.0+)] M +8-0src/libkwineffects/glshader.cpp M +1-0src/libkwineffects/glshader.h https://invent.kde.org/plasma/kwin/-/commit/8d25550c2208b19c3cb2de46364a9bbc9678487e -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 soredake changed: What|Removed |Added CC|broaden_acid002@simplelogin | |.com| -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 --- Comment #8 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/4471 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 Patrick Silva changed: What|Removed |Added CC||bugsefor...@gmx.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 k...@trummer.xyz changed: What|Removed |Added CC||k...@trummer.xyz -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 Oliver Klee changed: What|Removed |Added CC||kde...@oliverklee.de -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 Lukas Sommer changed: What|Removed |Added CC||sommer...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 Oleksandr Natalenko changed: What|Removed |Added CC||oleksa...@natalenko.name -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 Jure Repinc changed: What|Removed |Added CC||j...@holodeck1.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 Alex changed: What|Removed |Added CC||alex...@protonmail.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 Bernd Steinhauser changed: What|Removed |Added CC||li...@bernd-steinhauser.de -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 RM changed: What|Removed |Added CC||r...@richardmay.net -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 Lukas Jirkovsky changed: What|Removed |Added CC||l.jirkov...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 tagwer...@innerjoin.org changed: What|Removed |Added CC||tagwer...@innerjoin.org -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 mira...@mirandastreeter.com changed: What|Removed |Added CC||mira...@mirandastreeter.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 Celeste changed: What|Removed |Added CC||coelacant...@outlook.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 Störm Poorun changed: What|Removed |Added CC||i...@stormpoorun.net --- Comment #7 from Störm Poorun --- See also: https://invent.kde.org/plasma/kwin/-/issues/11 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135
--- Comment #6 from tempel.jul...@gmail.com ---
I can confirm that profiles need to be added to global system path
("/usr/share/color/icc/colord" on Arch) to be able to add the ICC profile from
the dropdown menu in color correction KCM. However, this still isn't sufficient
in my case to make it apply the ICC profile's VCGT automatically after log-in.
VCGT correction only gets loaded after log-in when I manually open the color
correction KCM page or when I restart colord via systemd.
--
You are receiving this mail because:
You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 --- Comment #5 from tempel.jul...@gmail.com --- Any news on this? James likely has pinned down what's the issue, sounds to my layman ears like a fix should be doable. This can be a major hassle to users who want to use the Plasma Wayland session and it's unfortunate that the functioning core feature (applying VCGT of an ICC profile) is foiled by something that mostly seems to be a UI issue. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 Bernie Innocenti changed: What|Removed |Added CC||ber...@codewiz.org -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 aux...@gmail.com changed: What|Removed |Added CC||aux...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 James Graham changed: What|Removed |Added CC||james.h.graham@protonmail.c ||om --- Comment #4 from James Graham --- I was setting up colour profiles for my new monitor yesterday and I got it working on Wayland however there are numerous UX issues that made it a lot of work. I can confirm the issues found in the original post (only seeing the default profiles but not being able to import new ones) but after some digging found workarounds that eventually allowed me to get an ICC profile for my monitor loaded. So initially when I tried to load the profile I had I would get an error saying it couldn't copy the profile. After digging and finding the command for the ICC profile importer (colord-kde-icc-importer) and running it in terminal I found that it was trying to copy the file to a location that didn't exist (~/.local/share/icc). By creating this location the importer would work and copy the file to the location. This probably means that the importer needs to be able to create the location if it doesn't already exist. However this doesn't solve the issue as even when I was able to get the importer to work the profile would not appear in the colour corrections tab. It seems this is due to the fact that it doesn't look at the user location for profiles. When I copied the profile manually to /usr/share/color/icc/ it appeared instantly and I was able to apply it. TLDR: It seems everything works its just that all the UI is not hooked up to allow importing profiles to a user location and applying them from there. A workaround for now seems to be to copy the profile to /usr/share/color/icc (or wherever colord is putting it's default profiles on your machine) and then you can use them just fine. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 Mauro Molinari changed: What|Removed |Added CC||mauro...@tiscali.it -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135
tempel.jul...@gmail.com changed:
What|Removed |Added
CC||tempel.jul...@gmail.com
--- Comment #3 from tempel.jul...@gmail.com ---
Not sure if I should post here or report a new bug, but the issue might simply
be that Plasma doesn't start colord.
I've managed to make my ICM profile usable inside Plasma Wayland session by
adding it on Xorg via the color correction KCM and clicking the "install sytem
wide" box. Then I could finally select it from the dropdown list on Wayland and
indeed correction via GPU gamma ramps is applied.
However, when restarting, gamma ramps aren't applied automatically when logging
in. I need to open the color correction KCM page, only then colord process is
started and 1D LUT applied. Alternatively, colord can also be launched
("start") via systemd.
So, I think a lot of trouble might come from the fact that the Wayland (and
also Xorg?) session doesn't start colord reliably. It's a service that can't be
put in autostart ("enable") via systemd, the desktop environment is expected to
start it.
--
You are receiving this mail because:
You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 Vladimir Yerilov changed: What|Removed |Added CC||openmind...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 Mau changed: What|Removed |Added CC||mav...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 soredake changed: What|Removed |Added CC||ndrzj1...@relay.firefox.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 postix changed: What|Removed |Added Keywords||wayland CC||pos...@posteo.eu -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 Jens Ramke changed: What|Removed |Added CC||jens.ra...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 deadite66 changed: What|Removed |Added CC||lee295...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439135] Color management on Wayland
https://bugs.kde.org/show_bug.cgi?id=439135 Nate Graham changed: What|Removed |Added URL||https://gitlab.freedesktop. ||org/wayland/wayland-protoco ||ls/-/merge_requests/14 Severity|normal |wishlist Status|REPORTED|CONFIRMED Ever confirmed|0 |1 CC||n...@kde.org Summary|color management completely |Color management on Wayland |non-functional under| |Wayland, works under X | --- Comment #2 from Nate Graham --- Yeah. Added to https://community.kde.org/Plasma/Wayland_Showstoppers for tracking purposes. -- You are receiving this mail because: You are watching all bug changes.
