[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 Nate Graham changed: What|Removed |Added Version Fixed In||5.26 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 Marco Martin changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/kwin/commit/f432ba7821ce |ma/kwin/commit/31d1f885ce18 |a2302d040c8bfc7e3cb7d954087 |4b54690d44c5fcd4bb7384f6f0a |4 |3 --- Comment #21 from Marco Martin --- Git commit 31d1f885ce184b54690d44c5fcd4bb7384f6f0a3 by Marco Martin. Committed on 07/09/2022 at 10:16. Pushed by mart into branch 'master'. Restore the crossfade effect This enables again the crossfade between the old window picture and the new one in the maximize and morphingpopup effects. It does that with the OffScreenEffect redirect() feature. Related: bug 435423 M +1-0autotests/integration/effects/maximize_animation_test.cpp M +22 -0src/effects.cpp M +1-0src/effects.h M +10 -22 src/effects/blendchanges/blendchanges.cpp M +3-3src/effects/blendchanges/blendchanges.h M +25 -12 src/effects/maximize/package/contents/code/maximize.js M +23 -17 src/effects/morphingpopups/package/contents/code/morphingpopups.js M +2-0src/events.cpp M +2-0src/internalwindow.cpp M +12 -5src/libkwineffects/kwinanimationeffect.cpp M +1-1src/libkwineffects/kwinanimationeffect.h M +29 -0src/libkwineffects/kwineffects.h M +156 -51 src/libkwineffects/kwinoffscreeneffect.cpp M +46 -13 src/libkwineffects/kwinoffscreeneffect.h M +1-0src/window.cpp M +6-0src/window.h M +1-0src/x11window.cpp M +2-0src/xdgshellwindow.cpp https://invent.kde.org/plasma/kwin/commit/31d1f885ce184b54690d44c5fcd4bb7384f6f0a3 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #20 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/2753 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 Gurenko Alex changed: What|Removed |Added CC||agure...@protonmail.com -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 postix changed: What|Removed |Added CC||pos...@posteo.eu -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 Nate Graham changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=435423 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 Nate Graham changed: What|Removed |Added Version Fixed In|5.22.5 | -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 --- Comment #19 from Antonio Orefice --- Hi, i've seen kwin 5.24 is out. Any news on this? -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 Vladimir Yerilov changed: What|Removed |Added CC||openmind...@gmail.com --- Comment #18 from Vladimir Yerilov --- Fall apart for closing windows also doesn't work on 5.23 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 Nate Graham changed: What|Removed |Added Status|REOPENED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 --- Comment #17 from Vlad Zahorodnii --- Yeah, crossfade doesn't work atm, we will try to get it working again in 5.24. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 --- Comment #16 from Antonio Orefice --- f432ba78 | GOOD ebc785167 | BAD I'm unable to build in between, sorry. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 --- Comment #15 from Antonio Orefice --- Maybe related, or not, we lost xfade on window resize too when using the resize effect that scales the window texture. I managed to bring xfade for (un)maximize effect by downgrading kwin,kdecoration and kwayland-server back to 5.22.5. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 Antonio Orefice changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- Version|5.21.90 |5.23.0 --- Comment #14 from Antonio Orefice --- Unfortunately, the bug is back on kwin 5.23 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 --- Comment #13 from Vlad Zahorodnii --- Thanks for reporting. I'll check if it's indeed a kwin bug and comment on the chromium bug report. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 Sok Ann Yap changed: What|Removed |Added CC||sok...@gmail.com --- Comment #12 from Sok Ann Yap --- With commit f432ba78, chromium/chrome/vivaldi would get stuck when trying to enter fullscreen (e.g. by pressing F11) with Ozone/Wayland, as described in https://bugs.chromium.org/p/chromium/issues/detail?id=1248049 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 Nate Graham changed: What|Removed |Added Version Fixed In||5.22.5 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 Vlad Zahorodnii changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Latest Commit||https://invent.kde.org/plas ||ma/kwin/commit/f432ba7821ce ||a2302d040c8bfc7e3cb7d954087 ||4 --- Comment #11 from Vlad Zahorodnii --- Git commit f432ba7821cea2302d040c8bfc7e3cb7d9540874 by Vlad Zahorodnii. Committed on 04/08/2021 at 12:44. Pushed by ngraham into branch 'Plasma/5.22'. Avoid discarding previous pixmap When resizing, the SurfaceItem will discard the current pixmap until a new one is created. If the newly created pixmap is valid, the previous pixmap will be discarded in SurfaceItem::updatePixmap(). However, the previous pixmap can be discarded only if it's unreferenced, in other words, no effect needs the previous pixmap. M +3-1src/surfaceitem.cpp https://invent.kde.org/plasma/kwin/commit/f432ba7821cea2302d040c8bfc7e3cb7d9540874 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 --- Comment #10 from Vlad Zahorodnii --- Right, I still need to figure out what might be causing that bug. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 --- Comment #9 from Antonio Orefice --- Thank YOU very much for your efforts. However, the same commit affects: https://bugs.kde.org/show_bug.cgi?id=438458 which, by gut feeling, it should not be due to previous pixmap. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #8 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/1221 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 --- Comment #7 from Vlad Zahorodnii --- Thanks for bisecting. Cross-fade animation is implemented as a hack so I guess it's not surprising that it got broken... :( -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 --- Comment #6 from Antonio Orefice --- Bisected. The offending commit is: koko@Gozer# git bisect good 47113e09b8a80497463725a795728a34e9db940c is the first bad commit commit 47113e09b8a80497463725a795728a34e9db940c Author: Vlad Zahorodnii Date: Thu Feb 4 11:07:20 2021 +0200 scene: Introduce window items Currently, dealing with sub-surfaces is very difficult due to the scene design being heavily influenced by X11 requirements. The goal of this change is to re-work scene abstractions to make improving the wayland support easier. The Item class is based on the QQuickItem class. My hope is that one day we will be able to transition to QtQuick for painting scene, but in meanwhile it makes more sense to have a minimalistic internal item class. The WindowItem class represents a window. The SurfaceItem class represents the contents of either an X11, or a Wayland, or an internal surface. The DecorationItem and the ShadowItem class represent the server-side deco and drop-shadow, respectively. At the moment, the SurfaceItem is bound to the scene window, but the long term plan is to break that connection so we could re-use the SurfaceItem for things such as software cursors and drag-and-drop additional icons. One of the responsibilities of the Item is to schedule repaints as needed. Ideally, there shouldn't be any addRepaint() calls in the core code. The Item class schedules repaints on geometry updates. In the future, it also has to request an update if its opacity or visibility changes. src/CMakeLists.txt | 8 + src/abstract_client.cpp| 8 +- src/abstract_client.h | 5 +- src/composite.cpp | 20 +- src/decorationitem.cpp | 35 ++ src/decorationitem.h | 36 ++ src/effects.cpp| 3 +- src/events.cpp | 4 - src/internal_client.cpp| 5 +- src/item.cpp | 345 src/item.h | 142 src/plugins/scenes/opengl/scene_opengl.cpp | 280 src/plugins/scenes/opengl/scene_opengl.h | 6 +- src/plugins/scenes/qpainter/scene_qpainter.cpp | 46 ++- src/plugins/scenes/qpainter/scene_qpainter.h | 5 +- src/plugins/scenes/xrender/scene_xrender.cpp | 26 +- src/scene.cpp | 433 - src/scene.h| 181 ++- src/shadowitem.cpp | 46 +++ src/shadowitem.h | 35 ++ src/surfaceitem.cpp| 119 +++ src/surfaceitem.h | 55 src/surfaceitem_internal.cpp | 46 +++ src/surfaceitem_internal.h | 34 ++ src/surfaceitem_wayland.cpp| 151 + src/surfaceitem_wayland.h | 61 src/surfaceitem_x11.cpp| 141 src/surfaceitem_x11.h | 47 +++ src/toplevel.cpp | 251 -- src/toplevel.h | 42 +-- src/unmanaged.cpp | 53 +-- src/unmanaged.h| 4 +- src/windowitem.cpp | 143 src/windowitem.h | 90 + src/x11client.cpp | 31 +- src/x11client.h| 3 +- src/xwaylandclient.cpp | 19 +- 37 files changed, 2015 insertions(+), 944 deletions(-) create mode 100644 src/decorationitem.cpp create mode 100644 src/decorationitem.h create mode 100644 src/item.cpp create mode 100644 src/item.h create mode 100644 src/shadowitem.cpp create mode 100644 src/shadowitem.h create mode 100644 src/surfaceitem.cpp create mode 100644 src/surfaceitem.h create mode 100644 src/surfaceitem_internal.cpp create mode 100644 src/surfaceitem_internal.h create mode 100644 src/surfaceitem_wayland.cpp create mode 100644 src/surfaceitem_wayland.h create mode 100644 src/surfaceitem_x11.cpp create mode 100644 src/surfaceitem_x11.h create mode 100644 src/windowitem.cpp create mode 100644 src/windowitem.h -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 Antonio Orefice changed: What|Removed |Added Version|5.22.3 |5.21.90 --- Comment #5 from Antonio Orefice --- First Broken version seems to be 5.21.90 I've had hard tme trying to bisect offending commit; but unfortunately all i've discovered so far is the following: Working till commit: Feb/15/21 22d386cd xwayland: Improve handling of Xwayland restarts [..] Broken at least from commit: apr/08/21 340c8b59 Update virtual desktops KCM docs Between them there is a black hole due to me having build problems. I've also changed the reported version to 5.21.90, because it worked till 5.21.5 which i've now downgraded to. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 439689] Maximize effect: no more crossfade for window content
https://bugs.kde.org/show_bug.cgi?id=439689 Nate Graham changed: What|Removed |Added Summary|Maximize effect: no more|Maximize effect: no more |Crossfade |crossfade for window ||content Priority|NOR |HI Status|REPORTED|CONFIRMED Keywords||regression Ever confirmed|0 |1 --- Comment #4 from Nate Graham --- Oh you mean for the content, not the window size! Sorry for being dumb. Can reproduce. -- You are receiving this mail because: You are watching all bug changes.
