[kwin] [Bug 442973] Screen corner highlighting effect does not get triggered in some situations

2021-10-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=442973

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.23

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 442973] Screen corner highlighting effect does not get triggered in some situations

2021-10-07 Thread Kishore Gopalakrishnan
https://bugs.kde.org/show_bug.cgi?id=442973

--- Comment #10 from Kishore Gopalakrishnan  ---
(In reply to Andrey from comment #9)
> (In reply to Kishore Gopalakrishnan from comment #6)
> > Your fix leaves a very thin (it looks like one pixel) border on the bottom
> > and right edges of the screen.
> Please re-test with the latest patch, it should work now. Thanks.

It works perfectly now. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 442973] Screen corner highlighting effect does not get triggered in some situations

2021-10-07 Thread Andrey
https://bugs.kde.org/show_bug.cgi?id=442973

--- Comment #9 from Andrey  ---
(In reply to Kishore Gopalakrishnan from comment #6)
> Your fix leaves a very thin (it looks like one pixel) border on the bottom
> and right edges of the screen.
Please re-test with the latest patch, it should work now. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 442973] Screen corner highlighting effect does not get triggered in some situations

2021-10-06 Thread Andrey
https://bugs.kde.org/show_bug.cgi?id=442973

Andrey  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/kwin/commit/c9b41a1682b3 |ma/kwin/commit/bc6aaff63124
   |f49054e177c6daff5cbddef341b |b7925280d2b58b91365f4b55839
   |c   |a

--- Comment #8 from Andrey  ---
Git commit bc6aaff63124b7925280d2b58b91365f4b55839a by Andrey Butirsky.
Committed on 06/10/2021 at 23:00.
Pushed by butirsky into branch 'Plasma/5.23'.

fix wrong approach geometry of screen edge's effect

Edge geometry has width and height, so we need the correction for
approach geometry of bottom and right corners.
The other edges are fixed as well.


(cherry picked from commit c9b41a1682b3f49054e177c6daff5cbddef341bc)

M  +19   -19   src/screenedge.cpp

https://invent.kde.org/plasma/kwin/commit/bc6aaff63124b7925280d2b58b91365f4b55839a

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 442973] Screen corner highlighting effect does not get triggered in some situations

2021-10-06 Thread Andrey
https://bugs.kde.org/show_bug.cgi?id=442973

Andrey  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/plas
   ||ma/kwin/commit/c9b41a1682b3
   ||f49054e177c6daff5cbddef341b
   ||c
 Status|ASSIGNED|RESOLVED

--- Comment #7 from Andrey  ---
Git commit c9b41a1682b3f49054e177c6daff5cbddef341bc by Andrey Butirsky.
Committed on 06/10/2021 at 22:57.
Pushed by butirsky into branch 'master'.

fix wrong approach geometry of screen edge's effect

Edge geometry has width and height, so we need the correction for
approach geometry of bottom and right corners.
The other edges are fixed as well.

M  +19   -19   src/screenedge.cpp

https://invent.kde.org/plasma/kwin/commit/c9b41a1682b3f49054e177c6daff5cbddef341bc

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 442973] Screen corner highlighting effect does not get triggered in some situations

2021-10-06 Thread Kishore Gopalakrishnan
https://bugs.kde.org/show_bug.cgi?id=442973

--- Comment #6 from Kishore Gopalakrishnan  ---
(In reply to Andrey from comment #5)
> Could you build KWin with the fix applied maybe?

Your fix leaves a very thin (it looks like one pixel) border on the bottom and
right edges of the screen. If the mouse is on this border, the highlighting
effect is not triggered. The top-left corner works perfectly as before.

This is on X11.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 442973] Screen corner highlighting effect does not get triggered in some situations

2021-10-05 Thread Andrey
https://bugs.kde.org/show_bug.cgi?id=442973

--- Comment #5 from Andrey  ---
Could you build KWin with the fix applied maybe?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 442973] Screen corner highlighting effect does not get triggered in some situations

2021-10-05 Thread Kishore Gopalakrishnan
https://bugs.kde.org/show_bug.cgi?id=442973

--- Comment #4 from Kishore Gopalakrishnan  ---
(In reply to Andrey from comment #2)
> (In reply to Kishore Gopalakrishnan from comment #0)
> > See the attached image, where there is a thin
> > un-highlighted area on the bottom edge.
> > 
> Hmm, in my case it looks thicker. What is your DPI/Screen resolution?

Resolution is 1920x1080 (physical pixels), and I've set the scaling (in
Settings > Monitors > Display configuration) to 150%. 

> > A. Screen corner highlighting is only triggered consistently on the top-left
> > corner on my machine. The bottom-left corner shows the behaviour described
> > in this bug, while it seems to be impossible to actually get the two corners
> > on the right to be highlighted.
> 
> Could your report that also as it seems another bug?

Sure.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 442973] Screen corner highlighting effect does not get triggered in some situations

2021-10-05 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=442973

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #3 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/kwin/-/merge_requests/1494

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 442973] Screen corner highlighting effect does not get triggered in some situations

2021-10-05 Thread Andrey
https://bugs.kde.org/show_bug.cgi?id=442973

--- Comment #2 from Andrey  ---
(In reply to Kishore Gopalakrishnan from comment #0)
> See the attached image, where there is a thin
> un-highlighted area on the bottom edge.
> 
Hmm, in my case it looks thicker. What is your DPI/Screen resolution?

> A. Screen corner highlighting is only triggered consistently on the top-left
> corner on my machine. The bottom-left corner shows the behaviour described
> in this bug, while it seems to be impossible to actually get the two corners
> on the right to be highlighted.

Could your report that also as it seems another bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 442973] Screen corner highlighting effect does not get triggered in some situations

2021-10-01 Thread Andrey
https://bugs.kde.org/show_bug.cgi?id=442973

Andrey  changed:

   What|Removed |Added

 CC||butir...@gmail.com
 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #1 from Andrey  ---
Happens on Wayland too

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 442973] Screen corner highlighting effect does not get triggered in some situations

2021-09-27 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=442973

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.