[kwin] [Bug 465740] If a floating tile is split nether splits can be deleted

2023-03-17 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=465740

David Edmundson  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
   |ma/kwin/commit/7b46f101e33f |ma/kwin/commit/0be551c6bf56
   |870a6116e04bd940b1113278bd4 |5a939e179e7b0533dfb16516712
   |4   |0

--- Comment #8 from David Edmundson  ---
Git commit 0be551c6bf565a939e179e7b0533dfb165167120 by David Edmundson.
Committed on 17/03/2023 at 16:18.
Pushed by davidedmundson into branch 'Plasma/5.27'.

Simplify tile dismissal

We want floating tiles to be activatable, but also dismiss the effect by
clicking on the whitespace.

The current solution doesn't work as a floating tile that is in turn
split will pull focus from the children meaning those tiles can't be deleted.

Rather than special casing and z-manipulation we can simplify everything
by moving tile dismissal to the root of the effect and appropariately
propagating the event.


(cherry picked from commit 7b46f101e33f870a6116e04bd940b1113278bd44)

M  +3-3src/effects/tileseditor/qml/TileDelegate.qml
M  +5-0src/effects/tileseditor/qml/main.qml

https://invent.kde.org/plasma/kwin/commit/0be551c6bf565a939e179e7b0533dfb165167120

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 465740] If a floating tile is split nether splits can be deleted

2023-03-17 Thread postix
https://bugs.kde.org/show_bug.cgi?id=465740

postix  changed:

   What|Removed |Added

   Version Fixed In|5.27.1  |5.27.4

--- Comment #7 from postix  ---
(In reply to David Edmundson from comment #6)
> Seems it was never added to 5.27

Thanks David!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 465740] If a floating tile is split nether splits can be deleted

2023-03-17 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=465740

David Edmundson  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #6 from David Edmundson  ---
Seems it was never added to 5.27

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 465740] If a floating tile is split nether splits can be deleted

2023-03-17 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=465740

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

--- Comment #5 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/kwin/-/merge_requests/3836

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 465740] If a floating tile is split nether splits can be deleted

2023-03-13 Thread postix
https://bugs.kde.org/show_bug.cgi?id=465740

postix  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 CC||pos...@posteo.eu
 Status|RESOLVED|REOPENED

--- Comment #4 from postix  ---
Still experience this on

Operating System: openSUSE Tumbleweed 20230312
KDE Plasma Version: 5.27.2
KDE Frameworks Version: 5.104.0
Qt Version: 5.15.8
Graphics Platform: Wayland
Graphics Processor: AMD Radeon RX 580 Series

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 465740] If a floating tile is split nether splits can be deleted

2023-02-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=465740

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.27.1

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 465740] If a floating tile is split nether splits can be deleted

2023-02-15 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=465740

David Edmundson  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/plas
   ||ma/kwin/commit/7b46f101e33f
   ||870a6116e04bd940b1113278bd4
   ||4
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from David Edmundson  ---
Git commit 7b46f101e33f870a6116e04bd940b1113278bd44 by David Edmundson.
Committed on 15/02/2023 at 23:05.
Pushed by davidedmundson into branch 'master'.

Simplify tile dismissal

We want floating tiles to be activatable, but also dismiss the effect by
clicking on the whitespace.

The current solution doesn't work as a floating tile that is in turn
split will pull focus from the children meaning those tiles can't be deleted.

Rather than special casing and z-manipulation we can simplify everything
by moving tile dismissal to the root of the effect and appropariately
propagating the event.

M  +3-3src/effects/tileseditor/qml/TileDelegate.qml
M  +5-0src/effects/tileseditor/qml/main.qml

https://invent.kde.org/plasma/kwin/commit/7b46f101e33f870a6116e04bd940b1113278bd44

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 465740] If a floating tile is split nether splits can be deleted

2023-02-15 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=465740

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #2 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/plasma/kwin/-/merge_requests/3606

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 465740] If a floating tile is split nether splits can be deleted

2023-02-15 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=465740

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 465740] If a floating tile is split nether splits can be deleted

2023-02-15 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=465740

David Edmundson  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||k...@davidedmundson.co.uk
 Status|REPORTED|CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 465740] If a floating tile is split nether splits can be deleted

2023-02-14 Thread Nicholas Omann
https://bugs.kde.org/show_bug.cgi?id=465740

--- Comment #1 from Nicholas Omann  ---
Sorry for the quick comment but I have more information from testing. I did
confirm same behavior when vertical is done instead and it's not just delete
all the buttons for the split tile close the layout editor.

-- 
You are receiving this mail because:
You are watching all bug changes.