[kwin] [Bug 477392] In Desktop Effects Magnifier and Zoom are radio buttons

2023-11-23 Thread Justin Zobel
https://bugs.kde.org/show_bug.cgi?id=477392

--- Comment #4 from Justin Zobel  ---
What about the other option. Combine the effects into a Magnification Assistant
effect and then in the Settings the user chooses the style of magnification?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 477392] In Desktop Effects Magnifier and Zoom are radio buttons

2023-11-23 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=477392

David Edmundson  changed:

   What|Removed |Added

 Resolution|--- |INTENTIONAL
 CC||k...@davidedmundson.co.uk
 Status|REPORTED|RESOLVED

--- Comment #3 from David Edmundson  ---
If we had checkboxes we would have reports with:

"These are mutually exclusive effects, you cannot enable two. Therefore,
checkboxes seem like the incorrect choice?".
I do recall it being discussed heavily at the time, it's intentional.

The UX isn't great, but a switch to checkboxes just makes a different problem. 

Ultimately we need to invert this on it's head and present the user with "close
effect" and then a combo box where none is an option. Instead of presenting it
as plugins.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 477392] In Desktop Effects Magnifier and Zoom are radio buttons

2023-11-22 Thread Justin Zobel
https://bugs.kde.org/show_bug.cgi?id=477392

--- Comment #2 from Justin Zobel  ---
To me, radio buttons means one or the other must be used, x or y and one must
be selected.

This is not the case. Checkboxes would suit better and when one is toggled on,
the other is greyed out.

Another option would be to place them in a container that is called something
like Magnification Assistance. This would have a checkbox to say you want it,
then the two options as radio buttons in there to choose the one you prefer.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 477392] In Desktop Effects Magnifier and Zoom are radio buttons

2023-11-22 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=477392

Bug Janitor Service  changed:

   What|Removed |Added

   Keywords||qt6

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 477392] In Desktop Effects Magnifier and Zoom are radio buttons

2023-11-22 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=477392

guimarcalsi...@gmail.com changed:

   What|Removed |Added

Version|git master  |5.27.9
   Keywords|qt6 |

--- Comment #1 from guimarcalsi...@gmail.com ---
Hmm, this is also true on 5.27. Talking about the bug itself, I believe radio
buttons are the right choice because both effects have a similar purpose and
also use the same shortcuts. Enabling both at the same time would cause issues.
Let's see what a developer thinks.

-- 
You are receiving this mail because:
You are watching all bug changes.