[kwin] [Bug 481282] Screen edge effect does not correspond with actual length of edge that can be triggered
https://bugs.kde.org/show_bug.cgi?id=481282 --- Comment #8 from Nate Graham --- My thinking would be that the entire screen edge would both highlight visually and also act as a triggering area. So the visual effect would match the triggering area, not the panel width. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481282] Screen edge effect does not correspond with actual length of edge that can be triggered
https://bugs.kde.org/show_bug.cgi?id=481282 --- Comment #7 from fanzhuyi...@gmail.com --- (In reply to Nate Graham from comment #4) > Sort of mutually exclusive with Bug 464856; maybe we should mark that as > INTENTIONAL? Or change this around to implement that, rather than this? Oh do you mean in that case we would want the edge trigger effect to only highlight the panel, but make the edge trigger everywhere? That would require deeper changes to the current code I think. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481282] Screen edge effect does not correspond with actual length of edge that can be triggered
https://bugs.kde.org/show_bug.cgi?id=481282 --- Comment #6 from Nate Graham --- I see, cool. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481282] Screen edge effect does not correspond with actual length of edge that can be triggered
https://bugs.kde.org/show_bug.cgi?id=481282 --- Comment #5 from fanzhuyi...@gmail.com --- (In reply to Nate Graham from comment #4) > Sort of mutually exclusive with Bug 464856; maybe we should mark that as > INTENTIONAL? Or change this around to implement that, rather than this? I don't think it is mutually exclusive -- we can just make the panel reserve the whole edge and we could solve both issues. The commit fixing this was only about the visual effect code, and making it consistent with what was requested. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481282] Screen edge effect does not correspond with actual length of edge that can be triggered
https://bugs.kde.org/show_bug.cgi?id=481282 Nate Graham changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=464856 --- Comment #4 from Nate Graham --- Sort of mutually exclusive with Bug 464856; maybe we should mark that as INTENTIONAL? Or change this around to implement that, rather than this? -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481282] Screen edge effect does not correspond with actual length of edge that can be triggered
https://bugs.kde.org/show_bug.cgi?id=481282 fanzhuyi...@gmail.com changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/kwin/-/commit/2f4db693e3 |ma/kwin/-/commit/4727a7d956 |c826be7ac76629364630276e65b |318086c4456d8ade3a22803eb8f |c25 |f47 --- Comment #3 from fanzhuyi...@gmail.com --- Git commit 4727a7d956318086c4456d8ade3a22803eb8ff47 by Yifan Zhu. Committed on 13/02/2024 at 15:41. Pushed by fanzhuyifan into branch 'Plasma/6.0'. screenedge: don't reduce approachGeometry Reducing approachGeometry is not needed. During edge creation, createHorizontalEdge and createVerticalEdge already substract the needed cornerOffset, and edges reserved by client windows shouldn't be reduced in geometry. In addition, during display, ScreenEdgeEffect confines the painted area to approachGeometry. So approachGeometry shouldn't be reduced in advance. (cherry picked from commit 2f4db693e3c826be7ac76629364630276e65bc25) M +0-8src/screenedge.cpp https://invent.kde.org/plasma/kwin/-/commit/4727a7d956318086c4456d8ade3a22803eb8ff47 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481282] Screen edge effect does not correspond with actual length of edge that can be triggered
https://bugs.kde.org/show_bug.cgi?id=481282 fanzhuyi...@gmail.com changed: What|Removed |Added Version Fixed In||6.0 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481282] Screen edge effect does not correspond with actual length of edge that can be triggered
https://bugs.kde.org/show_bug.cgi?id=481282 fanzhuyi...@gmail.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/plas ||ma/kwin/-/commit/2f4db693e3 ||c826be7ac76629364630276e65b ||c25 --- Comment #2 from fanzhuyi...@gmail.com --- Git commit 2f4db693e3c826be7ac76629364630276e65bc25 by Yifan Zhu. Committed on 13/02/2024 at 15:30. Pushed by fanzhuyifan into branch 'master'. screenedge: don't reduce approachGeometry Reducing approachGeometry is not needed. During edge creation, createHorizontalEdge and createVerticalEdge already substract the needed cornerOffset, and edges reserved by client windows shouldn't be reduced in geometry. In addition, during display, ScreenEdgeEffect confines the painted area to approachGeometry. So approachGeometry shouldn't be reduced in advance. M +0-8src/screenedge.cpp https://invent.kde.org/plasma/kwin/-/commit/2f4db693e3c826be7ac76629364630276e65bc25 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481282] Screen edge effect does not correspond with actual length of edge that can be triggered
https://bugs.kde.org/show_bug.cgi?id=481282 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 481282] Screen edge effect does not correspond with actual length of edge that can be triggered
https://bugs.kde.org/show_bug.cgi?id=481282 Bug Janitor Service changed: What|Removed |Added Status|REPORTED|ASSIGNED Ever confirmed|0 |1 --- Comment #1 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/5179 -- You are receiving this mail because: You are watching all bug changes.
