[lattedock] [Bug 455567] blur mask behaves strangely for plasma theme default settings
https://bugs.kde.org/show_bug.cgi?id=455567 --- Comment #14 from Michail Vourlakos --- (In reply to doncbugs from comment #12) > Created attachment 150152 [details] > 50% opacity (top) vs 1% opacity (bottom) compared to plasma panel > > I believe this demonstrates that the blur mask is not the problem, but > rather the layer drawn on top that allows the user to raise the opacity of a > translucent panel theme. At 1%, the plasma panel and latte look nearly > identical. However, when the opacity is raised in latte to 50%, it can more > clearly seen. you can not compare plasma panel and latte panels based on opacity setting for the simple reason that panel-background.svg can not be trusted to provide opacity values from 0% to 100%. Latte solves this differently. But if the latte opacity value is set to "Default" then yes if we have different results and we can make them identical and track down what is different to fix it. -- You are receiving this mail because: You are watching all bug changes.
[lattedock] [Bug 455567] blur mask behaves strangely for plasma theme default settings
https://bugs.kde.org/show_bug.cgi?id=455567 --- Comment #13 from Michail Vourlakos --- (In reply to doncbugs from comment #11) > (In reply to Michail Vourlakos from comment #10) > > > you could try to test the new approach in the git version > > Sorry, was struggling to compile it on Neon. Consider adding > libqt5waylandclient5-dev plasma-wayland-protocols and libwayland-dev to the > Neon dependencies. > Installation.md file is totally maintained from community you can send a MR to be approved -- You are receiving this mail because: You are watching all bug changes.
[lattedock] [Bug 455567] blur mask behaves strangely for plasma theme default settings
https://bugs.kde.org/show_bug.cgi?id=455567 --- Comment #12 from doncb...@gmail.com --- Created attachment 150152 --> https://bugs.kde.org/attachment.cgi?id=150152=edit 50% opacity (top) vs 1% opacity (bottom) compared to plasma panel I believe this demonstrates that the blur mask is not the problem, but rather the layer drawn on top that allows the user to raise the opacity of a translucent panel theme. At 1%, the plasma panel and latte look nearly identical. However, when the opacity is raised in latte to 50%, it can more clearly seen. -- You are receiving this mail because: You are watching all bug changes.
[lattedock] [Bug 455567] blur mask behaves strangely for plasma theme default settings
https://bugs.kde.org/show_bug.cgi?id=455567 --- Comment #11 from doncb...@gmail.com --- (In reply to Michail Vourlakos from comment #10) > you could try to test the new approach in the git version Sorry, was struggling to compile it on Neon. Consider adding libqt5waylandclient5-dev plasma-wayland-protocols and libwayland-dev to the Neon dependencies. > it should make things drawn exactly like in plasma panels. I don't know if I am a fan of this. From what I understand, the blur mask calculation adds a 1px margin all around it, regardless of what is specified in the svgs. This ended up causing gaps around the edges of dialogs at 100% scaling. However, testing the latest latte-git, I do not appear to see this issue. The mask appears to only slightly bleed at the corners, which is consistent with plasma. This seems fixed. > my guess is that this issue was because of antialiasing or screen global > scale. I think whatever latte does to allow raising the opacity of a translucent plasma theme to make it opaque is the reason. How the shape of that is calculated could be the reason why it's different. -- You are receiving this mail because: You are watching all bug changes.
[lattedock] [Bug 455567] blur mask behaves strangely for plasma theme default settings
https://bugs.kde.org/show_bug.cgi?id=455567 --- Comment #10 from Michail Vourlakos --- I dont know if this is fixed for you but the facts are the following: 1. your case scenario was when the user used plasma theme default settings (meaning default roundness, default panel shadow etc.) 2. the new approach is the one plasma panel is already doing, when background is directly drawn from the plasma svgs then from the same svgs the mask is calculated you could try to test the new approach in the git version, it should make things drawn exactly like in plasma panels. especially when you compare plasma floating panels with your latte scenario. my guess is that this issue was because of antialiasing or screen global scale. -- You are receiving this mail because: You are watching all bug changes.
[lattedock] [Bug 455567] blur mask behaves strangely for plasma theme default settings
https://bugs.kde.org/show_bug.cgi?id=455567 Michail Vourlakos changed: What|Removed |Added Latest Commit||https://invent.kde.org/plas ||ma/latte-dock/commit/bdf920 ||99bbc6f4262dd05915088c81854 ||50dc799 Status|REPORTED|RESOLVED Resolution|--- |FIXED --- Comment #9 from Michail Vourlakos --- Git commit bdf92099bbc6f4262dd05915088c8185450dc799 by Michail Vourlakos. Committed on 25/06/2022 at 07:00. Pushed by mvourlakos into branch 'master'. plasmatheme:for defaults settings use real mask --follow the new panel background way to access its mask and use it also for both the blur area and mask area when they are really needed. Such a case in only when the user has requested for plasma theme default settings M +29 -40 app/view/effects.cpp M +9-2app/view/effects.h M +7-0containment/package/contents/ui/BindingsExternal.qml M +3-0containment/package/contents/ui/background/MultiLayered.qml https://invent.kde.org/plasma/latte-dock/commit/bdf92099bbc6f4262dd05915088c8185450dc799 -- You are receiving this mail because: You are watching all bug changes.
[lattedock] [Bug 455567] blur mask behaves strangely for plasma theme default settings
https://bugs.kde.org/show_bug.cgi?id=455567 Michail Vourlakos changed: What|Removed |Added Summary|blur mask behaves strangely |blur mask behaves strangely ||for plasma theme default ||settings -- You are receiving this mail because: You are watching all bug changes.
[lattedock] [Bug 455567] blur mask behaves strangely
https://bugs.kde.org/show_bug.cgi?id=455567 --- Comment #8 from doncb...@gmail.com --- with latte 10.6+, and plasma 5.24+, latte layout files can be included in global themes to reproduce full configurations. The layout file is in the theme. -- You are receiving this mail because: You are watching all bug changes.
[lattedock] [Bug 455567] blur mask behaves strangely
https://bugs.kde.org/show_bug.cgi?id=455567 --- Comment #7 from Michail Vourlakos --- (In reply to doncbugs from comment #6) > Created attachment 150075 [details] > the global theme using latte I dont want theme, I want layout creating the screenshots you sent. Right click dock, Layouts, Edit Layouts..., choose your layout, Export Layout -- You are receiving this mail because: You are watching all bug changes.
[lattedock] [Bug 455567] blur mask behaves strangely
https://bugs.kde.org/show_bug.cgi?id=455567 --- Comment #6 from doncb...@gmail.com --- Created attachment 150075 --> https://bugs.kde.org/attachment.cgi?id=150075=edit the global theme using latte -- You are receiving this mail because: You are watching all bug changes.
[lattedock] [Bug 455567] blur mask behaves strangely
https://bugs.kde.org/show_bug.cgi?id=455567 Michail Vourlakos changed: What|Removed |Added Summary|Blur mask behaves strangely |blur mask behaves strangely -- You are receiving this mail because: You are watching all bug changes.
[lattedock] [Bug 455567] Blur mask behaves strangely
https://bugs.kde.org/show_bug.cgi?id=455567 Michail Vourlakos changed: What|Removed |Added Assignee|doncb...@gmail.com |mvourla...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[lattedock] [Bug 455567] Blur mask behaves strangely
https://bugs.kde.org/show_bug.cgi?id=455567 Michail Vourlakos changed: What|Removed |Added CC||mvourla...@gmail.com Status|CONFIRMED |REPORTED Ever confirmed|1 |0 -- You are receiving this mail because: You are watching all bug changes.
[lattedock] [Bug 455567] Blur mask behaves strangely
https://bugs.kde.org/show_bug.cgi?id=455567 Michail Vourlakos changed: What|Removed |Added CC|mvourla...@gmail.com| --- Comment #5 from Michail Vourlakos --- (In reply to doncbugs from comment #4) > Sorry, not the mask. I think whatever draws the panel svg over the blur is > inaccurate. 3. I need also your layout file to reproduce and give you more details about the issue -- You are receiving this mail because: You are watching all bug changes.
[lattedock] [Bug 455567] Blur mask behaves strangely
https://bugs.kde.org/show_bug.cgi?id=455567 Michail Vourlakos changed: What|Removed |Added CC||mvourla...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[lattedock] [Bug 455567] Blur mask behaves strangely
https://bugs.kde.org/show_bug.cgi?id=455567 --- Comment #4 from doncb...@gmail.com --- Sorry, not the mask. I think whatever draws the panel svg over the blur is inaccurate. -- You are receiving this mail because: You are watching all bug changes.
[lattedock] [Bug 455567] Blur mask behaves strangely
https://bugs.kde.org/show_bug.cgi?id=455567 doncb...@gmail.com changed: What|Removed |Added Ever confirmed|0 |1 Resolution|WAITINGFORINFO |--- Assignee|mvourla...@gmail.com|doncb...@gmail.com Status|NEEDSINFO |CONFIRMED --- Comment #3 from doncb...@gmail.com --- Created attachment 150032 --> https://bugs.kde.org/attachment.cgi?id=150032=edit masks changes too much in latte The top image is the mask reduced by .5px. The plasma panel mask decreases a small amount. Latte decreases by a lot. For the record, this bug isn't tied to 5.25, I just never got around to documenting and reporting it. The bug has been around for a while. -- You are receiving this mail because: You are watching all bug changes.
[lattedock] [Bug 455567] Blur mask behaves strangely
https://bugs.kde.org/show_bug.cgi?id=455567 Michail Vourlakos changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution|--- |WAITINGFORINFO --- Comment #2 from Michail Vourlakos --- 1. show me screenshots to understand 2. plasma panels should have the same issue so nothing related to latte -- You are receiving this mail because: You are watching all bug changes.
[lattedock] [Bug 455567] Blur mask behaves strangely
https://bugs.kde.org/show_bug.cgi?id=455567 --- Comment #1 from doncb...@gmail.com --- Created attachment 149905 --> https://bugs.kde.org/attachment.cgi?id=149905=edit the 2 masks being very different -- You are receiving this mail because: You are watching all bug changes.
