[lokalize] [Bug 342615] Add syntax checks to Lokalize

[Simon Depiets]

https://bugs.kde.org/show_bug.cgi?id=342615

Simon Depiets  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/lok
   ||alize/52b94d0b6c41cb7e77ef6
   ||4fcf9b32e403522b436

--- Comment #3 from Simon Depiets  ---
Git commit 52b94d0b6c41cb7e77ef64fcf9b32e403522b436 by Simon Depiets.
Committed on 29/09/2018 at 11:02.
Pushed by sdepiets into branch 'master'.

Add new ways to launch pology on file(s)

Summary:
Pology is a great tool but is not easily accessible from Lokalize currently,
you need to launch a command line or configure a script, which is cumbersome
and complicated in user space. After adding a line by line feature a few weeks
ago, this review focuses on the file level :

- Launch the Pology "-s lokalize" command on file, files or folders from the
Project Overview : this will open problematic messages in different tabs.
{F6285626}
- Launch the Pology "-s lokalize" command from within the file (Ctrl+Alt+P) :
this will filter on problematic messages directly from within the file.
{F6285627}

The next step I see would be displaying pology statistics in the TM file, I'm
open to your ideas for a better integration. I'm also counting on you to pass
the message to your respective communities and update their documentation for
the usage of pology.

As the agreement seems to be that syntax checks shall be handle externally, I
will close the following bugs :
Related: bug 342614, bug 65061, bug 198872
GUI:

Reviewers: #localization, aacid, adrianchavesfernandez, huftis, mlaurent

Reviewed By: mlaurent

Subscribers: mlaurent

Tags: #localization

Differential Revision: https://phabricator.kde.org/D15759

M  +1-1src/CMakeLists.txt
M  +45   -8src/editortab.cpp
M  +7-0src/editortab.h
M  +2-1src/editorui.rc
M  +4-4src/filesearch/filesearchtab.cpp
M  +9-9src/lokalizemainwindow.cpp
M  +4-4src/msgctxtview.cpp
M  +11   -0src/prefs/lokalize.kcfg
M  +7-6src/prefs/prefs.cpp
A  +83   -0src/prefs/prefs_pology.ui
D  +0-64   src/project/prefs_project_pology.ui
M  +0-6src/project/projectlocal.kcfg
M  +53   -5src/project/projecttab.cpp
M  +7-0src/project/projecttab.h
M  +5-5src/tm/tmtab.cpp

https://commits.kde.org/lokalize/52b94d0b6c41cb7e77ef64fcf9b32e403522b436

-- 
You are receiving this mail because:
You are watching all bug changes.

[lokalize] [Bug 342615] Add syntax checks to Lokalize

[Karl Ove Hufthammer]

https://bugs.kde.org/show_bug.cgi?id=342615

Karl Ove Hufthammer  changed:

   What|Removed |Added

 CC||k...@huftis.org

--- Comment #2 from Karl Ove Hufthammer  ---
The first wish is covered by #198872, as Adrián Chaves mentioned.

For the other checks, I think it would be better to integrate support for
Pology’s validation rules
(http://pology.nedohodnik.net/doc/user/en_US/ch-lingo.html#sec-lgrules)
(#342614) and/or the tests in the Translate Toolkit
(http://docs.translatehouse.org/projects/translate-toolkit/en/latest/commands/pofilter_tests.html)
instead of trying to reimplement them in Lokalize directly.

-- 
You are receiving this mail because:
You are watching all bug changes.

[lokalize] [Bug 342615] Add syntax checks to Lokalize

[Adrián Chaves]

https://bugs.kde.org/show_bug.cgi?id=342615

Adrián Chaves (Gallaecio)  changed:

   What|Removed |Added

 CC||adr...@chaves.io

--- Comment #1 from Adrián Chaves (Gallaecio)  ---
Please, open separate reports for separate wishes.

Also, consider whether https://bugs.kde.org/show_bug.cgi?id=198872 would make
your first wish unnecessary.

-- 
You are receiving this mail because:
You are watching all bug changes.