[lokalize] [Bug 398661] The problem with deleting the lines when selecting the source text

2018-10-08 Thread Simon Depiets
https://bugs.kde.org/show_bug.cgi?id=398661

Simon Depiets  changed:

   What|Removed |Added

 CC||en...@softastur.org

--- Comment #7 from Simon Depiets  ---
*** Bug 399518 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[lokalize] [Bug 398661] The problem with deleting the lines when selecting the source text

2018-09-22 Thread Simon Depiets
https://bugs.kde.org/show_bug.cgi?id=398661

Simon Depiets  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/son
   ||net/ffd715bc17b3617ca741fc3
   ||530bba863d0e86757
 Resolution|--- |FIXED

--- Comment #6 from Simon Depiets  ---
Git commit ffd715bc17b3617ca741fc3530bba863d0e86757 by Simon Depiets.
Committed on 22/09/2018 at 08:40.
Pushed by sdepiets into branch 'master'.

Prevent highlighter from erasing selected text

Summary:
https://phabricator.kde.org/D14447 introduced a regression on Lokalize, the
slotRehighlight method is called when text is selected and the
insertText(QString()) call inside that method removes all text selected in the
cursor.

Clearing the selection before doing that call solves this issue.

Reviewers: #framework_syntax_highlighting, mlaurent, dfaure

Reviewed By: dfaure

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D15686

M  +3-0src/ui/highlighter.cpp

https://commits.kde.org/sonnet/ffd715bc17b3617ca741fc3530bba863d0e86757

-- 
You are receiving this mail because:
You are watching all bug changes.

[lokalize] [Bug 398661] The problem with deleting the lines when selecting the source text

2018-09-19 Thread Karl Ove Hufthammer
https://bugs.kde.org/show_bug.cgi?id=398661

Karl Ove Hufthammer  changed:

   What|Removed |Added

 CC||k...@huftis.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[lokalize] [Bug 398661] The problem with deleting the lines when selecting the source text

2018-09-17 Thread Alexander Potashev
https://bugs.kde.org/show_bug.cgi?id=398661

Alexander Potashev  changed:

   What|Removed |Added

 CC||aspotas...@gmail.com

--- Comment #5 from Alexander Potashev  ---
Victor Ryzhykh found the guilty commit in sonnet:
https://cgit.kde.org/sonnet.git/commit/?id=6fef78fa99dda1e00f40e1887d91d65c03e63ac2

His email in Russian:
https://www.mail-archive.com/kde-russian@lists.kde.ru/msg07444.html

-- 
You are receiving this mail because:
You are watching all bug changes.

[lokalize] [Bug 398661] The problem with deleting the lines when selecting the source text

2018-09-17 Thread Simon Depiets
https://bugs.kde.org/show_bug.cgi?id=398661

Simon Depiets  changed:

   What|Removed |Added

 CC||fa...@kde.org

--- Comment #4 from Simon Depiets  ---
It's actually the spellchecker (sonnet) which is removing the text. For now I
can suggest you to disable spellcheck by adding the following two lines in your
.config/lokalizerc
[Editor]
AutoSpellcheck=false

I'm adding David Faure who maybe can help me if he's seen that behavior with
sonnet before.
I suspect the code below replaces the selected text by an empty string (maybe
triggered by the last commit on sonnet ?).

in sonnet/src/ui/highlighter.cpp
void Highlighter::slotRehighlight()
{
...
cursor.insertText(QString());
...
}

-- 
You are receiving this mail because:
You are watching all bug changes.

[lokalize] [Bug 398661] The problem with deleting the lines when selecting the source text

2018-09-16 Thread Simon Depiets
https://bugs.kde.org/show_bug.cgi?id=398661

Simon Depiets  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #3 from Simon Depiets  ---
Confirmed

-- 
You are receiving this mail because:
You are watching all bug changes.

[lokalize] [Bug 398661] The problem with deleting the lines when selecting the source text

2018-09-16 Thread Віталій
https://bugs.kde.org/show_bug.cgi?id=398661

--- Comment #2 from Віталій  ---
(In reply to Simon Depiets from comment #1)
> Hello,
> Can I have more details on your distribution (Manjaro flavor you're using
> for instance)

Ofcourse. I used original Manjaro "Stable Branch" without AUR, 17.1.12, kernel
4.14.69-1-MANJARO, Plasma 5.13.5. 

Screenshot: https://pp.userapi.com/c846218/v846218225/eeba5/Wwx8rj3MzPY.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

[lokalize] [Bug 398661] The problem with deleting the lines when selecting the source text

2018-09-16 Thread Simon Depiets
https://bugs.kde.org/show_bug.cgi?id=398661

Simon Depiets  changed:

   What|Removed |Added

 CC||sdepi...@gmail.com
   Assignee|sha...@ukr.net  |sdepi...@gmail.com

--- Comment #1 from Simon Depiets  ---
Hello,
Can I have more details on your distribution (Manjaro flavor you're using for
instance)

-- 
You are receiving this mail because:
You are watching all bug changes.

[lokalize] [Bug 398661] The problem with deleting the lines when selecting the source text

2018-09-15 Thread Віталій
https://bugs.kde.org/show_bug.cgi?id=398661

Віталій  changed:

   What|Removed |Added

 CC||vitalijrabi...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.