[lokalize] [Bug 477039] lokalize does not open project file using --project
https://bugs.kde.org/show_bug.cgi?id=477039 Albert Astals Cid changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED --- Comment #13 from Albert Astals Cid --- Then you don't have the fix. -- You are receiving this mail because: You are watching all bug changes.
[lokalize] [Bug 477039] lokalize does not open project file using --project
https://bugs.kde.org/show_bug.cgi?id=477039 --- Comment #12 from Freek de Kruijf --- I am using kio-5.114.0-2.2 from the repository of openSUSE Tumbleweed -- You are receiving this mail because: You are watching all bug changes.
[lokalize] [Bug 477039] lokalize does not open project file using --project
https://bugs.kde.org/show_bug.cgi?id=477039 --- Comment #11 from Albert Astals Cid --- Are you using KIO 5.115 or newer? -- You are receiving this mail because: You are watching all bug changes.
[lokalize] [Bug 477039] lokalize does not open project file using --project
https://bugs.kde.org/show_bug.cgi?id=477039 Freek de Kruijf changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #10 from Freek de Kruijf --- The problem still exists. Maybe my setup is the culprit. I have in $HOME a symbolic link to the real location of the folder with the KDE translation folders. -- You are receiving this mail because: You are watching all bug changes.
[lokalize] [Bug 477039] lokalize does not open project file using --project
https://bugs.kde.org/show_bug.cgi?id=477039 Albert Astals Cid changed: What|Removed |Added Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram |eworks/kio/-/commit/01a9c8c |eworks/kio/-/commit/9d69638 |06dec7d748ed964c9e2f2c4091f |746703ee2f59d3d5e986edfb172 |9c125a |960bb6 --- Comment #9 from Albert Astals Cid --- Git commit 9d69638746703ee2f59d3d5e986edfb172960bb6 by Albert Astals Cid, on behalf of Kevin Ottens. Committed on 25/01/2024 at 22:23. Pushed by aacid into branch 'kf5'. KDirModel: Consider invalid roots are local fs If the item set on a node (typically the root node) was null it was implicitly considered local fs. But if the item was not null and the url invalid, it'd be considered network fs. In the context of KDirModel caching of the fs type guessing this would mean we'd wrongly assume the whole tree is network fs even if it's not. That's why we change this to consider non-null items with invalid URLs as local fs. (cherry picked from commit 01a9c8c06dec7d748ed964c9e2f2c4091f9c125a) M +5-1src/widgets/kdirmodel.cpp https://invent.kde.org/frameworks/kio/-/commit/9d69638746703ee2f59d3d5e986edfb172960bb6 -- You are receiving this mail because: You are watching all bug changes.
[lokalize] [Bug 477039] lokalize does not open project file using --project
https://bugs.kde.org/show_bug.cgi?id=477039 Kevin Ottens changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/fram ||eworks/kio/-/commit/01a9c8c ||06dec7d748ed964c9e2f2c4091f ||9c125a Status|ASSIGNED|RESOLVED --- Comment #8 from Kevin Ottens --- Git commit 01a9c8c06dec7d748ed964c9e2f2c4091f9c125a by Kevin Ottens, on behalf of Kevin Ottens. Committed on 23/01/2024 at 09:46. Pushed by ervin into branch 'master'. KDirModel: Consider invalid roots are local fs If the item set on a node (typically the root node) was null it was implicitly considered local fs. But if the item was not null and the url invalid, it'd be considered network fs. In the context of KDirModel caching of the fs type guessing this would mean we'd wrongly assume the whole tree is network fs even if it's not. That's why we change this to consider non-null items with invalid URLs as local fs. M +5-1src/widgets/kdirmodel.cpp https://invent.kde.org/frameworks/kio/-/commit/01a9c8c06dec7d748ed964c9e2f2c4091f9c125a -- You are receiving this mail because: You are watching all bug changes.
[lokalize] [Bug 477039] lokalize does not open project file using --project
https://bugs.kde.org/show_bug.cgi?id=477039 --- Comment #7 from Kevin Ottens --- To be expected, nobody reviewed the patch, feels like it fell through the cracks. I'll poke. -- You are receiving this mail because: You are watching all bug changes.
[lokalize] [Bug 477039] lokalize does not open project file using --project
https://bugs.kde.org/show_bug.cgi?id=477039 --- Comment #6 from Freek de Kruijf --- (In reply to Kevin Ottens from comment #5) > So now we got a MR for KIO which should fix this. Indeed, Lokalize seems to > exploit a corner case in KDirModel's API and the previous patch slightly > changed the behavior for this particular case. > > This being said, it's one of those where I think we can consider the bug > "shared" between KDirModel and Lokalize. It looks like this just uncovered > another bug in Lokalize itself, I suspect it didn't really work as it should > previously and might have cases where it'd break anyway. > > Indeed, the project model wrapping KDirModel in Lokalize seems to use > rowCount but not canFetchMore/fetchMode to decide to go one level down the > hierarchy. This is a bit optimistic in the general case since models (like > KDirModel) can decide to not eagerly fetch children nodes. Also it set an > invalid url as the root of the model which is allowed but I think a bit > fishy. > > I don't know Lokalize enough to feel confident investing the time to look > deeper into how this project model works, I'd probably just unwillingly > break it. Also, the MR in KIO does the job for now... still revisiting the > project model in Lokalize might be worth it at some point. The problem is still present in the current version of openSUSE Tumbleweed with KDE Frameworks Version 5.114.0 -- You are receiving this mail because: You are watching all bug changes.
[lokalize] [Bug 477039] lokalize does not open project file using --project
https://bugs.kde.org/show_bug.cgi?id=477039 Kevin Ottens changed: What|Removed |Added CC||er...@kde.org --- Comment #5 from Kevin Ottens --- So now we got a MR for KIO which should fix this. Indeed, Lokalize seems to exploit a corner case in KDirModel's API and the previous patch slightly changed the behavior for this particular case. This being said, it's one of those where I think we can consider the bug "shared" between KDirModel and Lokalize. It looks like this just uncovered another bug in Lokalize itself, I suspect it didn't really work as it should previously and might have cases where it'd break anyway. Indeed, the project model wrapping KDirModel in Lokalize seems to use rowCount but not canFetchMore/fetchMode to decide to go one level down the hierarchy. This is a bit optimistic in the general case since models (like KDirModel) can decide to not eagerly fetch children nodes. Also it set an invalid url as the root of the model which is allowed but I think a bit fishy. I don't know Lokalize enough to feel confident investing the time to look deeper into how this project model works, I'd probably just unwillingly break it. Also, the MR in KIO does the job for now... still revisiting the project model in Lokalize might be worth it at some point. -- You are receiving this mail because: You are watching all bug changes.
[lokalize] [Bug 477039] lokalize does not open project file using --project
https://bugs.kde.org/show_bug.cgi?id=477039 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #4 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/1508 -- You are receiving this mail because: You are watching all bug changes.
[lokalize] [Bug 477039] lokalize does not open project file using --project
https://bugs.kde.org/show_bug.cgi?id=477039 Albert Astals Cid changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #3 from Albert Astals Cid --- Caused by https://invent.kde.org/frameworks/kio/-/merge_requests/1457 -- You are receiving this mail because: You are watching all bug changes.
[lokalize] [Bug 477039] lokalize does not open project file using --project
https://bugs.kde.org/show_bug.cgi?id=477039 --- Comment #2 from Freek de Kruijf --- (In reply to Albert Astals Cid from comment #1) > Is this the same thing you reported on the mailing list? > > Did you see my follow up there? You wrote on the mailing list: There's no code changes between 23.08.2 and 23.08.3 in lokalize. [Unless maybe you're using Ubunut+snaps] Are you sure it's not a different update that broke this? Maybe KDE Frameworks? Is your distribution powerful enough that lets you back some updates to try to find which update broke it? I am using openSUSE Tumbleweed, currently snapshot 20231126. I went back to snapshot 20231101 and installed the version 23.08.2, which showed the same behavior. Most likely it is a KDE Framework module that causes this problem. So now I am going back to snapshot 20231101 with all the software. Now it works OK. Trying snapshot 20231110. Frameworks 5.111.0. Works OK. Trying snapshot 20231113. Frameworks 5.112. 0. Not OK. -- You are receiving this mail because: You are watching all bug changes.
[lokalize] [Bug 477039] lokalize does not open project file using --project
https://bugs.kde.org/show_bug.cgi?id=477039 --- Comment #1 from Albert Astals Cid --- Is this the same thing you reported on the mailing list? Did you see my follow up there? -- You are receiving this mail because: You are watching all bug changes.
