[okular] [Bug 182994] Allow user to change background colour

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=182994

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 182994] Allow user to change background colour

[Luigi Toscano]

https://bugs.kde.org/show_bug.cgi?id=182994

Luigi Toscano  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/oku |https://commits.kde.org/oku
   |lar/6b5a7c9a1a00dec994cfb03 |lar/1f6e8a4782f6f750daf8937
   |b0abf369539168758   |09e1a043096a837fe

--- Comment #8 from Luigi Toscano  ---
Git commit 1f6e8a4782f6f750daf893709e1a043096a837fe by Luigi Toscano, on behalf
of Albert Freeman.
Committed on 01/10/2017 at 09:31.
Pushed by ltoscano into branch 'master'.

Custom background color

Summary:

Adds an option to the config dialog that enables background color (the color
around the displayed page) to be changed (while by default preserving the Qt
toolkit selection as not to affect existing users).

Reasons for this change:
Accessibility, eye strain, aesthetic reasons, color displayed on monitor can
affect power consumption (how: depends on display technology).
Many people want this change occording to Bugzilla and other sources.

Maintenance: Nearly no additional maintenance:
This is no new subsystem but a trivial feature with no complex code
dependencies, and we are already showing a colour selection dialog and setting
colours in other places in Okular.

{F4257766}

Other less important information:
https://git.reviewboard.kde.org/r/130219/
https://mail.kde.org/pipermail/okular-devel/2017-September/025520.html

Test Plan:
Tested everything, it all works:
Toggled the custom background color, changed custom background color, removed
okular settings file (with: "rm ~/.config/okular*") to verify it uses the usual
qt theme colour by default (where the settings file remembered the custom
color).

Reviewers: #okular, aacid, elvisangelaccio, rkflx, ngraham

Reviewed By: ngraham

Subscribers: aacid, ltoscano, ngraham

Tags: #okular

Differential Revision: https://phabricator.kde.org/D8051

M  +2-2CMakeLists.txt
M  +7-0conf/dlggeneral.cpp
M  +3-0conf/dlggeneral.h
M  +59   -2conf/dlggeneralbase.ui
M  +5-0conf/okular.kcfg
M  +6-1ui/pageview.cpp

https://commits.kde.org/okular/1f6e8a4782f6f750daf893709e1a043096a837fe

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 182994] Allow user to change background colour

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=182994

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/oku
   ||lar/6b5a7c9a1a00dec994cfb03
   ||b0abf369539168758

--- Comment #7 from Nate Graham  ---
Git commit 6b5a7c9a1a00dec994cfb03b0abf369539168758 by Nathaniel Graham.
Committed on 01/10/2017 at 01:45.
Pushed by ngraham into branch 'master'.

Custom background color

Summary:

Adds an option to the config dialog that enables background color (the color
around the displayed page) to be changed (while by default preserving the Qt
toolkit selection as not to affect existing users).

Reasons for this change:
Accessibility, eye strain, aesthetic reasons, color displayed on monitor can
affect power consumption (how: depends on display technology).
Many people want this change occording to Bugzilla and other sources.

Maintenance: Nearly no additional maintenance:
This is no new subsystem but a trivial feature with no complex code
dependencies, and we are already showing a colour selection dialog and setting
colours in other places in Okular.

{F4257766}

Other less important information:
https://git.reviewboard.kde.org/r/130219/
https://mail.kde.org/pipermail/okular-devel/2017-September/025520.html

Test Plan:
Tested everything, it all works:
Toggled the custom background color, changed custom background color, removed
okular settings file (with: "rm ~/.config/okular*") to verify it uses the usual
qt theme colour by default (where the settings file remembered the custom
color).

Reviewers: #okular, aacid, elvisangelaccio, rkflx, ngraham

Reviewed By: ngraham

Subscribers: aacid, ltoscano, ngraham

Tags: #okular

Differential Revision: https://phabricator.kde.org/D8051

M  +2-2CMakeLists.txt
M  +7-0conf/dlggeneral.cpp
M  +3-0conf/dlggeneral.h
M  +59   -2conf/dlggeneralbase.ui
M  +5-0conf/okular.kcfg
M  +6-1ui/pageview.cpp

https://commits.kde.org/okular/6b5a7c9a1a00dec994cfb03b0abf369539168758

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 182994] Allow user to change background colour

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=182994

Nate Graham  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 182994] Allow user to change background colour

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=182994

Nate Graham  changed:

   What|Removed |Added

 CC||lucienl...@yahoo.fr

--- Comment #4 from Nate Graham  ---
*** Bug 307116 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 182994] Allow user to change background colour

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=182994

Nate Graham  changed:

   What|Removed |Added

 CC||f.glo...@ymail.com

--- Comment #5 from Nate Graham  ---
*** Bug 319736 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 182994] Allow user to change background colour

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=182994

Nate Graham  changed:

   What|Removed |Added

 CC||ras...@gmail.com

--- Comment #6 from Nate Graham  ---
*** Bug 372055 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.