[okular] [Bug 370217] [frameworks] Line width of freehand annotation is resolution dependent

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=370217

Bug Janitor Service  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |WORKSFORME
 Status|NEEDSINFO   |RESOLVED

--- Comment #12 from Bug Janitor Service  ---
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 370217] [frameworks] Line width of freehand annotation is resolution dependent

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=370217

--- Comment #11 from Bug Janitor Service  ---
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 370217] [frameworks] Line width of freehand annotation is resolution dependent

[Justin Zobel]

https://bugs.kde.org/show_bug.cgi?id=370217

Justin Zobel  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|CONFIRMED   |NEEDSINFO

--- Comment #10 from Justin Zobel  ---
(In reply to Oliver Sander from comment #9)
> Sorry, but I never found the time to try that.

I'm going to set this bug to needsinfo as you were the only one to report this
issue. If you can, please test it, if not please let us know so we can close
this bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 370217] [frameworks] Line width of freehand annotation is resolution dependent

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=370217

--- Comment #9 from Oliver Sander  ---
Sorry, but I never found the time to try that.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 370217] [frameworks] Line width of freehand annotation is resolution dependent

[Justin Zobel]

https://bugs.kde.org/show_bug.cgi?id=370217

--- Comment #8 from Justin Zobel  ---
(In reply to Oliver Sander from comment #7)
> What I said in comment 5 is still valid.

Sorry I meant have you found a solution to the issue where you could provide a
patch (merge request) to fix it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 370217] [frameworks] Line width of freehand annotation is resolution dependent

[Justin Zobel]

https://bugs.kde.org/show_bug.cgi?id=370217

Justin Zobel  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 370217] [frameworks] Line width of freehand annotation is resolution dependent

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=370217

Oliver Sander  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---

--- Comment #7 from Oliver Sander  ---
What I said in comment 5 is still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 370217] [frameworks] Line width of freehand annotation is resolution dependent

[Justin Zobel]

https://bugs.kde.org/show_bug.cgi?id=370217

Justin Zobel  changed:

   What|Removed |Added

 CC||justin.zo...@gmail.com
 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #6 from Justin Zobel  ---
(In reply to Oliver Sander from comment #5)
> No, as I learned eventually this happens on master, too.
> 
> Actually, on master it is worse, because there, the line-while-you-draw
> always has width 1, irrespective of what the line width settings say. 
> Presumably that's because in annotationtools.cpp:153 it simply says
> 
> const SmoothPath path( points, QPen(m_engineColor, 1) );
> 
> (the '1' is the width).

Oliver were you able to identify and resolve this issue within the code?

Or can you confirm if this issue is still occurring or if this bug report can
be marked as resolved, thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 370217] [frameworks] Line width of freehand annotation is resolution dependent

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=370217

--- Comment #5 from Oliver Sander  ---
No, as I learned eventually this happens on master, too.

Actually, on master it is worse, because there, the line-while-you-draw always
has width 1, irrespective of what the line width settings say.  Presumably
that's because in annotationtools.cpp:153 it simply says

const SmoothPath path( points, QPen(m_engineColor, 1) );

(the '1' is the width).

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 370217] [frameworks] Line width of freehand annotation is resolution dependent

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=370217

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #4 from Albert Astals Cid  ---
is this really frameworks only?

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 370217] [frameworks] Line width of freehand annotation is resolution dependent

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=370217

--- Comment #3 from Oliver Sander  ---
Thanks for the hint.  I played around with this a little.  It seems that the
initial drawing code is buggier than I though.  Simply multiplying the zoom
factor to the pen width doesn't cut it.  You can witness the problems without
patching okular: go to Options -> set up Okular -> Annotations -> freehand -->
edit and set the line width to something large, like 20.  When I do this, the
drawing becomes very blocky, the pen width is not constant anymore, and
sometimes parts of what I draw are not shown.

Any ideas?  I may look some more into this, but currently I am out of ideas.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 370217] [frameworks] Line width of freehand annotation is resolution dependent

[Christoph Feck via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=370217

Christoph Feck  changed:

   What|Removed |Added

 CC||cf...@kde.org

--- Comment #2 from Christoph Feck  ---
On the initial drawing, the tool uses the configured size as a screen pen width
in pixels.
When the annotation is added to the document, it is rendered according to the
zoom level. To fix it, you would have to take into account the current document
zoom in the code you mentioned.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 370217] [frameworks] Line width of freehand annotation is resolution dependent

[Oliver Sander via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=370217

--- Comment #1 from Oliver Sander  ---
Friendly ping :-)

-- 
You are receiving this mail because:
You are watching all bug changes.