[okular] [Bug 373855] Forward search/named_destination feature not working anymore
https://bugs.kde.org/show_bug.cgi?id=373855 Carlos changed: What|Removed |Added CC||carlo...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 373855] Forward search/named_destination feature not working anymore
https://bugs.kde.org/show_bug.cgi?id=373855 Albert Astals Cid changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/oku ||lar/b13fc1d3be97a8e02884aca ||d6495efa8f13975cc Resolution|--- |FIXED --- Comment #7 from Albert Astals Cid --- Git commit b13fc1d3be97a8e02884acad6495efa8f13975cc by Albert Astals Cid. Committed on 15/01/2017 at 23:33. Pushed by aacid into branch 'Applications/16.12'. Readd test for file existance when opening files with # on the path M +28 -2autotests/shelltest.cpp M +3-3shell/okular_main.cpp M +17 -5shell/shellutils.cpp M +4-1shell/shellutils.h https://commits.kde.org/okular/b13fc1d3be97a8e02884acad6495efa8f13975cc -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 373855] Forward search/named_destination feature not working anymore
https://bugs.kde.org/show_bug.cgi?id=373855 Jonathan Verner changed: What|Removed |Added CC||jonathan.ver...@gmail.com --- Comment #6 from Jonathan Verner --- (In reply to Aleix Pol from comment #5) > I looked through the issue, the problem is that there's a safe-guard so that > files containing a # in the name won't be misinterpreted. > > Example. Something like: > "okular /.../my#document.pdf" > Shouldn't be opening the document "my" with a tag "document.pdf". > > I don't know who or why it was done. > > Now you are passing a tag with a dot in it, so the code thinks you're > passing a document named: "mypdf.pdf#page.3" with "3" as an extension. > > Now if you ask me, the weird thing is that we're taking into account the > possibility of a file with a # in its filename, but then I barely have > experience in the area. I haven't seen a file with a hash in its name, but that doesn't mean there aren't any. Some filenames are really weird :-) What about trying to first open the full filename (e.g. 'mypdf.pdf#page.3') and if that fails, try opening 'mypdf.pdf' and finding the dest page.3? -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 373855] Forward search/named_destination feature not working anymore
https://bugs.kde.org/show_bug.cgi?id=373855 Aleix Pol changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever confirmed|0 |1 CC||aleix...@kde.org --- Comment #5 from Aleix Pol --- I looked through the issue, the problem is that there's a safe-guard so that files containing a # in the name won't be misinterpreted. Example. Something like: "okular /.../my#document.pdf" Shouldn't be opening the document "my" with a tag "document.pdf". I don't know who or why it was done. Now you are passing a tag with a dot in it, so the code thinks you're passing a document named: "mypdf.pdf#page.3" with "3" as an extension. Now if you ask me, the weird thing is that we're taking into account the possibility of a file with a # in its filename, but then I barely have experience in the area. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 373855] Forward search/named_destination feature not working anymore
https://bugs.kde.org/show_bug.cgi?id=373855 Stefan L changed: What|Removed |Added CC||stefan.loe...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 373855] Forward search/named_destination feature not working anymore
https://bugs.kde.org/show_bug.cgi?id=373855 --- Comment #4 from imad --- (In reply to Thomas Tuegel from comment #3) > This is due to some changes in the way QUrl::fromUserInput works. As a > workaround, you can prefix the path by `file:' (even for relative paths!) > and get the correct behavior. For example, the following works for me > although the original example does not: > > $ okular file:mypdf.pdf#page.3 If you look at the original comment by Peter, you will see that that absolute paths are used. This works: $ okular "file://#named_destination" When using relative paths, omit the //. This does not work "file://" while this does "file:" The problem is rather that '#' gets replaced with '%23'. i.e. the following does not work: $ okular "file://%23named_destination" -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 373855] Forward search/named_destination feature not working anymore
https://bugs.kde.org/show_bug.cgi?id=373855 Thomas Tuegel changed: What|Removed |Added CC||ttue...@gmail.com --- Comment #3 from Thomas Tuegel --- This is due to some changes in the way QUrl::fromUserInput works. As a workaround, you can prefix the path by `file:' (even for relative paths!) and get the correct behavior. For example, the following works for me although the original example does not: $ okular file:mypdf.pdf#page.3 -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 373855] Forward search/named_destination feature not working anymore
https://bugs.kde.org/show_bug.cgi?id=373855 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 373855] Forward search/named_destination feature not working anymore
https://bugs.kde.org/show_bug.cgi?id=373855 imad changed: What|Removed |Added CC||imadudd...@hotmail.com --- Comment #2 from imad --- Can confirm bug on my Arch Linux setup as well. Okular version 1.0.0. (KDE Frameworks 5.29.0, Qt 5.7.1) -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 373855] Forward search/named_destination feature not working anymore
https://bugs.kde.org/show_bug.cgi?id=373855 Pavel Zorin changed: What|Removed |Added CC||pavel.zo...@online.de --- Comment #1 from Pavel Zorin --- I can confirm this bug on KDE Neon (user edition), okular package version 4:16.12.0-0neon+16.04+build1 -- You are receiving this mail because: You are watching all bug changes.
