[okular] [Bug 374079] Context menu for annotations

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=374079

--- Comment #7 from Oliver Sander  ---
Thanks for the fix.  Will this also go into the master branch?

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 374079] Context menu for annotations

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=374079

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
  Latest Commit||https://commits.kde.org/oku
   ||lar/e833b3ce6504903df966cd2
   ||f0662c8d180b650ff

--- Comment #6 from Albert Astals Cid  ---
Git commit e833b3ce6504903df966cd2f0662c8d180b650ff by Albert Astals Cid.
Committed on 28/12/2016 at 16:05.
Pushed by aacid into branch 'Applications/16.12'.

Fix menu titles not showing up

QMenu title/section are optional to draw from the style side but we have
crucial information in them
so reuse old KMenu code to create a fake action that behaves as title

I'll see if KF5 wants to accept this as contribution later

M  +1-0CMakeLists.txt
M  +3-2part.cpp
M  +3-2ui/annotationpopup.cpp
A  +65   -0ui/okmenutitle.cpp [License: LGPL (v2)]
A  +31   -0ui/okmenutitle.h [License: LGPL (v2)]
M  +3-2ui/pageview.cpp

https://commits.kde.org/okular/e833b3ce6504903df966cd2f0662c8d180b650ff

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 374079] Context menu for annotations

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=374079

--- Comment #5 from Oliver Sander  ---
Created attachment 103024
  --> https://bugs.kde.org/attachment.cgi?id=103024=edit
Screenshot showing the context menu in okular from current git master

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 374079] Context menu for annotations

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=374079

--- Comment #4 from Oliver Sander  ---
Created attachment 103023
  --> https://bugs.kde.org/attachment.cgi?id=103023=edit
Screenshot showing the context menu in okular 0.26.1

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 374079] Context menu for annotations

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=374079

--- Comment #3 from Oliver Sander  ---
Confirmed.  This is a regression.  See the attached screenshots of two
overlapping annotations once with okular 0.26.1 from Debian testing, and once
with the current Okular git master.  You see that the former shows the
annotation type ("Hervorhebung", i.e., "Highlight").

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 374079] Context menu for annotations

[BasioMeusPuga]

https://bugs.kde.org/show_bug.cgi?id=374079

--- Comment #2 from BasioMeusPuga  ---
Yes. This is a PDF textbook:

https://mega.nz/#!44M0kTxL!dOijXerRTxBiB09Q8YSW6Nbyi34IGncFO_CKmFLjFDQ

I understandably go a little overboard with the 'paint everything' approach,
but I'd posit it's almost essential for organization within technical texts
that need to be revisited repeatedly. Don't even get me started on what my
Harrison looks like.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 374079] Context menu for annotations

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=374079

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #1 from Oliver Sander  ---
Can you share a pdf file with such overlapping annotations?

-- 
You are receiving this mail because:
You are watching all bug changes.