[okular] [Bug 436990] Interactive PDF Forms with field validation cannot be filled due to repeating error window

2021-06-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=436990

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||21.04.2

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 436990] Interactive PDF Forms with field validation cannot be filled due to repeating error window

2021-06-04 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=436990

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED
  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/okular/commit/37aacc7f |hics/okular/commit/e457ceb7
   |8bba67e0ec6b4854d901fe9dab4 |3146790c5d4a9914182433ab400
   |a8efd   |2815e

--- Comment #5 from Albert Astals Cid  ---
Git commit e457ceb73146790c5d4a9914182433ab4002815e by Albert Astals Cid.
Committed on 04/06/2021 at 21:17.
Pushed by aacid into branch 'release/21.04'.

FormLineEdit: Don't run focusin action when gaining focus because of window
management

Adobe Reader doesn't do it, and with reason, because otherwise we end up
with:
 * Run focus in script
 * script shows alert()
 * field loses focus and gains it again once the alert() is closed
 * infinite loop

M  +6-2part/formwidgets.cpp

https://invent.kde.org/graphics/okular/commit/e457ceb73146790c5d4a9914182433ab4002815e

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 436990] Interactive PDF Forms with field validation cannot be filled due to repeating error window

2021-05-24 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=436990

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #4 from Albert Astals Cid  ---
I made a mistake and push it to the wrong branch, fix has still not landed

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 436990] Interactive PDF Forms with field validation cannot be filled due to repeating error window

2021-05-24 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=436990

Albert Astals Cid  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/okular/commit/37aacc7f
   ||8bba67e0ec6b4854d901fe9dab4
   ||a8efd
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #3 from Albert Astals Cid  ---
Git commit 37aacc7f8bba67e0ec6b4854d901fe9dab4a8efd by Albert Astals Cid.
Committed on 24/05/2021 at 22:26.
Pushed by aacid into branch 'okular_focus_actions'.

FormLineEdit: Don't run focusin action when gaining focus because of window
management

Adobe Reader doesn't do it, and with reason, because otherwise we end up
with:
 * Run focus in script
 * script shows alert()
 * field loses focus and gains it again once the alert() is closed
 * infinite loop

M  +6-2part/formwidgets.cpp

https://invent.kde.org/graphics/okular/commit/37aacc7f8bba67e0ec6b4854d901fe9dab4a8efd

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 436990] Interactive PDF Forms with field validation cannot be filled due to repeating error window

2021-05-13 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=436990

--- Comment #2 from Albert Astals Cid  ---
It's not errors, it's messagebox popped up by the Javascript of the document,
could very well be anything, so no they can't appear anyway else.

I have not checked the code at all, but my guess the problem here is, that the
file does:

 If the field has an won focus -> show messagebox saying what the field
contents has to be

But that makes it lose the focus to the messagebox and win it again, so 

 If the field has an won focus -> show messagebox saying what the field
contents has to be


etc. etc.

Would need time to check that is indeed the problem and make it realize that if
it's winning the focus and had it and was lost because a mesagebox was shown,
there's no need to show the messagebox again.

And also check what Adobe Reader does with the file, because it's super easy to
infinite loop firefox too

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 436990] Interactive PDF Forms with field validation cannot be filled due to repeating error window

2021-05-13 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=436990

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 436990] Interactive PDF Forms with field validation cannot be filled due to repeating error window

2021-05-12 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=436990

--- Comment #1 from David Hurka  ---
Would a good fix be that the error message appears as hovering text field, or
as a red background, instead of a blocking dialog?

There are websites where form fields are shown as “invalid” instead of
“incomplete” when you haven’t yet typed anything. I guess the same happens
here.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 436990] Interactive PDF Forms with field validation cannot be filled due to repeating error window

2021-05-12 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=436990

Albert Astals Cid  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||aa...@kde.org
 Status|REPORTED|CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.