[okular] [Bug 438923] PDF contents tab doesn't respect empty page label number style

2021-07-28 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=438923

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 438923] PDF contents tab doesn't respect empty page label number style

2021-06-20 Thread Dani Pozo
https://bugs.kde.org/show_bug.cgi?id=438923

--- Comment #8 from Dani Pozo  ---
(In reply to Oliver Sander from comment #7)
> I wouldn't mind seeing both, the number and the page label (empty if there
> is no label).

They are different things after all, so this can make the most sense in my
opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 438923] PDF contents tab doesn't respect empty page label number style

2021-06-20 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=438923

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #7 from Oliver Sander  ---
I wouldn't mind seeing both, the number and the page label (empty if there is
no label).  If there is a general consensus against showing the page number,
then showing nothing at all if there is no page label is okay for me, too.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 438923] PDF contents tab doesn't respect empty page label number style

2021-06-20 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=438923

--- Comment #6 from Albert Astals Cid  ---
yeah i guess we can show nothing

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 438923] PDF contents tab doesn't respect empty page label number style

2021-06-20 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=438923

--- Comment #5 from David Hurka  ---
The page number is relevant, because it is also needed for “Print pages from
... to ...”. But since the page widget in the main toolbar also shows the page
number, the Contents panel probably may show nothing as well.

I am not sure what is best. Showing the page label even when it is defined to
be empty (i. e. show nothing) may be the best option, and the one most
straightforward and least confusing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 438923] PDF contents tab doesn't respect empty page label number style

2021-06-19 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=438923

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 438923] PDF contents tab doesn't respect empty page label number style

2021-06-19 Thread Dani Pozo
https://bugs.kde.org/show_bug.cgi?id=438923

--- Comment #4 from Dani Pozo  ---
(In reply to David Hurka from comment #2)
> The Contents view needs to show something as page number. I guess, since the
> PDF does not provide a page label, it shows the number of the page.

Does it need to show something always? As far as I can understand, for the case
in which the book page doesn't have a number, but it has a bookmark entry,
you can leave the page label style empty. Evince, for instance, shows no number
or letter in the tab analogous to the Contents tab.

> Should we somehow deemphasize the number, to avoid confusion? If the PDF
> provides page labels for not all pages. The number could then be in
> brackets: (1) or in a desaturated font?

As I'm not sure whether this Evince behaviour would break some other PDFs,
this could be an option too. I have been reading a bit on the PDF standard
(http://www.adobe.com/content/dam/Adobe/en/devnet/pdf/pdfs/PDF32000_2008.pdf),
and from Table 159 (page 375) I understand that the labels should be empty in
this case. This is an opinion supported only from looking briefly at the
standard, may easily be wrong.

(In reply to Albert Astals Cid from comment #1)
> Can you attach a PDF file in which you expect this to happen?

Sure, please see the attached PDF. The first two pages have no page label
style.

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 438923] PDF contents tab doesn't respect empty page label number style

2021-06-19 Thread Dani Pozo
https://bugs.kde.org/show_bug.cgi?id=438923

--- Comment #3 from Dani Pozo  ---
Created attachment 139526
  --> https://bugs.kde.org/attachment.cgi?id=139526=edit
Example PDF

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 438923] PDF contents tab doesn't respect empty page label number style

2021-06-19 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=438923

--- Comment #2 from David Hurka  ---
The Contents view needs to show something as page number. I guess, since the
PDF does not provide a page label, it shows the number of the page.

Should we somehow deemphasize the number, to avoid confusion? If the PDF
provides page labels for not all pages. The number could then be in brackets:
(1) or in a desaturated font?

-- 
You are receiving this mail because:
You are watching all bug changes.

[okular] [Bug 438923] PDF contents tab doesn't respect empty page label number style

2021-06-19 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=438923

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org
 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Albert Astals Cid  ---
Can you attach a PDF file in which you expect this to happen?

-- 
You are receiving this mail because:
You are watching all bug changes.