[plasma-browser-integration] [Bug 414512] Firefox KDE Plasma Integration sets window.Audio.prototype to undefined
https://bugs.kde.org/show_bug.cgi?id=414512 si...@brulhart.me changed: What|Removed |Added CC||si...@brulhart.me -- You are receiving this mail because: You are watching all bug changes.
[plasma-browser-integration] [Bug 414512] Firefox KDE Plasma Integration sets window.Audio.prototype to undefined
https://bugs.kde.org/show_bug.cgi?id=414512 Kai Uwe Broulik changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://commits.kde.org/pla ||sma-browser-integration/084 ||68773f1fefecbe27bab89e64f8d ||f80254315a Status|CONFIRMED |RESOLVED --- Comment #9 from Kai Uwe Broulik --- Git commit 08468773f1fefecbe27bab89e64f8df80254315a by Kai Uwe Broulik. Committed on 14/04/2020 at 09:19. Pushed by broulik into branch 'master'. Restore old Audio prototype after exportFunction exportFunction doesn't carry over a prototype, nor can I assign a non-function with it afterwards. However, Firefox exports the "unsafe" stuff in wrappedJSObject, so I can actually get the original untrusted prototype, exportFunction my new function, and then set it back. I can't just use the prototype in content-script since it wouldn't be accessible from the webpage. Interestingly enough, I have to use window.Audio rather than window.wrappedJSObject.Audio for creating the player as the wrapped one doesn't appear to be working when used from this function. This one then still passes onto the website like normal and plays sound. Differential Revision: https://phabricator.kde.org/D28706 M +13 -3extension/content-script.js https://commits.kde.org/plasma-browser-integration/08468773f1fefecbe27bab89e64f8df80254315a -- You are receiving this mail because: You are watching all bug changes.
[plasma-browser-integration] [Bug 414512] Firefox KDE Plasma Integration sets window.Audio.prototype to undefined
https://bugs.kde.org/show_bug.cgi?id=414512 --- Comment #8 from Kai Uwe Broulik --- Pretty much just clone https://cgit.kde.org/plasma-browser-integration.git/, apply the patch (we tried a different approach from the one I linked here but it didn't work out). Then in Firefox go to about:debugging → "this firefox" and "temporarily load" the extension folder in the repo you just cloned. There's some more guides on our wiki: https://community.kde.org/Plasma/Browser_Integration -- You are receiving this mail because: You are watching all bug changes.
[plasma-browser-integration] [Bug 414512] Firefox KDE Plasma Integration sets window.Audio.prototype to undefined
https://bugs.kde.org/show_bug.cgi?id=414512 --- Comment #7 from Benjamin Xiao --- Thanks for working on this! What's the easiest way to test this out? Is there a prebuilt package somewhere or can I get the old extension and replace that file in there? -- You are receiving this mail because: You are watching all bug changes.
[plasma-browser-integration] [Bug 414512] Firefox KDE Plasma Integration sets window.Audio.prototype to undefined
https://bugs.kde.org/show_bug.cgi?id=414512 --- Comment #6 from Kai Uwe Broulik --- At last I found a solution for the problem! If you could try https://phabricator.kde.org/D28706 this would be highly appreciated -- You are receiving this mail because: You are watching all bug changes.
[plasma-browser-integration] [Bug 414512] Firefox KDE Plasma Integration sets window.Audio.prototype to undefined
https://bugs.kde.org/show_bug.cgi?id=414512 Kai Uwe Broulik changed: What|Removed |Added Priority|NOR |HI -- You are receiving this mail because: You are watching all bug changes.
[plasma-browser-integration] [Bug 414512] Firefox KDE Plasma Integration sets window.Audio.prototype to undefined
https://bugs.kde.org/show_bug.cgi?id=414512 Kai Uwe Broulik changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #5 from Kai Uwe Broulik --- The issue is that with Firefox I can't manipulate the JS environment directly, so I have to override window Audio from what I can tell. In Chrome playcanvas works because here I can manipulate the prototype. Thanks for showing me a website that actually excerts the bug in Firefox :) This should make fixing it a lot easier. -- You are receiving this mail because: You are watching all bug changes.
[plasma-browser-integration] [Bug 414512] Firefox KDE Plasma Integration sets window.Audio.prototype to undefined
https://bugs.kde.org/show_bug.cgi?id=414512 Benjamin Xiao changed: What|Removed |Added CC||ben.r.x...@gmail.com --- Comment #4 from Benjamin Xiao --- I believe this is also what's causing PlayCanvas WebGL apps to fail in Firefox. Here are some test cases: https://robostorm.io/ https://playcanv.as/p/44MRmJRU/ Disabling the addon makes the above sites work. -- You are receiving this mail because: You are watching all bug changes.
[plasma-browser-integration] [Bug 414512] Firefox KDE Plasma Integration sets window.Audio.prototype to undefined
https://bugs.kde.org/show_bug.cgi?id=414512 --- Comment #3 from Craig Leinoff --- Hello! Thanks for the quick reply and I apologize for my own delay. I am not 100% positive -- but am pretty confident that this (the solution you identified) might actually be all you need to do! :) -- You are receiving this mail because: You are watching all bug changes.
[plasma-browser-integration] [Bug 414512] Firefox KDE Plasma Integration sets window.Audio.prototype to undefined
https://bugs.kde.org/show_bug.cgi?id=414512 --- Comment #2 from Kai Uwe Broulik --- Would a "window.Audio.prototype = oldAudio.prototype" call fix this? -- You are receiving this mail because: You are watching all bug changes.
[plasma-browser-integration] [Bug 414512] Firefox KDE Plasma Integration sets window.Audio.prototype to undefined
https://bugs.kde.org/show_bug.cgi?id=414512 --- Comment #1 from Kai Uwe Broulik --- Can you check wheter this [1] helps? What kind of issues does this cause? If you know how to fix it I'd be grateful, I am somewhat lost in this HTML JavaScript mess. [1] https://cgit.kde.org/plasma-browser-integration.git/commit/?id=c1d7ea7346074e1912d56b9aed8d5ec47957e3a2 -- You are receiving this mail because: You are watching all bug changes.
