[plasma-nm] [Bug 363917] [RFE] [Openconnect] Add Juniper support for OpenConnect VPN

[Jonathan Riddell]

https://bugs.kde.org/show_bug.cgi?id=363917

--- Comment #16 from Jonathan Riddell  ---
yay build works again

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 363917] [RFE] [Openconnect] Add Juniper support for OpenConnect VPN

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=363917

--- Comment #15 from Christoph Feck  ---
(ignore last comment, I was reading an outdated conversation)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 363917] [RFE] [Openconnect] Add Juniper support for OpenConnect VPN

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=363917

--- Comment #14 from Christoph Feck  ---
If this means the dependencies were rised, then this needs to be reverted in
5.8 branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 363917] [RFE] [Openconnect] Add Juniper support for OpenConnect VPN

[Jan Grulich]

https://bugs.kde.org/show_bug.cgi?id=363917

--- Comment #13 from Jan Grulich  ---
Fixed, this should not have been pushed to Plasma/5.8 branch. I didn't realize
that Juniper support is only in master.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 363917] [RFE] [Openconnect] Add Juniper support for OpenConnect VPN

[thev00d00]

https://bugs.kde.org/show_bug.cgi?id=363917

--- Comment #12 from Ian Whyman (thev00d00)  ---
You need NetworkManager-openconnect-1.2.4 for the juniper stuff to work.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 363917] [RFE] [Openconnect] Add Juniper support for OpenConnect VPN

[Jonathan Riddell]

https://bugs.kde.org/show_bug.cgi?id=363917

Jonathan Riddell  changed:

   What|Removed |Added

 CC||j...@jriddell.org

--- Comment #11 from Jonathan Riddell  ---
This creates a build failure in KDE neon
http://build.neon.kde.org/job/xenial_stable_plasma_plasma-nm_bin_amd64/56/console
vpn/openconnect/openconnectauth.cpp:196:18: error:
‘NM_OPENCONNECT_KEY_PROTOCOL’ was not declared in this scope
  if (!dataMap[NM_OPENCONNECT_KEY_PROTOCOL].isEmpty()) {

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 363917] [RFE] [Openconnect] Add Juniper support for OpenConnect VPN

[Jan Grulich]

https://bugs.kde.org/show_bug.cgi?id=363917

Jan Grulich  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/pla
   |sma-nm/e12f39760596efc697f8 |sma-nm/a51e9c5c2a2c32ef8d2f
   |4aa486c260cb5825914e|354af33532cbc35bfa9e

--- Comment #10 from Jan Grulich  ---
Git commit a51e9c5c2a2c32ef8d2f354af33532cbc35bfa9e by Jan Grulich, on behalf
of Ian Whyman.
Committed on 05/12/2016 at 09:02.
Pushed by grulich into branch 'Plasma/5.8'.

Pass protocol type to openconnect

M  +4-0vpn/openconnect/openconnectauth.cpp

https://commits.kde.org/plasma-nm/a51e9c5c2a2c32ef8d2f354af33532cbc35bfa9e

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 363917] [RFE] [Openconnect] Add Juniper support for OpenConnect VPN

[Jan Grulich]

https://bugs.kde.org/show_bug.cgi?id=363917

Jan Grulich  changed:

   What|Removed |Added

  Latest Commit|http://commits.kde.org/plas |https://commits.kde.org/pla
   |ma-nm/05a80ff9311c0880bb08f |sma-nm/e12f39760596efc697f8
   |e7a00dcda3d1f34e864 |4aa486c260cb5825914e

--- Comment #9 from Jan Grulich  ---
Git commit e12f39760596efc697f84aa486c260cb5825914e by Jan Grulich, on behalf
of Ian Whyman.
Committed on 05/12/2016 at 09:00.
Pushed by grulich into branch 'master'.

Pass protocol type to openconnect

M  +4-0vpn/openconnect/openconnectauth.cpp

https://commits.kde.org/plasma-nm/e12f39760596efc697f84aa486c260cb5825914e

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 363917] [RFE] [Openconnect] Add Juniper support for OpenConnect VPN

[thev00d00]

https://bugs.kde.org/show_bug.cgi?id=363917

--- Comment #8 from Ian Whyman (thev00d00)  ---
(In reply to Jan Grulich from comment #7)
> Looks good, can you please push it? If you don't have access I can do it
> instead of you. Also don't forget to mention this bug in the commit message.

I dont have commit access so please push this for me, feel free to edit the
commit message as you see fit.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 363917] [RFE] [Openconnect] Add Juniper support for OpenConnect VPN

[Jan Grulich]

https://bugs.kde.org/show_bug.cgi?id=363917

--- Comment #7 from Jan Grulich  ---
Looks good, can you please push it? If you don't have access I can do it
instead of you. Also don't forget to mention this bug in the commit message.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 363917] [RFE] [Openconnect] Add Juniper support for OpenConnect VPN

[thev00d00]

https://bugs.kde.org/show_bug.cgi?id=363917

--- Comment #6 from Ian Whyman (thev00d00)  ---
So I was trying to get this working today and it was complaining:

> XML response has no "auth" node

I remembered this from the CLI when I forgot to pass the --juniper argument, so
I assumed the code was doing the same.

Please see attached patch to pass through the protocol information from NM to
OpenConnect, I've successfully used this patch to connect to a juniper
endpoint.

Apologies for my terrible C++.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 363917] [RFE] [Openconnect] Add Juniper support for OpenConnect VPN

[thev00d00]

https://bugs.kde.org/show_bug.cgi?id=363917

Ian Whyman (thev00d00)  changed:

   What|Removed |Added

 CC||thev00...@gentoo.org

--- Comment #5 from Ian Whyman (thev00d00)  ---
Created attachment 102579
  --> https://bugs.kde.org/attachment.cgi?id=102579=edit
0001-Pass-protocol-type-to-Openconnect.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 363917] [RFE] [Openconnect] Add Juniper support for OpenConnect VPN

[Jan Grulich via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363917

Jan Grulich  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/plas
   ||ma-nm/05a80ff9311c0880bb08f
   ||e7a00dcda3d1f34e864

--- Comment #4 from Jan Grulich  ---
Git commit 05a80ff9311c0880bb08fe7a00dcda3d1f34e864 by Jan Grulich.
Committed on 05/10/2016 at 19:14.
Pushed by grulich into branch 'master'.

Add support for Juniper Openconnect VPN

REVIEW:129105

M  +12   -1editor/connectioneditor.cpp
M  +1-0vpn/openconnect/CMakeLists.txt
M  +1-0vpn/openconnect/nm-openconnect-service.h
M  +5-0vpn/openconnect/openconnectwidget.cpp
A  +18   -0   
vpn/openconnect/plasmanetworkmanagement_openconnect_juniperui.desktop
M  +1-0vpn/openconnect/plasmanetworkmanagement_openconnectui.desktop

http://commits.kde.org/plasma-nm/05a80ff9311c0880bb08fe7a00dcda3d1f34e864

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 363917] [RFE] [Openconnect] Add Juniper support for OpenConnect VPN

[Ian Turner via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363917

--- Comment #3 from Ian Turner  ---
I have a working patch but it is not ready for public submission. There have
been some offline discussions, to which I will subscribe you.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 363917] [RFE] [Openconnect] Add Juniper support for OpenConnect VPN

[Shmerl via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363917

--- Comment #2 from Shmerl  ---
Does anyone plan to work on this bug? I might be interested in helping, if
someone could give me some pointers where to start.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 363917] [RFE] [Openconnect] Add Juniper support for OpenConnect VPN

[Shmerl via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363917

Shmerl  changed:

   What|Removed |Added

 CC||shm...@mykolab.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 363917] [RFE] [Openconnect] Add Juniper support for OpenConnect VPN

[Jan Grulich via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363917

Jan Grulich  changed:

   What|Removed |Added

Summary|[RFE] Add Juniper support   |[RFE] [Openconnect] Add
   |for OpenConnect VPN |Juniper support for
   ||OpenConnect VPN

-- 
You are receiving this mail because:
You are watching all bug changes.