[plasma-nm] [Bug 383505] Apply button is disabled

[Jan Grulich]

https://bugs.kde.org/show_bug.cgi?id=383505

Jan Grulich  changed:

   What|Removed |Added

 CC||demch.kw...@gmail.com

--- Comment #8 from Jan Grulich  ---
*** Bug 388868 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 383505] Apply button is disabled

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=383505

David Edmundson  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/pla
   ||sma-nm/e0642ee0d8c09d753219
   ||5b9782a5533f2f5c1506
 Resolution|WONTFIX |FIXED

--- Comment #7 from David Edmundson  ---
Git commit e0642ee0d8c09d7532195b9782a5533f2f5c1506 by David Edmundson.
Committed on 03/10/2017 at 11:15.
Pushed by davidedmundson into branch 'Plasma/5.11'.

Don't duplicate UI option for automatic speed detection

Summary:
Network speed is determined automatically if "auto-negotiate" is set.
NM Spec says if that is not set a speed and duplex should be provided.

The .ui file defaulted to a speed
of 0 with had the special text of "automatic". This isn't actually
automatic, but just an invalid value which
WiredConnectionWidget::isValid (correctly) won't accept

End result is a user can't save any other settings as this widget
reports itself as invalid.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D7315

M  +7-1libs/editor/settings/ui/wiredconnectionwidget.ui

https://commits.kde.org/plasma-nm/e0642ee0d8c09d7532195b9782a5533f2f5c1506

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 383505] Apply button is disabled

[Jan Grulich]

https://bugs.kde.org/show_bug.cgi?id=383505

Jan Grulich  changed:

   What|Removed |Added

 CC||v...@yahoo.com

--- Comment #6 from Jan Grulich  ---
*** Bug 384939 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 383505] Apply button is disabled

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=383505

--- Comment #5 from David Edmundson  ---
Please also see a patch I made on phab that removed a duplication in the UI.

I think it makes it clearer, but it's only tested on the one version of nm.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 383505] Apply button is disabled

[Jan Grulich]

https://bugs.kde.org/show_bug.cgi?id=383505

Jan Grulich  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 CC||jgrul...@redhat.com
 Resolution|--- |WONTFIX

--- Comment #4 from Jan Grulich  ---
Some reference what is going on:
https://bugs.kde.org/show_bug.cgi?id=376018
https://bugs.kde.org/show_bug.cgi?id=378554

NM switched to using a different default value for auto-negotiation so we did
the same in networkmanager-qt, however it seems not to be understandable by
users so in plasma-nm we still default to old/previous behaviour, which means
auto-negotiation is set to true. Mixing various NM, nm-qt and plasma-nm
versions where some has different behaviour then expected when all of these
involved parties are updated to latest version might cause some problems.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 383505] Apply button is disabled

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=383505

Dr. Chapatin  changed:

   What|Removed |Added

 CC||yy...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 383505] Apply button is disabled

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=383505

wavemotion...@yahoo.com changed:

   What|Removed |Added

 CC||wavemotion...@yahoo.com

--- Comment #3 from wavemotion...@yahoo.com ---
I just wanted to chime in for an additional confirmation.  Though my
circumstances were slightly different I think it's the same issue - I was just
modifying the default config after a fresh install on Antergos, to use a static
IP rather than DHCP.

Not having even touched the other tabs, I was perplexed that the apply button
was disabled, and that "OK" also didn't save the changes.

I see the note from David, and I get the explanation, but if there were some
indication regarding why I couldn't use the "apply" button that would have
helped.  I was referred here from a reddit thread where I was trying to figure
out what I was doing wrong, and Martin's workaround was of course the answer.

Side note - I spend more time in Windows than I'd wish to due to my job, so
that may be why I'm asking this, but is it the intent to have "OK" and "Cancel"
do the same thing in this situation (which they did)?  I think I've come to
expect "OK" to mean "Apply and Close".  In which case OK should also have been
disabled until the autonegotiate setting was adjusted.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 383505] Apply button is disabled

[Martin Pola]

https://bugs.kde.org/show_bug.cgi?id=383505

--- Comment #2 from Martin Pola  ---
That makes sense, and yes, my speed was set to automatic. I installed KDE about
a year ago, and as I haven't edited my wired connection manually I assume it's
a left-over from whichever version Arch Linux had at that point.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 383505] Apply button is disabled

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=383505

--- Comment #1 from David Edmundson  ---
Code is doing exactly what it should be.

You can't have "allow auto-negotiation" unchecked and speed set to automatic
(which I assume yours is) it's an invalid configuration so you can't apply
anything.

I'll remove the special-zero case of it saying automatic, so it's clearer where
the bug is.
Also will be interesting to find out why your (and my) auto negotiation got
disabled.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 383505] Apply button is disabled

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=383505

David Edmundson  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
 CC||k...@davidedmundson.co.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 383505] Apply button is disabled

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=383505

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.